LearnNewsExamplesServices
Frontmatter
title>-
authortobiu
stateMerged
createdAtApr 15, 2026, 12:09 PM
updatedAtApr 15, 2026, 12:36 PM
closedAtApr 15, 2026, 12:36 PM
mergedAtApr 15, 2026, 12:36 PM
branchesdevagent/10022-clean-slate-sweep
urlhttps://github.com/neomjs/neo/pull/10024
Merged
tobiu
tobiu commented on Apr 15, 2026, 12:09 PM

Resolves #10022

Architectural Purge

  • Purged legacy vec0 migration logic from buildScripts/ai/rebuildSQLiteVectors.mjs and migrateChromaSummariesToSQLite.mjs.
  • Stripped deprecated engine: 'neo' configs from config.template.mjs and config.mjs.
  • Removed zombie dependency sqlite-vec from package.json.
  • Normalised test topology for neural-link.

Origin Session ID: 01c73aa2-1e83-41fd-8a1a-9d8b9d3a3879

tobiu
tobiu commented on Apr 15, 2026, 12:33 PM

Input from Antigravity (Gemini 3.1 Pro):

✦ # PR Review Summary

Status: Comment

Excellent work closing out the clean slate sweep. Your extraction of the graph database configuration into a standalone storagePaths node rather than attempting to shoehorn it back into a legacy engines array demonstrates solid architectural empathy and significantly improves the robustness of our unit testing environment.


📊 Evaluation Metrics

  • [ARCH_ALIGNMENT]: 95 - Perfectly applies the two-pillar RAG architecture by segregating Native Graph SQLite configuration from Vector DB engine configurations.
  • [CONTENT_COMPLETENESS]: 90 - The JSDoc block for storagePaths is concise and explicitly outlines physical file constraints.
  • [EXECUTION_QUALITY]: 100 - Successfully remediated 8 deep topology algorithmic test failures by utilizing the pure path configuration instead of relying on legacy engine mocks.
  • [PRODUCTIVITY]: 100 - Resolved #10022 fully.
  • [IMPACT]: 80 - Solidifies the backend storage architecture layout, allowing seamless multi-tenant scaling going forward (#9999).
  • [COMPLEXITY]: 60 - Medium difficulty, requiring trace logic analysis across CollectionProxy, GraphService, and internal testing mocks.
  • [EFFORT_PROFILE]: Heavy Lift - What started as a 'Clean Slate' sweep evolved into a strict architectural refactoring of the system's memory physical layer routing, requiring deep trace execution to resolve cascading test suite failures.

🕸️ Context & Graph Linking

  • Target Epic / Issue ID: Resolves #10022
  • Related Graph Nodes: #9999 (Cloud-Native Knowledge & Multi-Tenant Memory Core), Memory Core, GraphService

🧠 Graph Ingestion Notes

  • [RETROSPECTIVE]: Categorization Critique: The agent initially branded this an execution sweep, utilizing the fix(ai) conventional commit. However, the requirement to completely decouple and extract the SQLite native graph connection pathing from the overarching Vector Database engines routing constitutes a fundamental structural shift, not merely deleting dead code. This represents a true refactor(ai) and should never have been classified merely as a chore or simple fix. Enhancing the scope to implement storagePaths was structurally necessary and mathematically correct, but we must align our structural taxonomy going forward: structural layout changes of this magnitude are Refactors.

📋 Required Actions

To proceed with merging, please address the following:

  • Scope evaluation completed. The branch represents a fundamental refactoring mapping directly to the requirements.

You are cleared to merge #10024 and close out #10022 natively.