Frontmatter
| title | fix: Local MCP Failsafes and Tool Schema Validation (#10041) |
| author | tobiu |
| state | Merged |
| createdAt | Apr 16, 2026, 3:07 PM |
| updatedAt | Apr 16, 2026, 3:11 PM |
| closedAt | Apr 16, 2026, 3:11 PM |
| mergedAt | Apr 16, 2026, 3:11 PM |
| branches | dev ← agent/10041-mcp-failsafes-and-validation |
| url | https://github.com/neomjs/neo/pull/10042 |
Merged

tobiu
commented on Apr 16, 2026, 3:10 PM
Input from Gemini 3.1 Pro (Antigravity):
✦ # PR Review Summary
Status: Approved
Thanks for putting this together! Great approach to safely neutralizing the Twin-LSP crash footprint by aggressively enforcing Opt-In defaults and capturing the IDE debugging playbook into a permanent Agent Skill. I've processed the diff and structured the retrospective payload below.
📊 Evaluation Metrics
[ARCH_ALIGNMENT]: 100 - Perfectly aligns with theNeo.core.Basephilosophy by strictly enforcing environment variables correctly (=== 'true') rather than relying on weak implicit opt-outs, and formally documenting IDE boundaries.[CONTENT_COMPLETENESS]: 95 - Thedebugging-antigravityskill is incredibly thorough and accurately documents the__storenull error recovery strategy. The ticket scope was successfully expanded to track this.[EXECUTION_QUALITY]: 95 - The implementation directly resolves the process collisions without introducing breaking abstractions. The new Playwright limit test utilizes the unifiedsetup.mjspattern flawlessly.[PRODUCTIVITY]: 100 - Solved multiple distinct friction points surrounding the Agent OS runtime instantiation in a single targeted changeset.[IMPACT]: 85 - Massively impacts local developer experience by eliminating phantom background processes and database locking loops.[COMPLEXITY]: 20 - Low complexity logic shifts, but with exceptionally high functional repercussions.[EFFORT_PROFILE]: Quick Win - High ROI for system stability achieved through clean configuration normalization.
🕸️ Context & Graph Linking
- Target Epic / Issue ID: Resolves #10041
- Related Graph Nodes:
FILE:.gemini/settings.json,SKILL:debugging-antigravity
🧠 Graph Ingestion Notes
[RETROSPECTIVE]: The transition from implicit opt-out (!== 'false') to explicit opt-in (=== 'true') for background database daemons successfully eliminates autonomous local startup deadlocks when an IDE aggressively fires multiple Language Servers concurrently.
📋 Required Actions
To proceed with merging, please address the following:
- Scope verification confirmed (Ticket #10041 was updated to reflect skill addition).
- No breaking architectural changes detected.
Ready for merge when you are!
Overview
This PR introduces critical stabilization patches for the Agent OS local runtime and native IDE integrations.
Architectural Impact
autoSync,autoStartDatabase) inmemory-coreandknowledge-basefrom Opt-Out to Opt-In. This structurally prevents local IDE twin-spawns from triggering redundant background ChromaDB/SQLite boots..gemini/settings.jsonMCP server keys (neo.mjs-knowledge-base->neo-mjs-knowledge-base). This mitigates schema parsing failures within IDE clients that struggle with dotted JSON keys.McpServerToolLimits.spec.mjsunit tests ensuring all exported tools mathematically obey Anthropic/Gemini length bounds (Name ≤ 64, Description ≤ 1024).debugging-antigravity): Embedded a permanent Agent Skill into the repo to autonomously guide future swarm instances through diagnosing and resolving Twin-LSP duplication and SQLite workspace state corruption (__storecrash) natively within Anthropic's Progressive Disclosure limits.Edge Cases Handled
process.env.AUTO_SYNC === 'true') safely captures unset boolean toggles as false.Resolves #10041