LearnNewsExamplesServices
Frontmatter
titlechore(ai): add Acceptance Protocol to ticket-intake skill (#10051)
authortobiu
stateMerged
createdAtApr 17, 2026, 8:18 PM
updatedAtApr 17, 2026, 8:25 PM
closedAtApr 17, 2026, 8:25 PM
mergedAtApr 17, 2026, 8:25 PM
branchesdevagent/10051-ticket-intake-acceptance-protocol
urlhttps://github.com/neomjs/neo/pull/10053
Merged
tobiu
tobiu commented on Apr 17, 2026, 8:18 PM

Summary

Adds a mandatory Acceptance Protocol (new Section 3) to the ticket-intake skill that forces agents to auto-assign the ticket and create a feature branch before writing any code.

Problem

Agents were coding on dev and only branching at PR creation time. If a session crashes, dev is left dirty. Additionally, there was no mechanism to signal ticket ownership to the swarm, allowing duplicate pickup.

Changes

ticket-intake-workflow.md

  • New Section 3: Acceptance Protocol with two gates:
    • 3a. Auto-Assignmanage_issue_assignees(action: 'add', assignees: ['@me']) to claim ownership
    • 3b. Branch-Before-Codegit checkout -b agent/[ticket-id]-[descriptor] before any file modifications
  • Forbidden actions on dev/main: replace, write_file, multi_replace_file_content, git commit
  • Old Section 3 (Rejection Protocol) renumbered to Section 4
  • Section 2 (ROI) now explicitly directs to Section 4 on Negative ROI

openapi.yaml

  • manage_issue_assignees tool description updated to document @me as a special value
  • assignees property description mentions @me resolves to authenticated user
  • Example changed from hardcoded tobiu to @me

pull-request-workflow.md

  • Section 2 (Git Branching Mandate) cross-references the upstream intake branching gate

Verification

  • Empirically tested manage_issue_assignees(action: 'add', assignees: ['@me']) on issue #10051 — confirmed @me resolved to tobiu
  • No IssueService.mjs code changes needed — @me passes through transparently to gh issue edit --add-assignee "@me"

Resolves #10051

tobiu
tobiu commented on Apr 17, 2026, 8:21 PM

Input from Claude Opus 4.6 (Antigravity):

❋ # PR Review Summary

Status: Approved

Clean, focused workflow enhancement. The key insight — that @me passes transparently through IssueService.assignIssue() into gh issue edit --add-assignee "@me" without any service code changes — is empirically validated. This makes the entire PR a documentation/workflow-only change with zero blast radius on runtime behavior.


📊 Evaluation Metrics

  • [ARCH_ALIGNMENT]: 95 - Follows the meta-level "fix the system that builds the code" philosophy. Two-layer enforcement (intake creates branch, PR workflow validates) is sound defense-in-depth.
  • [CONTENT_COMPLETENESS]: 92 - PR body is comprehensive with empirical verification noted. The workflow documents are well-structured with clear examples.
  • [EXECUTION_QUALITY]: 95 - Minimal, surgical changes across 3 files. No dead code, no over-engineering. The Section 2 → Section 4 redirect on Negative ROI is a good navigational improvement.
  • [PRODUCTIVITY]: 100 - All acceptance criteria from #10051 met, plus the auto-assign enhancement exceeds original scope.
  • [IMPACT]: 70 - High organizational value for preventing dev pollution, but limited to agent workflow (no framework code impact).
  • [COMPLEXITY]: 20 - Straightforward markdown and YAML edits.
  • [EFFORT_PROFILE]: Quick Win - High ROI for minimal complexity. Directly prevents a recurring failure mode.

🕸️ Context & Graph Linking

  • Target Epic / Issue ID: Resolves #10051
  • Related Graph Nodes: ticket-intake skill, pull-request skill, manage_issue_assignees MCP tool, IssueService.assignIssue

🧠 Graph Ingestion Notes

  • [KB_GAP]: N/A — no framework concept gaps.
  • [TOOLING_GAP]: N/A — @me worked transparently without code changes.
  • [RETROSPECTIVE]: The discovery that gh CLI natively resolves @me eliminated an entire code change track. This is a good example of empirical verification (testing before coding) preventing unnecessary complexity. The two-layer branch enforcement pattern (intake gate + PR gate) establishes a robust defense-in-depth model for dev branch hygiene.

📋 Required Actions

None. This PR is ready to merge.

LGTM ✅