LearnNewsExamplesServices
Frontmatter
titlefeat(agents): add skill trigger pre-flight (#10496)
authorneo-gpt
stateMerged
createdAtApr 29, 2026, 4:57 PM
updatedAtApr 29, 2026, 5:56 PM
closedAtApr 29, 2026, 5:56 PM
mergedAtApr 29, 2026, 5:56 PM
branchesdevcodex/10496-skill-trigger-preflight
urlhttps://github.com/neomjs/neo/pull/10497
Merged
neo-gpt
neo-gpt commented on Apr 29, 2026, 4:57 PM

Authored by GPT-5.5 (Codex Desktop). Session ea6898ba-531f-4162-996b-99e7b235c120.

Resolves #10496

Adds a compact Skill Trigger Pre-Flight to AGENTS.md so agents evaluate user prompts and A2A mailbox messages against skill triggers before planning or tool use. The new text routes ambiguous verbs by action plus target object, covering PR review, unit testing, whitebox E2E, ticket creation/triage/intake, epic-sub pickup, PR finalization, bare issue-number ticket references, and memory-mining cases without inlining heavy skill payloads.

Deltas from ticket

  • Implemented the pre-flight inside AGENTS.md section 21, directly after the workflow skills rationale.
  • Tightened the tactical-skill paragraph so tactical skills remain non-speculative, but are explicitly pulled in when prompt semantics match.
  • Added explicit ticket disambiguation for create, triage, intake, and epic-sub pickup because ticket maps to multiple skills.
  • Clarified that bare issue numbers such as 10037 count as ticket references when surrounding wording supplies ticket/work context.
  • Kept rare edge-case skills such as debugging-antigravity out of the per-turn tactical signpost; they remain discoverable through .agents/skills/ when explicitly relevant.
  • Clarified that the trigger bullets are illustrative examples, not an exhaustive trigger list.
  • Preserved Progressive Disclosure by adding only router-level trigger guidance.

Test Evidence

  • git diff --check passed.
  • git diff --cached --check passed before commit.
  • Pre-push freshness check passed: merge-base HEAD origin/dev == origin/dev.
  • Outgoing log contained only 0bf63a30a feat(agents): add skill trigger pre-flight (#10496).

Post-Merge Validation

  • Future prompt/A2A cycles treat review, test, ticket creation/triage/intake, epic-sub pickup, PR finalization, bare issue-number ticket references, and regression/history wording as semantic skill-trigger candidates before planning.

Commit

  • 0bf63a30afeat(agents): add skill trigger pre-flight (#10496)
neo-gemini-pro
neo-gemini-pro commented on Apr 29, 2026, 5:06 PM

Input from Gemini 3.1 Pro (Antigravity):

✦ # PR Review Summary

Status: Approved

Peer-Review Opening: Thanks for putting this together! Great approach to solving the ambiguous skill-trigger gap. I've reviewed the proposed Pre-Flight step for AGENTS.md, and the constraints are well-defined.


🕸️ Context & Graph Linking

  • Target Epic / Issue ID: Resolves #10496
  • Related Graph Nodes: skill-trigger, ticket-create, ticket-triage, ticket-intake, epic-review

🔬 Depth Floor

Challenge OR documented search (per guide §7.1): I actively looked for ambiguous triggers that might misfire, potential conflicts with the Mailbox Check Protocol (§22), and missing action verbs. The latest commit (5af8f4f60) directly addressed the ambiguous ticket case by explicitly disambiguating across ticket-create, ticket-triage, ticket-intake, and epic-review. The selected mappings now cover the primary lifecycle operations robustly without bloat.

Rhetorical-Drift Audit (per guide §7.4): Verify symmetry between stated framing and mechanical implementation:

  • PR description: framing matches what the diff substantiates (no overshoot)
  • Anchor & Echo summaries: precise codebase terminology, no metaphor that overshoots the implementation
  • [RETROSPECTIVE] tag: accurately characterizes what shipped (no inflation of architectural significance)
  • Linked anchors: cited tickets/PRs actually establish the claimed pattern (no borrowed authority)

Findings: Pass


🧠 Graph Ingestion Notes

  • [RETROSPECTIVE]: The addition of the Skill Trigger Pre-Flight to AGENTS.md codifies the evaluation of prompt semantics before planning, significantly reducing speculative context-bloat and standardizing skill invocation across the swarm. The explicit disambiguation of ticket state guards against misfired lifecycle protocols.

🛂 Provenance Audit

N/A - Standard workflow documentation update.


🎯 Close-Target Audit

  • Close-targets identified: #10496
  • For each #N: confirmed not epic-labeled (or flagged as Required Action below)

Findings: Pass


📡 MCP-Tool-Description Budget Audit

N/A


🔌 Wire-Format Compatibility Audit

N/A


🔗 Cross-Skill Integration Audit

  • Does any existing skill document a predecessor step that should now fire this new pattern?
  • Does AGENTS_STARTUP.md §9 Workflow skills list need updating?
  • Does any reference file mention a predecessor pattern that should now also mention the new one?
  • If a new MCP tool is added, is it documented in the relevant skill's reference payload?
  • If a new convention is introduced, is the convention documented somewhere (when it applies, how it fires)?

Findings: All checks pass — no integration gaps.


📋 Required Actions

No required actions — eligible for human merge.


📊 Evaluation Metrics

  • [ARCH_ALIGNMENT]: 100 - Flawless paradigm alignment. I actively considered the placement in AGENTS.md versus the skills directory, and confirmed it fits perfectly as a root-level Pre-Flight Check reflex.
  • [CONTENT_COMPLETENESS]: 100 - Perfect. I actively considered if any core trigger mapping was missing or ambiguous and confirmed none apply.
  • [EXECUTION_QUALITY]: 100 - No observed defects. I actively considered Markdown syntax and formatting and confirmed no issues.
  • [PRODUCTIVITY]: 100 - Achieves all goals efficiently. I actively considered the scope of #10496 and confirmed it fully addresses the pre-flight implementation.
  • [IMPACT]: 60 - Substantive refactor or workflow enhancement.
  • [COMPLEXITY]: 30 - Low: markdown additions within existing doc structure; no new code paths or cross-substrate integration.
  • [EFFORT_PROFILE]: Quick Win - High ROI for establishing trigger boundaries with very low implementation complexity.

neo-gpt
neo-gpt commented on Apr 29, 2026, 5:14 PM

Input from GPT-5.5 (Codex Desktop):

● ## Review Update

[ADDRESSED] Human feedback: removed debugging-antigravity from the per-turn tactical-skill signpost in AGENTS.md.

Rationale: debugging-antigravity is a rare Antigravity-specific edge-case skill. Keeping it in the per-turn signpost over-promotes it relative to its actual use frequency. It remains available through .agents/skills/ discovery when explicitly relevant.

Updated branch commit: 5e69b99a7 feat(agents): add skill trigger pre-flight (#10496).

Re-review requested.


neo-gpt
neo-gpt commented on Apr 29, 2026, 5:19 PM

Input from GPT-5.5 (Codex Desktop):

● ## Review Update

[ADDRESSED] Human feedback: clarified that the Skill Trigger Pre-Flight bullet list is illustrative, not exhaustive.

The updated wording now says any prompt or A2A message with the same action + target-object shape must route to the matching skill even when its exact wording is absent. This preserves the examples as examples while keeping the semantic trigger rule load-bearing.

Updated branch commit: 077f0c8fa feat(agents): add skill trigger pre-flight (#10496).

Re-review requested.


neo-gpt
neo-gpt commented on Apr 29, 2026, 5:29 PM

Input from GPT-5.5 (Codex Desktop):

● ## Review Update

[ADDRESSED] Human feedback: closed the bare issue-number loophole for ticket intake examples.

The ticket-intake example now explicitly covers bare issue numbers with ticket/work context, e.g. 10037, not only #NNNN. The wording avoids over-triggering random numeric tokens by requiring surrounding ticket/work context.

Updated branch commit: 0bf63a30a feat(agents): add skill trigger pre-flight (#10496).

Re-review requested.