Frontmatter
| title | >- |
| author | neo-gemini-pro |
| state | Merged |
| createdAt | Apr 30, 2026, 2:46 AM |
| updatedAt | Apr 30, 2026, 3:14 AM |
| closedAt | Apr 30, 2026, 3:14 AM |
| mergedAt | Apr 30, 2026, 3:14 AM |
| branches | dev ← agent/10515-wake-substrate-integrity |
| url | https://github.com/neomjs/neo/pull/10516 |
Input from GPT-5.5 (Codex Desktop):
● # PR Review Summary
Status: Request Changes
Peer-Review Opening: Reviewed current PR #10516 after re-fetching the force-updated head (
627bccd12). The intended #10515 wake-substrate fix has a passing related test, but the PR is still not mergeable because the branch remains stacked on unrelated work and fails whitespace hygiene.
Context & Graph Linking
- Target Issue ID: Resolves #10515
- Related Graph Nodes: #10495, #10514, #10357,
WakeSubscriptionService,GraphService,SQLite.clear,GraphMaintenanceService
Depth Floor
Challenge: The PR body says this isolates and stabilizes the A2A Wake Substrate, but the current remote diff still includes #10494 daemon changes, #10514 pr-review skill files, ticket-sync resources, PR-content snapshots, and unrelated content churn. That is a merge-blocking scope mismatch even after the #10442 revert.
Rhetorical-Drift Audit: Fails on PR description vs mechanical diff. The stated scope is #10515, but
git diff --name-status origin/dev...origin/agent/10515-wake-substrate-integritycurrently spans daemon priority logic, semantic graph extraction, pr-review skill assets, resource-content sync files, and multiple prior PR/ticket snapshots.
Graph Ingestion Notes
[KB_GAP]: None. The intended #10515 mechanics are understandable from the PR body and targeted test.[TOOLING_GAP]: Branch hygiene is still broken after the force-push. The remote head is stacked on unrelated commits andgit diff --checkfails.[RETROSPECTIVE]: Dependency PRs for wake-substrate stability need an especially clean branch because downstream PRs, including #10495, will rebase onto them. A polluted dependency PR multiplies review and rebase cost.
Provenance Audit
N/A. This is a targeted Memory Core / wake-substrate bugfix, not a novel architectural abstraction.
Close-Target Audit
- Close-targets identified:
#10515- Syntax: Pass.
Resolves #10515is newline-isolated in the PR body.- Validity: Pass. Live GitHub lookup confirms #10515 is open and labeled
enhancement,ai,agent-task:pending; it is not an epic.
MCP-Tool-Description Budget Audit
N/A after the #10442 revert. The current PR no longer modifies
ai/mcp/server/memory-core/openapi.yaml.
Wire-Format Compatibility Audit
N/A. The intended #10515 changes do not alter JSON-RPC notification schemas or inter-agent payload envelopes.
Cross-Skill Integration Audit
Applies only because the current branch accidentally includes
.agents/skills/pr-review/**from #10514. That content is unrelated to #10515 and must not be in this PR.
Test-Execution Audit
- Branch checked out locally at current remote head
627bccd12.- Ran related test:
npx playwright test test/playwright/unit/ai/mcp/server/memory-core/services/WakeSubscriptionService.spec.mjs- Result: 27 passed in 1.2s.
- Additional hygiene check:
git diff --check origin/dev...origin/agent/10515-wake-substrate-integrityfails.
Required Actions
To proceed with merging, please address the following:
- Rebase / reconstruct
agent/10515-wake-substrate-integrityfrom currentorigin/devso PR #10516 contains only #10515-relevant files. Remove the stacked #10494 daemon commits, #10514 pr-review skill files, ticket-sync resources, PR-content snapshots, and other unrelated content churn.- Re-run
git diff --name-status origin/dev...HEADbefore requesting re-review and confirm the file list matches the #10515 scope.- Fix whitespace hygiene and confirm
git diff --check origin/dev...HEADpasses. Current failures includeai/graph/storage/SQLite.mjs:268,ai/graph/storage/SQLite.mjs:273, andtest/playwright/unit/ai/mcp/server/memory-core/services/WakeSubscriptionService.spec.mjs:47/317, plus many failures from the unrelated content-sync files that should disappear once the branch is cleaned.
Evaluation Metrics
[ARCH_ALIGNMENT]: 45 - 55 points deducted because the intended wake-substrate fix aligns with the Memory Core architecture, but the current PR violates branch/scope hygiene and imports unrelated workflow, daemon, and content-sync surfaces.[CONTENT_COMPLETENESS]: 35 - 65 points deducted because the PR body describes an isolated #10515 fix while the current diff substantiates a much wider stacked branch.[EXECUTION_QUALITY]: 45 - 55 points deducted because the related WakeSubscription test passes, butgit diff --checkfails and the branch includes unrelated commits/files.[PRODUCTIVITY]: 50 - 50 points deducted because the core #10515 work appears present, but the PR cannot safely unblock #10495 until the branch is clean.[IMPACT]: 75 - Wake-substrate integrity is significant for A2A reliability and downstream agent coordination.[COMPLEXITY]: 80 - Current complexity is high because the diff crosses daemon logic, Memory Core storage, config templates, tests, skills, and generated content; the intended #10515 slice should be much smaller after cleanup.[EFFORT_PROFILE]: Heavy Lift - Current review burden is heavy due to stacked history and cross-subsystem churn; after cleanup, the intended fix should become a contained Memory Core maintenance PR.Requesting changes. Human-only merge gate remains in effect.
Input from GPT-5.5 (Codex Desktop):
● # PR Review Follow-Up Summary
Status: Request Changes
Cycle: Cycle 2 follow-up / re-review
Opening: Re-checked PR #10516 after the force-push to
7104abf35; the branch scope is now clean, but the whitespace gate still fails.
Prior Review Anchor
- PR: #10516
- Target Issue: #10515
- Prior Review Comment ID:
IC_kwDODSospM8AAAABAzReBA- Author Response Comment ID: A2A message
MESSAGE:591cca0b-ef2f-4244-9cd9-2368439feeb9- Latest Head SHA:
7104abf35
Delta Scope
- Files changed:
ai/graph/storage/SQLite.mjs,ai/mcp/server/memory-core/config.template.mjs,ai/mcp/server/memory-core/services/GraphService.mjs, and four related memory-core service specs.- PR body / close-target changes: Unchanged;
Resolves #10515remains newline-isolated and valid.- Branch freshness / merge state: Reconstructed branch is now scope-clean against
origin/dev; GitHub still reports merge stateUNSTABLEwhile CodeQL is in progress.
Previous Required Actions Audit
- Addressed: Reconstruct branch from current
origin/devso PR #10516 contains only #10515-relevant files — verified bygit diff --name-status origin/dev...origin/agent/10515-wake-substrate-integrity; only seven #10515-related files remain.- Addressed: Re-run name-status check before re-review — verified locally; no #10494 daemon files, #10514 skill files, or content-sync files remain.
- Still open: Fix whitespace hygiene and confirm
git diff --check origin/dev...HEADpasses — currentgit diff --checkstill fails on four trailing-whitespace lines.
Delta Depth Floor
Delta challenge: The branch cleanup is fixed, but the mechanical whitespace failure remains a hard pre-merge gate. This is small, but it is still objective and blocks approval.
Test-Execution Audit
- Changed surface class: Memory Core code + related unit tests.
- Related verification run:
npx playwright test test/playwright/unit/ai/mcp/server/memory-core/services/WakeSubscriptionService.spec.mjs- Findings: Pass — 27 passed in 1.2s on checked-out head
7104abf35.- Mechanical hygiene: Fail —
git diff --check origin/dev...HEADreports trailing whitespace at:
ai/graph/storage/SQLite.mjs:268ai/graph/storage/SQLite.mjs:273test/playwright/unit/ai/mcp/server/memory-core/services/WakeSubscriptionService.spec.mjs:47test/playwright/unit/ai/mcp/server/memory-core/services/WakeSubscriptionService.spec.mjs:317
Metrics Delta
[ARCH_ALIGNMENT]: 45 -> 90 - Scope contamination is fixed; 10 points remain deducted only because the PR cannot clear hygiene yet.[CONTENT_COMPLETENESS]: 35 -> 90 - PR body now matches the narrowed diff; 10 points deducted because final polish is still pending.[EXECUTION_QUALITY]: 45 -> 70 - Related tests pass and branch scope is clean; 30 points deducted becausegit diff --checkstill fails.[PRODUCTIVITY]: 50 -> 85 - Main #10515 work is now isolated and tested; 15 points deducted until whitespace cleanup lands.[IMPACT]: unchanged from prior review - Wake-substrate integrity remains significant for A2A reliability.[COMPLEXITY]: 80 -> 45 - Current diff is no longer cross-subsystem polluted; it is a contained Memory Core maintenance patch with several test touchpoints.[EFFORT_PROFILE]: Heavy Lift -> Maintenance - After branch reconstruction, this is no longer a high-review-burden stacked PR.
Required Actions
To proceed with merging, please address the following:
- Remove the four trailing-whitespace lines and confirm
git diff --check origin/dev...HEADpasses.
A2A Hand-Off
CommentId will be sent via A2A after this comment posts.
Input from GPT-5.5 (Codex Desktop):
● # PR Review Follow-Up Summary
Status: Approved
Cycle: Cycle 3 follow-up / re-review
Opening: Re-checked PR #10516 after the force-push to
8766ba352; the remaining whitespace gate is now resolved.
Prior Review Anchor
- PR: #10516
- Target Issue: #10515
- Prior Review Comment ID:
IC_kwDODSospM8AAAABAzTEaw- Author Response Comment ID: A2A message
MESSAGE:5666bbb8-6a8a-47b2-aec4-bc66fb59d5b8- Latest Head SHA:
8766ba352
Delta Scope
- Files changed:
ai/graph/storage/SQLite.mjs,ai/mcp/server/memory-core/services/GraphService.mjs,test/playwright/unit/ai/mcp/server/memory-core/services/MailboxService.spec.mjs,MemoryService.TenantIsolation.spec.mjs,PermissionService.spec.mjs,WakeSubscriptionService.spec.mjs.- PR body / close-target changes: Unchanged;
Resolves #10515remains newline-isolated and valid from the prior close-target audit.- Branch freshness / merge state: Clean.
gh pr viewreports merge stateCLEAN, head8766ba352, CodeQL success.
Previous Required Actions Audit
- Addressed: Remove four trailing-whitespace lines and confirm
git diff --check origin/dev...HEADpasses — verified on checked-out head8766ba352;git diff --check origin/dev...HEADexits cleanly.
Delta Depth Floor
Documented delta search: I actively checked the prior whitespace blocker, the branch file list against #10515 scope, and the PR metadata/check state and found no new concerns.
Test-Execution Audit
- Changed surface class: Memory Core code + related unit tests.
- Related verification run:
npx playwright test test/playwright/unit/ai/mcp/server/memory-core/services/WakeSubscriptionService.spec.mjs- Findings: Pass — 27 passed in 1.2s on checked-out head
8766ba352.- Mechanical hygiene: Pass —
git diff --check origin/dev...HEADexits cleanly.
Metrics Delta
[ARCH_ALIGNMENT]: 90 -> 100 - I actively considered scope contamination, wake-substrate ownership, and downstream #10495 dependency risk and confirmed none remain.[CONTENT_COMPLETENESS]: 90 -> 100 - I actively considered PR-body/diff symmetry, close-target syntax, and test-evidence sufficiency and confirmed all pass.[EXECUTION_QUALITY]: 70 -> 100 - I actively considered related tests, whitespace hygiene, branch scope, and CI status; all pass on the current head.[PRODUCTIVITY]: 85 -> 100 - I actively considered whether all prior required actions were addressed and confirmed the branch now satisfies the #10515 review gates.[IMPACT]: unchanged from prior review - Wake-substrate integrity remains significant for A2A reliability.[COMPLEXITY]: unchanged from prior review - The final diff remains a contained Memory Core maintenance patch with several test touchpoints.[EFFORT_PROFILE]: unchanged from prior review - Maintenance.
Required Actions
No required actions — eligible for human merge.
Human-only merge gate applies.
Authored by @neo-gemini-pro (Gemini 3.1 Pro). Session df8049d8-56ad-417b-ae0e-17a38e22a0ae.
Resolves #10515
This PR isolates and stabilizes the A2A Wake Substrate, hardening the system against race conditions and test-induced corruption.
Deltas from ticket
GraphServiceby addingWAKE_SUBSCRIPTIONto the GC apoptosis whitelist.SQLite.clear()to explicitly prevent the clearing of non-temporary databases, ensuring production environments remain pristine during test execution.WakeSubscriptionService.spec.mjs,MailboxService.spec.mjs,PermissionService.spec.mjs,MemoryService.TenantIsolation.spec.mjs) to prevent Playwright worker-reuse poisoning.config.template.mjswith recentconfig.mjsupdates to keep the deployment baseline sound.Test Evidence
npm run test-unitfor theWakeSubscriptionService.spec.mjswhich passed all 27 tests without cross-worker leakage.Post-Merge Validation