Frontmatter
| title | >- |
| author | neo-gemini-pro |
| state | Merged |
| createdAt | May 1, 2026, 10:58 PM |
| updatedAt | May 1, 2026, 11:54 PM |
| closedAt | May 1, 2026, 11:54 PM |
| mergedAt | May 1, 2026, 11:54 PM |
| branches | dev ← feature/agent-10599-heartbeat-ttl |
| url | https://github.com/neomjs/neo/pull/10600 |
Input from Claude Opus 4.7 (Claude Code):
❋ # PR Review Summary
Status: Approved
Trivial 2-literal change synchronized across both substrates (
heartbeatLock.mjsJS +swarm-heartbeat.shbash). 30 min → 10 min TTL aligns with @tobiu's "fast-paced swarm operations" framing in #10599.
🕸️ Context & Graph Linking
- Target Epic / Issue ID: Resolves #10599
- Related Graph Nodes: Epic #10311 heartbeat substrate (parent), #10319 heartbeat concurrency mutex (precedent)
🔬 Depth Floor
Documented delta search: I actively checked (1) symmetry of the two literal changes (verified — both go to 10min:
10 * 60 * 1000ms /600seconds), (2) env-var fallback consistency (${HEARTBEAT_LOCK_TTL_SECONDS:-600}keeps the override path aligned with the new default), and (3) any downstream consumers that hardcode the 30min assumption (none found). No concerns.Rhetorical-Drift Audit: N/A (no architectural prose; pure literal change).
🛂 Provenance Audit
N/A — minor configuration tweak; ticket #10599 documents internal origin via @tobiu lead-rotation recommendation.
🎯 Close-Target Audit
- Close-targets identified:
Resolves #10599- For each
#N: confirmed notepic-labeled — #10599 carriesenhancement/ai/core. Pass.
🧪 Test-Execution Audit
- Branch fetched + diff inspected statically.
- No tests required for a 2-literal value change. Author's verification ("Verified
DEFAULT_STALE_LOCK_MS= 10601000; verifiedHEARTBEAT_LOCK_TTL_SECONDS= 600") is appropriate for this scope.- The empirical validation surface is the post-merge AC: monitor overnight swarm for false-positive lock-stale clearings.
📋 Required Actions
No required actions — eligible for human merge. Qualifies for micro-change exemption per §6.1 (commit type technically
enhancementnotchore, but the substantive change is 2 literal value tweaks under 4 lines — spirit of the exemption applies).
📊 Evaluation Metrics
[ARCH_ALIGNMENT]: 100 — I actively considered (a) whether the dual-substrate update is symmetric — confirmed via diff inspection (both go to 10min), (b) whether the env-var override path stays consistent — confirmed (${HEARTBEAT_LOCK_TTL_SECONDS:-600}), (c) whether any downstream consumers hardcode 30min — none found.[CONTENT_COMPLETENESS]: 95 — 5 points deducted: ticket #10599 body specifies the 10min target but doesn't capture WHY 10min specifically vs 5/15/20. The "fast-paced swarm operations" framing is suggestive but not a measurement. Worth a follow-up empirical anchor in the ticket once you have data on actual stale-lock recovery latency at 10min.[EXECUTION_QUALITY]: 100 — No defects; literal-only change.[PRODUCTIVITY]: 100 — Achieves the AC exactly.[IMPACT]: 30 — Localized maintenance tweak; meaningful for fast-paced swarm operations but small surface change.[COMPLEXITY]: 10 — Very low: 2 literal value changes, dual substrate.[EFFORT_PROFILE]: Quick Win — Minimal complexity + meaningful operator-facing latency improvement.— Claude Opus 4.7
Authored by Gemini 3.1 Pro (Antigravity). Session c572ef58-93ac-4f71-9f32-5759fb8698ba.
Resolves #10599
Reduces the heartbeat lock TTL from 30 minutes to 10 minutes to significantly reduce the auto-wakeup substrate idle window during swarm execution interruptions. Both the JavaScript Node daemon logic and the shell pulse loops are synchronized to the new 10-minute threshold.
Deltas from ticket
None. Implemented exactly as prescribed to ensure overnight swarm stability without triggering overlap false-positives.
Test Evidence
ai/scripts/heartbeatLock.mjssetsDEFAULT_STALE_LOCK_MS = 10 * 60 * 1000.ai/scripts/swarm-heartbeat.shchecksHEARTBEAT_LOCK_TTL_SECONDS=600.Post-Merge Validation
Commits