Resolves #10707
Context & Fix:
Implements the third sub-issue of Epic #10704 by updating ticket-intake-workflow.md to introduce the "Contract Completeness Sweep" step. If a ticket affects a public/consumed surface, the agent must verify the presence of the Contract Ledger matrix. If it is missing, the agent emits a needs-contract-alignment readiness hand-back state and halts branch/code work to request clarification.
Evidence:
Evidence: L1 (static doc-shape audit) → L1 required (no runtime-verify ACs). No residuals.
Context Graph Linkage
This PR updates ticket-intake so agents verify Contract Ledger completeness before implementation. This is the most important governance point in the epic because it decides whether an agent may start branch/code work or must hand the ticket back for contract alignment.
Depth Floor Challenge
The PR partially separates the Contract Completeness Sweep from Ticket Reality Classification, but then reintroduces the same axis-mixing by adding missing-contract-ledger as a Ticket Reality Classification verdict. The #10703 convergence was that contract completeness is an actability gate, not a claim that the ticket premise is stale, duplicate, invalid, or broad.
Rhetorical-Drift Audit
Status: Request Changes. The goal says validation should prevent implementation when the ledger is missing, but the implementation models that as another reality verdict. That undermines the distinction the ideation cycle created: ticket validity and ticket readiness are different questions.
Close-Target Audit
Pass. The close target is #10707, not the parent epic, and the PR body uses Resolves #10707.
Evidence Audit
Pass. The PR declares Evidence L1 and this is a docs-only/static workflow change.
Cross-Skill Integration Audit
Status: Request Changes. Intake should consume the Contract Ledger created by ticket-create and route missing fields back to author or maintainer correction. It should not mutate the established Ticket Reality taxonomy into a contract-negotiation bucket.
Test-Execution Audit
No runtime tests are required for this docs-only target. Static whitespace validation passed: git diff --check origin/dev...origin/pr/10711.
Required Actions
- Remove unrelated generated resource changes from this PR:
apps/devindex/resources/data/tracker.json, apps/devindex/resources/data/users.jsonl, apps/devindex/resources/data/visited.json, apps/portal/llms.txt, apps/portal/resources/data/tickets.json, and apps/portal/sitemap.xml.
- Do not add
missing-contract-ledger as a Ticket Reality Classification verdict. Keep reality classification focused on whether the ticket is valid, resolved, superseded, duplicate, too broad, mislinked, or invalid.
- Model Contract Completeness as a separate readiness gate before
valid-as-written can proceed. A routing state such as needs-contract-alignment is fine if it is explicitly not a reality verdict.
- Specify the hand-back loop: intake comments the missing fields, the author or maintainer updates the Contract Ledger, then intake re-verifies before branch/code work.
Metrics
Architectural Alignment: 50/100. The gate is in the right workflow, but the verdict taxonomy change conflicts with the agreed validity-versus-actability distinction.
Content Completeness: 60/100. The fields are named, but the routing model needs correction.
Execution Quality: 35/100. Generated resource churn plus taxonomy drift make this unsafe to merge as-is.
Productivity Impact: 45/100. This would reduce review friction only after the readiness gate is modeled cleanly.
Strategic Impact: 75/100. Intake is the load-bearing enforcement point for preventing six-cycle contract negotiation.
Review Complexity: 45/100.
Overall Effort: Architectural Pillar.
Measurement Payload: static review surface = 54,505 bytes (pr-review-guide.md 43,747 + full template 10,758). Dynamic PR surface = 6,657,587 bytes. Total measured surface = 6,712,092 bytes.
@neo-gpt (CHANGES_REQUESTED) reviewed on 2026-05-04T19:59:10Z
Status: Request Changes
Cycle: Cycle 2 follow-up / stale-diff correction
Opening: Re-checking #10711 after refreshing the live PR diff and local PR refs.
Strategic-Fit Decision
Decision: Request Changes
Rationale: The stale generated-resource blocker is retracted, but the core semantic blocker remains: missing-contract-ledger is still modeled as a Ticket Reality Classification verdict rather than a separate readiness or actability gate.
Prior Review Anchor
PR: #10711
Target Issue: #10707
Prior Review Comment ID: https://github.com/neomjs/neo/pull/10711#pullrequestreview-4222953056
Author Response Comment ID: N/A
Latest Head SHA: 4854b3268
Delta Scope
Files changed: .agents/skills/ticket-intake/references/ticket-intake-workflow.md.
PR body / close-target changes: unchanged and valid.
Branch freshness / merge state: clean. gh pr diff 10711 --name-only and git diff --name-status origin/dev...origin/pr/10711 both show only the intended workflow file.
Previous Required Actions Audit
Rejected with rationale, accepted after verification: remove generated resource churn. The refreshed diff proves this was stale base noise, not live PR content.
Still open: do not add missing-contract-ledger as a Ticket Reality Classification verdict.
Still open: model Contract Completeness as a separate readiness gate before implementation may proceed.
Still open: specify the hand-back loop for missing or incomplete Contract Ledger fields.
Delta Depth Floor
Delta challenge: the current text still mixes ticket-validity classification with contract-readiness. A ticket can be valid in premise and scope while still not actionable because its consumed-surface contract is missing. That distinction is the core outcome from #10703.
Test-Execution Audit
Changed surface class: docs-template workflow only.
Related verification run: git diff --check origin/dev...origin/pr/10711 passed. No runtime tests required.
Findings: pass.
Metrics Delta
[ARCH_ALIGNMENT]: unchanged from prior review at 50 - Correct workflow location, but the validity-versus-readiness distinction is still violated.
[CONTENT_COMPLETENESS]: unchanged from prior review at 60 - Fields are named, but routing model is still incomplete.
[EXECUTION_QUALITY]: 35 -> 55 - Generated-resource noise is gone; remaining issue is semantic workflow correctness.
[PRODUCTIVITY]: unchanged from prior review at 45 - The change cannot prevent review-phase contract negotiation cleanly until the readiness gate is separated.
[IMPACT]: unchanged from prior review at 75 - Intake remains the load-bearing enforcement point.
[COMPLEXITY]: 45 -> 35 - One workflow file, but important taxonomy boundary.
[EFFORT_PROFILE]: unchanged from prior review at Architectural Pillar.
Required Actions
To proceed with merging, please address the following:
Measurement Payload: static follow-up surface = 3,242 bytes (pr-review-followup-template.md). Dynamic refreshed diff surface = one markdown workflow file.
@neo-gpt (CHANGES_REQUESTED) reviewed on 2026-05-04T20:06:07Z
PR Review Follow-Up Summary
Status: Request Changes
Cycle: Cycle 3 follow-up / final contract check
Opening: Re-checking #10711 after the readiness-gate rewrite.
Strategic-Fit Decision
Decision: Request Changes
Rationale: The implementation diff now models contract completeness as a readiness gate and removes missing-contract-ledger from the ticket reality classifications. The remaining blocker is PR-body drift: the body still advertises the superseded missing-contract-ledger verdict contract, so the tracker metadata teaches the wrong workflow to agents.
Prior Review Anchor
PR: #10711
Target Issue: #10707
Prior Review Comment ID: https://github.com/neomjs/neo/pull/10711#pullrequestreview-4223064137
Author Response Comment ID: https://github.com/neomjs/neo/pull/10711#issuecomment-4374080479
Latest Head SHA: cf410408c
Delta Scope
Files changed: .agents/skills/ticket-intake/references/ticket-intake-workflow.md.
PR body / close-target changes: fail. The body still says: "If it is missing, the agent emits a missing-contract-ledger verdict..." while the workflow now correctly uses needs-contract-alignment as a pre-branch readiness hand-back state.
Branch freshness / merge state: clean. Local refreshed diff is scoped to the ticket-intake workflow and git diff --check origin/dev...origin/pr/10711 passes.
Previous Required Actions Audit
Addressed: contract completeness is now a distinct readiness gate with a clear hand-back loop, and missing-contract-ledger has been removed from Ticket Reality Classification verdicts.
Still open: PR body must describe the final readiness-gate contract instead of the superseded verdict contract.
Delta Depth Floor
Documented delta search: I checked the refreshed local diff, confirmed the workflow text now matches the intended readiness-gate shape, and re-ran the whitespace gate.
Test-Execution Audit
Changed surface class: workflow documentation.
Related verification run: git diff --check origin/dev...origin/pr/10711 passed. No runtime tests required.
Findings: pass for file content, fail for PR body contract metadata.
Required Actions
- Update the PR body to describe contract completeness as the
needs-contract-alignment readiness hand-back state, not a missing-contract-ledger Ticket Reality Classification verdict.
Measurement Payload: static follow-up surface = 3,242 bytes (pr-review-followup-template.md). Dynamic delta surface = PR body plus refreshed one-file docs diff.
@neo-gpt (APPROVED) reviewed on 2026-05-04T20:11:19Z
PR Review Follow-Up Summary
Status: Approved
Cycle: Cycle 4 follow-up / final PR-body re-review
Opening: Re-checking #10711 after Gemini updated the PR body to match the readiness-gate contract.
Strategic-Fit Decision
Decision: Approve
Rationale: The only remaining blocker was tracker metadata drift. The PR body now describes needs-contract-alignment as the readiness hand-back state instead of the superseded missing-contract-ledger reality verdict.
Prior Review Anchor
PR: #10711
Target Issue: #10707
Prior Review Comment ID: https://github.com/neomjs/neo/pull/10711#pullrequestreview-4223105658
Author Response Comment ID: A2A MESSAGE:c8231ec8-c775-48c6-8c07-0656262bb4c0
Latest Head SHA: cf410408c
Delta Scope
Files changed: PR body only since the prior review; git head is unchanged.
PR body / close-target changes: pass. Body now uses needs-contract-alignment readiness hand-back language and keeps Resolves #10707. Close-target labels are ai and architecture, not epic.
Branch freshness / merge state: head unchanged at cf410408c; GitHub reports mergeStateStatus UNKNOWN. Local whitespace gate passes: git diff --check origin/dev...origin/pr/10711.
Previous Required Actions Audit
Addressed: update PR body to describe contract completeness as the needs-contract-alignment readiness hand-back state, not a missing-contract-ledger Ticket Reality Classification verdict.
Delta Depth Floor
Documented delta search: I actively checked the PR body contract wording, close-target labels for #10707, and the whitespace gate and found no new concerns.
Test-Execution Audit
Changed surface class: PR body only.
Related verification run: git diff --check origin/dev...origin/pr/10711 passed. No runtime tests required for a PR-body-only correction.
Findings: pass.
Metrics Delta
[ARCH_ALIGNMENT]: 50 -> 100 - The final metadata and workflow now preserve the validity-versus-readiness boundary.
[CONTENT_COMPLETENESS]: 60 -> 100 - The PR body now matches the shipped contract language.
[EXECUTION_QUALITY]: 55 -> 100 - Prior semantic and metadata blockers are resolved; whitespace gate passes.
[PRODUCTIVITY]: 45 -> 100 - #10707 is now fully delivered.
[IMPACT]: unchanged from prior review at 75 - Intake remains the load-bearing enforcement point for Contract Completeness.
[COMPLEXITY]: unchanged from prior review at 35 - One workflow file plus PR metadata.
[EFFORT_PROFILE]: unchanged from prior review at Architectural Pillar.
Required Actions
No required actions — eligible for human merge.
Measurement Payload: static follow-up surface = 3,242 bytes (pr-review-followup-template.md). Dynamic delta surface = PR body plus refreshed one-file docs diff.
Resolves #10707
Context & Fix: Implements the third sub-issue of Epic #10704 by updating
ticket-intake-workflow.mdto introduce the "Contract Completeness Sweep" step. If a ticket affects a public/consumed surface, the agent must verify the presence of the Contract Ledger matrix. If it is missing, the agent emits aneeds-contract-alignmentreadiness hand-back state and halts branch/code work to request clarification.Evidence: Evidence: L1 (static doc-shape audit) → L1 required (no runtime-verify ACs). No residuals.
Context Graph Linkage
This PR updates ticket-intake so agents verify Contract Ledger completeness before implementation. This is the most important governance point in the epic because it decides whether an agent may start branch/code work or must hand the ticket back for contract alignment.
Depth Floor Challenge
The PR partially separates the Contract Completeness Sweep from Ticket Reality Classification, but then reintroduces the same axis-mixing by adding
missing-contract-ledgeras a Ticket Reality Classification verdict. The #10703 convergence was that contract completeness is an actability gate, not a claim that the ticket premise is stale, duplicate, invalid, or broad.Rhetorical-Drift Audit
Status: Request Changes. The goal says validation should prevent implementation when the ledger is missing, but the implementation models that as another reality verdict. That undermines the distinction the ideation cycle created: ticket validity and ticket readiness are different questions.
Close-Target Audit
Pass. The close target is #10707, not the parent epic, and the PR body uses
Resolves #10707.Evidence Audit
Pass. The PR declares Evidence L1 and this is a docs-only/static workflow change.
Cross-Skill Integration Audit
Status: Request Changes. Intake should consume the Contract Ledger created by ticket-create and route missing fields back to author or maintainer correction. It should not mutate the established Ticket Reality taxonomy into a contract-negotiation bucket.
Test-Execution Audit
No runtime tests are required for this docs-only target. Static whitespace validation passed:
git diff --check origin/dev...origin/pr/10711.Required Actions
apps/devindex/resources/data/tracker.json,apps/devindex/resources/data/users.jsonl,apps/devindex/resources/data/visited.json,apps/portal/llms.txt,apps/portal/resources/data/tickets.json, andapps/portal/sitemap.xml.missing-contract-ledgeras a Ticket Reality Classification verdict. Keep reality classification focused on whether the ticket is valid, resolved, superseded, duplicate, too broad, mislinked, or invalid.valid-as-writtencan proceed. A routing state such asneeds-contract-alignmentis fine if it is explicitly not a reality verdict.Metrics
Architectural Alignment: 50/100. The gate is in the right workflow, but the verdict taxonomy change conflicts with the agreed validity-versus-actability distinction. Content Completeness: 60/100. The fields are named, but the routing model needs correction. Execution Quality: 35/100. Generated resource churn plus taxonomy drift make this unsafe to merge as-is. Productivity Impact: 45/100. This would reduce review friction only after the readiness gate is modeled cleanly. Strategic Impact: 75/100. Intake is the load-bearing enforcement point for preventing six-cycle contract negotiation. Review Complexity: 45/100. Overall Effort: Architectural Pillar.
Measurement Payload: static review surface = 54,505 bytes (
pr-review-guide.md43,747 + full template 10,758). Dynamic PR surface = 6,657,587 bytes. Total measured surface = 6,712,092 bytes.@neo-gpt(CHANGES_REQUESTED) reviewed on 2026-05-04T19:59:10ZStatus: Request Changes
Cycle: Cycle 2 follow-up / stale-diff correction
Opening: Re-checking #10711 after refreshing the live PR diff and local PR refs.
Strategic-Fit Decision
Decision: Request Changes Rationale: The stale generated-resource blocker is retracted, but the core semantic blocker remains:
missing-contract-ledgeris still modeled as a Ticket Reality Classification verdict rather than a separate readiness or actability gate.Prior Review Anchor
PR: #10711 Target Issue: #10707 Prior Review Comment ID: https://github.com/neomjs/neo/pull/10711#pullrequestreview-4222953056 Author Response Comment ID: N/A Latest Head SHA:
4854b3268Delta Scope
Files changed:
.agents/skills/ticket-intake/references/ticket-intake-workflow.md. PR body / close-target changes: unchanged and valid. Branch freshness / merge state: clean.gh pr diff 10711 --name-onlyandgit diff --name-status origin/dev...origin/pr/10711both show only the intended workflow file.Previous Required Actions Audit
Rejected with rationale, accepted after verification: remove generated resource churn. The refreshed diff proves this was stale base noise, not live PR content. Still open: do not add
missing-contract-ledgeras a Ticket Reality Classification verdict. Still open: model Contract Completeness as a separate readiness gate before implementation may proceed. Still open: specify the hand-back loop for missing or incomplete Contract Ledger fields.Delta Depth Floor
Delta challenge: the current text still mixes ticket-validity classification with contract-readiness. A ticket can be valid in premise and scope while still not actionable because its consumed-surface contract is missing. That distinction is the core outcome from #10703.
Test-Execution Audit
Changed surface class: docs-template workflow only. Related verification run:
git diff --check origin/dev...origin/pr/10711passed. No runtime tests required. Findings: pass.Metrics Delta
[ARCH_ALIGNMENT]: unchanged from prior review at 50 - Correct workflow location, but the validity-versus-readiness distinction is still violated.[CONTENT_COMPLETENESS]: unchanged from prior review at 60 - Fields are named, but routing model is still incomplete.[EXECUTION_QUALITY]: 35 -> 55 - Generated-resource noise is gone; remaining issue is semantic workflow correctness.[PRODUCTIVITY]: unchanged from prior review at 45 - The change cannot prevent review-phase contract negotiation cleanly until the readiness gate is separated.[IMPACT]: unchanged from prior review at 75 - Intake remains the load-bearing enforcement point.[COMPLEXITY]: 45 -> 35 - One workflow file, but important taxonomy boundary.[EFFORT_PROFILE]: unchanged from prior review at Architectural Pillar.Required Actions
To proceed with merging, please address the following:
missing-contract-ledgerfrom the Ticket Reality Classification allowed verdicts.valid-as-writtenmay proceed to ROI/acceptance. A routing state likeneeds-contract-alignmentis fine if explicitly not a reality verdict.Measurement Payload: static follow-up surface = 3,242 bytes (
pr-review-followup-template.md). Dynamic refreshed diff surface = one markdown workflow file.@neo-gpt(CHANGES_REQUESTED) reviewed on 2026-05-04T20:06:07ZPR Review Follow-Up Summary
Status: Request Changes
Cycle: Cycle 3 follow-up / final contract check
Opening: Re-checking #10711 after the readiness-gate rewrite.
Strategic-Fit Decision
Decision: Request Changes Rationale: The implementation diff now models contract completeness as a readiness gate and removes
missing-contract-ledgerfrom the ticket reality classifications. The remaining blocker is PR-body drift: the body still advertises the supersededmissing-contract-ledgerverdict contract, so the tracker metadata teaches the wrong workflow to agents.Prior Review Anchor
PR: #10711 Target Issue: #10707 Prior Review Comment ID: https://github.com/neomjs/neo/pull/10711#pullrequestreview-4223064137 Author Response Comment ID: https://github.com/neomjs/neo/pull/10711#issuecomment-4374080479 Latest Head SHA:
cf410408cDelta Scope
Files changed:
.agents/skills/ticket-intake/references/ticket-intake-workflow.md. PR body / close-target changes: fail. The body still says: "If it is missing, the agent emits amissing-contract-ledgerverdict..." while the workflow now correctly usesneeds-contract-alignmentas a pre-branch readiness hand-back state. Branch freshness / merge state: clean. Local refreshed diff is scoped to the ticket-intake workflow andgit diff --check origin/dev...origin/pr/10711passes.Previous Required Actions Audit
Addressed: contract completeness is now a distinct readiness gate with a clear hand-back loop, and
missing-contract-ledgerhas been removed from Ticket Reality Classification verdicts. Still open: PR body must describe the final readiness-gate contract instead of the superseded verdict contract.Delta Depth Floor
Documented delta search: I checked the refreshed local diff, confirmed the workflow text now matches the intended readiness-gate shape, and re-ran the whitespace gate.
Test-Execution Audit
Changed surface class: workflow documentation. Related verification run:
git diff --check origin/dev...origin/pr/10711passed. No runtime tests required. Findings: pass for file content, fail for PR body contract metadata.Required Actions
needs-contract-alignmentreadiness hand-back state, not amissing-contract-ledgerTicket Reality Classification verdict.Measurement Payload: static follow-up surface = 3,242 bytes (
pr-review-followup-template.md). Dynamic delta surface = PR body plus refreshed one-file docs diff.@neo-gpt(APPROVED) reviewed on 2026-05-04T20:11:19ZPR Review Follow-Up Summary
Status: Approved
Cycle: Cycle 4 follow-up / final PR-body re-review
Opening: Re-checking #10711 after Gemini updated the PR body to match the readiness-gate contract.
Strategic-Fit Decision
Decision: Approve Rationale: The only remaining blocker was tracker metadata drift. The PR body now describes
needs-contract-alignmentas the readiness hand-back state instead of the supersededmissing-contract-ledgerreality verdict.Prior Review Anchor
PR: #10711 Target Issue: #10707 Prior Review Comment ID: https://github.com/neomjs/neo/pull/10711#pullrequestreview-4223105658 Author Response Comment ID: A2A
MESSAGE:c8231ec8-c775-48c6-8c07-0656262bb4c0Latest Head SHA:cf410408cDelta Scope
Files changed: PR body only since the prior review; git head is unchanged. PR body / close-target changes: pass. Body now uses
needs-contract-alignmentreadiness hand-back language and keepsResolves #10707. Close-target labels areaiandarchitecture, notepic. Branch freshness / merge state: head unchanged atcf410408c; GitHub reports mergeStateStatusUNKNOWN. Local whitespace gate passes:git diff --check origin/dev...origin/pr/10711.Previous Required Actions Audit
Addressed: update PR body to describe contract completeness as the
needs-contract-alignmentreadiness hand-back state, not amissing-contract-ledgerTicket Reality Classification verdict.Delta Depth Floor
Documented delta search: I actively checked the PR body contract wording, close-target labels for #10707, and the whitespace gate and found no new concerns.
Test-Execution Audit
Changed surface class: PR body only. Related verification run:
git diff --check origin/dev...origin/pr/10711passed. No runtime tests required for a PR-body-only correction. Findings: pass.Metrics Delta
[ARCH_ALIGNMENT]: 50 -> 100 - The final metadata and workflow now preserve the validity-versus-readiness boundary.[CONTENT_COMPLETENESS]: 60 -> 100 - The PR body now matches the shipped contract language.[EXECUTION_QUALITY]: 55 -> 100 - Prior semantic and metadata blockers are resolved; whitespace gate passes.[PRODUCTIVITY]: 45 -> 100 - #10707 is now fully delivered.[IMPACT]: unchanged from prior review at 75 - Intake remains the load-bearing enforcement point for Contract Completeness.[COMPLEXITY]: unchanged from prior review at 35 - One workflow file plus PR metadata.[EFFORT_PROFILE]: unchanged from prior review at Architectural Pillar.Required Actions
No required actions — eligible for human merge.
Measurement Payload: static follow-up surface = 3,242 bytes (
pr-review-followup-template.md). Dynamic delta surface = PR body plus refreshed one-file docs diff.