625 passed, 0 failed, 3 conditionally skipped

Resolves #11005

Authored by Claude Opus 4.7 (Claude Code 1M-context). Session c2912891-b459-4a03-b2af-154d5e264df1.

Systemic className sweep across the 4 M6-migrated server families (KB + GH-WF + NL + MC), aligning Neo.setupClass() className strings + JSDoc tags with the flat SDK boundary established by #10995 (#10991), #10997 (#10993), #10998 (#10994), and #11001 (#10996). Operator-flagged failure: physical migrations did not update className namespaces; M6 closeout depends on this sweep landing post-#11001.

Evidence: L1 (mechanical regex sweep + 625-spec unit-test verification across test/playwright/unit/ai/{services,mcp/server,daemons,scripts}/) → L1 required (no runtime contracts changed; pure namespace alignment). No residuals.

Diff Summary Table (AC13)

Per-class surface coverage

Each migrated class file carries the className in 5 surface types (3 mandatory + 2 conditional). Single regex prefix substitution covers all 5 since they share the same Neo.ai.mcp.server.<server>.{services,managers}. prefix:

1. Module-level @class JSDoc tag (mandatory)
2. @extends JSDoc tag (conditional — when subclassing another migrated class)
3. @see / @link JSDoc tag (conditional — when cross-referencing another migrated class)
4. Config @member {String} className='...' JSDoc tag (mandatory)
5. Config value className: '...', (mandatory)

The descriptive @summary + intent prose (semantic role description) is location-agnostic and untouched.

MUST-NOT-TOUCH (preserved by regex shape)

The substitution prefixes specifically target Neo.ai.mcp.server.<server>.{services,managers}. where <server> is one of {knowledge-base, github-workflow, neural-link, memory-core}. Naturally excludes:

• Neo.ai.mcp.server.shared.services.* — shared cross-cutting (RequestContextService, AuthMiddleware, AuthService, DestructiveOperationGuard, StdioIdentityResolver, TransportService) — stays at server level.
• Neo.ai.mcp.server.<server>.{Server,config,logger} — server-level files that didn't migrate.

Verified post-sweep: 0 stale Neo.ai.mcp.server.{kb,gh-wf,nl,mc}.{services,managers}.X refs remain in the active source/test/docs trees (excluding resources/content/{issue-archive,pulls,release-notes}/ historical archives which are auto-regenerated by the data-sync pipeline).

Manual fix beyond the regex

ai/daemons/DreamService.mjs:35 had a stale module-level @class Neo.ai.mcp.server.memory-core.services.DreamService. DreamService physically lives at ai/daemons/DreamService.mjs and its Neo.setupClass() config correctly declares className: 'Neo.ai.daemons.DreamService'. The JSDoc was the only stale reference. Excluded from the regex (would have mis-flattened to Neo.ai.services.memory-core.DreamService); fixed manually to match the actual config-declared className.

Substitution ordering nuance

Bare-per-server-prefix substitution naturally collapses nested subdirs since the prefix being replaced ENDS at .services.:

• Neo.ai.mcp.server.memory-core.services.lifecycle.X → Neo.ai.services.memory-core.lifecycle.X ✓
• Neo.ai.mcp.server.github-workflow.services.sync.X → Neo.ai.services.github-workflow.sync.X ✓
• Neo.ai.mcp.server.github-workflow.services.queries.X → Neo.ai.services.github-workflow.queries.X ✓ (no classNames in queries/, but consistent shape)

Special case: MC managers/ is a SIBLING of services/ at the OLD location, not nested under it. Required its own substitution prefix (.managers. → .managers.), run BEFORE the bare .services. prefix to avoid mismatch.

Test Evidence (AC5)

$ npm run test-unit -- test/playwright/unit/ai/services/ \
                       test/playwright/unit/ai/mcp/server/ \
                       test/playwright/unit/ai/daemons/ \
                       test/playwright/unit/ai/scripts/

The 3 conditional skips are environment-dependent (e.g., ChromaLifecycleService unified-mode bypass gated on chromaUnified=true config) and unaffected by the className sweep. Zero new failures introduced.

Cleanup commit

• bcc4f6cc4 — main sweep (this PR's body)
• 220ff9df8 — chore: untrack accidentally-committed sent-to-cull.jsonl runtime artifact (#11005). The unit-test run during sweep verification triggered MailboxService.mjs:259's persistence-error fallback path which writes sent-to-cull.jsonl next to the graph storage path. The file landed at repo root (where aiConfig.storagePaths.graph resolved during the test) and got accidentally staged. Removed from index + added explicit gitignore rule with provenance comment. Pure cleanup; not migration semantics.

ACs Closeout

• AC1 (revised per calibration delta #2): ~213 namespace-string occurrences updated across the 4 M6-migrated server directories, covering all 5 surface types.
• AC2 + AC3: subsumed by AC1's 5-surface coverage (@class + @member + className value + conditional @extends + conditional @see all swept by the same regex prefix).
• AC4: sub-namespace structure preserved (MC .lifecycle.X + .managers.X; GH-WF .sync.X + .queries.X retained as suffixes after the bare-prefix collapse).
• AC5: No runtime regressions: full unit run shows 625 passed / 0 failed / 3 conditional skips.
• AC6: Hardcoded old-namespace references in consumer source (ai/daemons/, ai/scripts/) audited and updated (LazyEdgeDrainer @see GraphService; seedAgentIdentities @link MailboxService).
• AC7: KB index re-build post-merge — npm run ai:build-kb or equivalent required to refresh ChromaDB embeddings against new className anchors.
• AC8: Test-spec assertion sweep — done in this PR; assertions on expect(X.className).toBe('Neo.ai.services.<server>.X') verified via the test.describe strings now matching the new namespace.
• AC9: Native Edge Graph re-ingestion — class-hierarchy queries verification post-merge.

Out of Scope

• Renaming SHORT class names (e.g., GraphService → SomethingElse) — preserved.
• Reshaping Memory_* / KB_* / GH_* / NeuralLink_* SDK aliases in ai/services.mjs — alias surface is stable consumer API.
• Neo.setupClass() semantics or class-registry behavior changes — pure data update.
• Fixing the underlying MailboxService.mjs:259 cull-log default-path bug (writes to repo root if aiConfig.storagePaths.graph resolves there) — out of #11005 scope. The gitignore patch is a workaround, not a fix; tracked separately if/when prioritized.

Cross-Family Review Routing

Per pull-request §6.2: GPT (OpenAI family) is currently busy on other items per @tobiu's coordination. Routing to @neo-gemini-pro as primary-reviewer for the cross-family chain integrity. Gemini explicitly yielded the implementation lane to me (A2A MESSAGE:ebd63e2c-cf44-43a9-929b-bb5e4ba0ffeb), so no co-authorship conflict on this PR's review side.

Post-Merge Validation

• M6 epic #10986 closeout: 4-of-4 sub-issues + this systemic follow-up. Eligible for epic-resolution skill invocation post-merge.
• KB index rebuild + verification (ask_knowledge_base(query='GraphService class') should return the new namespace as top result).
• Native Edge Graph class-hierarchy re-ingestion + verification.