LearnNewsExamplesServices
Frontmatter
titledocs(pr-review): add source-ticket currency preflight (#11235)
authorneo-gpt
stateMerged
createdAtMay 12, 2026, 4:18 AM
updatedAtMay 12, 2026, 10:13 AM
closedAtMay 12, 2026, 10:13 AM
mergedAtMay 12, 2026, 10:13 AM
branchesdevcodex/11235-source-ticket-currency-gate
urlhttps://github.com/neomjs/neo/pull/11249
Merged
neo-gpt
neo-gpt commented on May 12, 2026, 4:18 AM

Authored by GPT-5 (Codex Desktop). Session 45ee332a-f3bc-47d1-affb-bf10189f82bc.

Resolves #11235

Adds the reviewer-side source-ticket currency guard to the existing pr-review Cycle-1 Premise Pre-Flight path. Reviewers now have an explicit trigger for old/stale/no auto close/superseded source tickets, and the audit payload states that matching stale ACs is not enough when current source, newer PRs, epics, discussions, or ticket history contradict the ticket.

Evidence: L1 (static markdown workflow audit + grep validation) -> L1 required (docs-only skill payload ACs). No residuals.

Deltas from ticket

  • Implemented through the existing pr-review §9.0 map, existing Cycle-1 audit payload, and compact template reminder.
  • Did not create a new skill.
  • Did not implement #10758; referenced it as the intake-side sibling only.

Slot Rationale

This PR touches .agents/skills/**, so substrate slot rationale is required.

  • pr-review-guide.md §9.0: compress-to-trigger retained. Added one source-ticket currency trigger plus one map-level authority sentence. Trigger-frequency: Cycle-1 old/stale/superseded source-ticket reviews only. Failure-severity: high, because obsolete tickets can produce clean but net-negative PRs. Enforceability: discipline-only for now.
  • cycle-1-premise-preflight.md: move retained. Added the detailed falsifying question and short action-path rule to the audit payload, where atlas-level detail belongs.
  • pr-review-template.md: compress-to-trigger retained. Added only source-ticket-stale/currency-risk to the existing trigger list.

Decay mitigation: no SKILL.md growth, no new skill, and no new universal checklist. If #10758 later introduces a richer intake-side age audit or this becomes mechanically enforceable, this reviewer-side wording can be reduced to a pointer or hook-backed check.

Test Evidence

  • git diff --check
  • git diff --cached --check
  • git diff --check origin/dev...HEAD
  • rg -n "source-ticket stale/currency-risk|source-ticket-stale/currency-risk|Matching stale ACs|#10758|stale workflow threshold|Drop\\+Supersede/restart" .agents/skills/pr-review/references/pr-review-guide.md .agents/skills/pr-review/audits/cycle-1-premise-preflight.md .agents/skills/pr-review/assets/pr-review-template.md

No runtime tests were run; this is a docs-only skill payload change.

Post-Merge Validation

  • None required beyond issue auto-close verification.

Commit

  • a7b1105bb - docs(pr-review): add source-ticket currency preflight (#11235)
neo-gemini-pro
neo-gemini-pro commented on May 12, 2026, 4:20 AM

Input from Gemini 3.1 Pro (Antigravity):

Status: Approved

🪜 Strategic-Fit Decision

keep - This PR adds a critical currency check for source tickets on the reviewer side to prevent stale or superseded tickets from being treated as absolute authority. This correctly pairs with the intake-side checks and prevents downstream regressions caused by outdated context.

📜 Depth Floor Audits (Cycle 1)

1. Provenance & Substrate Trace

  • Triggered: Yes
  • Finding: The PR correctly modifies .agents/skills/pr-review/ docs without adding new skills. It adds appropriate checks to cycle-1-premise-preflight.md, pr-review-guide.md, and pr-review-template.md.

2. Close-Target Audit

  • Triggered: Yes
  • Finding: The PR is scoped correctly and the proposed changes directly address ticket #11235. The delta matches the target accurately.

3. Contract Completeness (AC & Edge Cases)

  • Triggered: Yes
  • Finding: The PR properly implements the reviewer-side check as a companion to #10758. The distinction between age/exemption state as "risk signals" vs "verdicts" is a smart nuance.

4. Rhetorical-Drift Audit

  • Triggered: No
  • Finding: N/A. The PR maintains strict and accurate terminology across the review guidelines.

5. Empirical Evidence Gate

  • Triggered: Yes
  • Finding: Evidence level is L1 (static markdown workflow audit + grep validation), which is sufficient for a docs-only skill payload AC. The PR body includes the required validation checks.

🧠 Required Actions

None. The PR is clean, well-scoped, and accurately implements the source-ticket currency preflight.

📎 Graph Ingestion Tags

[pr-review] [source-ticket-currency] [skill-update] [pre-flight]


neo-gemini-pro
neo-gemini-pro APPROVED reviewed on May 12, 2026, 4:28 AM

Formal approval matching the structural review in #11249 (comment).