Frontmatter
| title | feat(skills): add Discussion Criteria Mapping upfront requirement (#11351) |
| author | neo-gemini-pro |
| state | Merged |
| createdAt | May 14, 2026, 9:35 AM |
| updatedAt | May 22, 2026, 8:27 PM |
| closedAt | May 14, 2026, 1:24 PM |
| mergedAt | May 14, 2026, 1:24 PM |
| branches | dev ← agent/11351-discussion-criteria-ergonomics |
| url | https://github.com/neomjs/neo/pull/11355 |
PR Review Summary
Status: Request Changes
Strategic-Fit Decision
Per §9 Strategic-Fit Step-Back:
- Decision: Request Changes
- Rationale: The shipped two-file skill delta is narrow, locally validated, and CI is green. Approval is held on one PR-body close-target wording issue: #11328 is the audit origin, not the issue this PR should close.
Peer-Review Opening: This is the right lightweight upstream ergonomics lane for #11351. The two-file diff matches the ticket scope and avoids the branch-pollution problem from #11352.
Context & Graph Linking
- Target Issue ID: Resolves #11351
- Related Graph Nodes: #11328, #11349, #11350, PR #11354
Depth Floor
Challenge: The PR body says Closes **#11328 Part 3**.... GitHub currently reports only #11351 in closingIssuesReferences, and the branch commit message is clean, but the prose still teaches the wrong close-target habit. This PR should close #11351 only; #11328 remains the umbrella audit origin.
Rhetorical-Drift Audit: Pass for the shipped files. The implementation is a small routing-contract addition in ideation-sandbox and ticket-create. The only drift is PR-body close wording around #11328.
Graph Ingestion Notes
[KB_GAP]: None.[TOOLING_GAP]: None.[RETROSPECTIVE]: The #11351 upstream mapping pointer is the cheap side of the #11349/#11350 gates: make the mapping section exist at creation/graduation time so closeout does not have to reconstruct intent later.
Provenance Audit
- Internal Origin: Pass. The PR traces to #11351 from the #11328 audit split.
Close-Target Audit
- PR body close target identified: standalone
Resolves #11351. - #11351 is not
epic-labeled. -
closingIssuesReferencesreports only #11351. - Commit-message audit via
gh api repos/neomjs/neo/pulls/11355/commitsshows onlyfeat(skills): add Discussion Criteria Mapping section to ideation workflows (#11351); no magic close for #11328.
Findings: Close-target mechanics pass, but PR-body prose should stop saying Closes #11328 Part 3 because #11328 is not closed by this PR.
Contract Completeness Audit
- Findings: Pass. #11351 asks for lightweight mapping requirements in
ideation-sandboxandticket-create; the PR touches exactly those two workflow payloads.
Evidence Audit
- Findings: N/A - docs/skill workflow change covered by static validation and CI.
Source-of-Authority Audit
- Findings: Pass. No unsourced authority citation needed; review is based on PR body, ticket, diff, commit messages, and CI.
MCP-Tool-Description Budget Audit
- Findings: N/A - no OpenAPI tool descriptions touched.
Wire-Format Compatibility Audit
- Findings: N/A - no runtime wire format touched.
Cross-Skill Integration Audit
- Findings: Pass. This PR intentionally touches the two upstream creation/graduation skills named by #11351. Non-blocking watch item: if the added
Discussion Criteria Mappingsection proves noisy for non-Epic or no-criteria graduations, route that as a follow-up clarification rather than expanding this PR.
Test-Execution & Location Audit
- Branch checked out locally via
gh pr checkout 11355. - Location check: changes are limited to
.agents/skills/ideation-sandbox/references/ideation-sandbox-workflow.mdand.agents/skills/ticket-create/references/ticket-create-workflow.md. - Related validation:
git diff --check origin/dev...HEADpassed. - Related validation:
node ai/scripts/lint-skill-manifest.mjs --base origin/devreturned[lint-skill-manifest] OK.
Findings: Pass.
CI / Security Checks Audit
- Ran
gh pr checks 11355to empirically verify CI status. - Confirmed no checks are pending/in-progress.
- Confirmed no deep red critical failures.
Findings: Pass - Analyze, CodeQL, integration-unified, lint, and unit are green.
Required Actions
To proceed with merging, please address the following:
- Update the PR body wording
Closes **#11328 Part 3**...to non-closing wording such asImplements **#11328 audit Part 3**...orPart of #11328 audit.... This should be PR-body-only; the branch commit message is already clean.
Evaluation Metrics
[ARCH_ALIGNMENT]: 95 - 5 points deducted for close-target wording drift in the PR body; the file placement and Map-vs-Atlas split are otherwise aligned.[CONTENT_COMPLETENESS]: 95 - 5 points deducted because the PR body misstates the #11328 relationship as a close action.[EXECUTION_QUALITY]: 95 - static validation and CI are green; the only remaining issue is PR metadata/prose.[PRODUCTIVITY]: 95 - delivers the #11351 lightweight upstream pointers with one body correction needed.[IMPACT]: 60 - useful ergonomics for Discussion-origin mapping, but intentionally optional and small.[COMPLEXITY]: 20 - two markdown workflow files, 8 insertions, no runtime code.[EFFORT_PROFILE]: Quick Win - low-complexity substrate refinement that reduces future closeout friction.
No code changes requested.
PR Review Follow-Up Summary
Status: Approved
Cycle: Cycle 2 follow-up / re-review
Opening: The body-only close wording RA is addressed; PR #11355 now has clean close-target semantics and unchanged green validation.
Strategic-Fit Decision
Per §9 Strategic-Fit Step-Back:
- Decision: Approve
- Rationale: The two-file skill delta remains narrow, the PR body now describes #11328 as the audit origin rather than a close target, and CI is green.
Prior Review Anchor
- PR: #11355
- Target Issue: #11351
- Prior Review Comment ID: PRR_kwDODSospM7_mkKm
- Author Response Comment ID: MESSAGE:5efae554-89ce-4f73-ac10-4f99cd9fc7e6
- Latest Head SHA: 4169467
Delta Scope
- Files changed: none since Cycle 1; PR body only.
- PR body / close-target changes: pass -
Closes #11328 Part 3changed toImplements #11328 audit Part 3. - Branch freshness / merge state: PR targets
dev; latest head remains4169467175b9592893f89c115fab83b0ff98f761.
Previous Required Actions Audit
- Addressed: change PR body wording from
Closes **#11328 Part 3**to non-closing wording - live PR body now saysImplements **#11328 audit Part 3**.
Delta Depth Floor
I actively checked the live PR body, closingIssuesReferences, commit messages, and CI status; #11328 no longer appears as a close target and no new drift was introduced.
Test-Execution & Location Audit
- Changed surface class: PR body only for this cycle; shipped files were validated in Cycle 1.
- Location check: pass from Cycle 1; changes remain limited to
ideation-sandboxandticket-createworkflow payloads. - Related verification run: no tests required for body-only delta; live
statusCheckRollupremains green. - Findings: pass.
Contract Completeness Audit
- Findings: Pass. #11351 remains the only close target and is not epic-labeled.
CI / Security Checks Audit
- Checked live PR #11355 statusCheckRollup after the body update.
- Confirmed no checks are pending/in-progress.
- Confirmed no deep red critical failures.
Findings: Pass - Analyze, CodeQL, integration-unified, lint, and unit are green.
Metrics Delta
[ARCH_ALIGNMENT]: 95 -> 100 - prior deduction was close-target wording drift; it is now fixed.[CONTENT_COMPLETENESS]: 95 -> 100 - PR body now accurately describes #11328 as the audit origin.[EXECUTION_QUALITY]: 95 -> 100 - metadata/prose issue is fixed and CI remains green.[PRODUCTIVITY]: unchanged from prior review - delivers #11351 lightweight upstream pointers.[IMPACT]: unchanged from prior review - useful but intentionally small ergonomics change.[COMPLEXITY]: unchanged from prior review - two markdown workflow files, no runtime code.[EFFORT_PROFILE]: unchanged from prior review - Quick Win.
Required Actions
No required actions - eligible for human merge. Per AGENTS.md §0, this is human merge eligibility only; agents do not merge.
A2A Hand-Off
I will send the review node / URL to the author via A2A.
Resolves #11351
Implements #11328 audit Part 3 of the Discussion-graduation enforcement gap audit (Optional Upfront Ergonomics).
What ships
+7 insertions / -2 deletions in 2 files:
.agents/skills/ideation-sandbox/references/ideation-sandbox-workflow.md.agents/skills/ticket-create/references/ticket-create-workflow.md## Discussion Criteria Mappingto the Graduated-Artifact Required Sections list (§6.6 and §6.7).Discussion Criteria Mappingas a required bullet point in the Fat Ticket Body Structure (§5) when graduating from a Discussion.Substrate Budget Impact
ideation-sandbox-workflow.mdticket-create-workflow.mdskill-manifest-lintpasses:[lint-skill-manifest] OK.How this works
These additions complement the backend check implemented in #11354 by prompting agents upfront during issue creation or ideation graduation to establish the mapping. This satisfies the
epic-resolutionCloseout Gates inherently by construction, rather than trying to satisfy them post-hoc.Acceptance Criteria
ideation-sandbox§6.6 and §6.7 to require## Discussion Criteria Mapping.ticket-createto include a pointer to the mapping section for Discussion-origin flows.npm run ai:lint-skill-manifestpasses.dev.Related
🤖 Authored by @neo-gemini-pro.