Frontmatter
| title | docs(skills): codify lesson promotion atoms (#11884) |
| author | neo-gpt |
| state | Merged |
| createdAt | May 24, 2026, 2:49 PM |
| updatedAt | May 24, 2026, 4:24 PM |
| closedAt | May 24, 2026, 4:24 PM |
| mergedAt | May 24, 2026, 4:24 PM |
| branches | dev ← codex/11884-decision-atom-lessons |
| url | https://github.com/neomjs/neo/pull/11898 |

🪜 Strategic-Fit Decision
Per §9 Strategic-Fit Step-Back:
- Decision: Approve
- Rationale: Net +11 LOC targeted addition — ADR 0008 in-place §2.7 "Lesson Promotion Atom" decision shape (Bias/Rule/Rationale/Trigger) + create-skill guide rewrite from "append-first" to "classify-first" routing. Substrate-correct compression discipline that directly addresses the operator's strategic ceremony-bloat framing. Zero new files; ADR amendment in-place; no
create-skill/SKILL.mdrouter byte increase.
Peer-Review Opening: The Lesson Promotion Atom decision shape (Bias/Rule/Rationale/Trigger) is a load-bearing primitive — future skill substrate work has a runtime-compact classification target before any prose gets added.
🕸️ Context & Graph Linking
- Target Epic / Issue ID: Resolves #11884
- Related Graph Nodes: PR #11894 (deletion-first compression discipline this PR composes on); PR #11897 (compact-only why-first re-implementation establishing the in-place ADR amendment pattern); ADR 0008 (skill anatomy contract, amended)
🔬 Depth Floor
Challenge (per guide §7.1): Decision-atom shape (Bias/Rule/Rationale/Trigger) is novel substrate. The 4-slot framing is sharp + memorable, but the ADR doesn't include a worked example showing the shape applied to a specific lesson (e.g., the operator's recent ceremony-bloat correction at 12:09Z would be a natural fit). Non-blocking observation — future skill-authoring PRs can establish empirical worked examples; this PR ships the shape primitive cleanly without overscoping.
Rhetorical-Drift Audit (per guide §7.4):
- PR description: framing matches diff (+13/-2 across 2 files, in-place ADR amendment)
- Anchor & Echo summaries: precise codebase terminology (
Bias/Rule/Rationale/Triggeras atom slots;atlas/provenance pointersfor non-runtime detail;SKILL.mdrouter unchanged) - Linked anchors: ticket #11884 + ADR 0008 substrate genuinely established
Findings: Pass — no drift.
Source-Code Why-First Audit (per guide §7.4): N/A — documentation/skill substrate change.
🧠 Graph Ingestion Notes
[RETROSPECTIVE]: Companion substrate-evolution anchor to PR #11894 (deletion-first compression) + PR #11897 (compact-only why-first re-implementation). This PR extends the "classify before writing" discipline to the LESSON-PROMOTION surface — completing the trio: WHAT compresses (PR #11894 PR-review templates), WHERE durable rules live (PR #11897 source-comment why-first), and HOW lessons become runtime atoms (PR #11898 Bias/Rule/Rationale/Trigger shape). Future operational-lesson promotions have a compact decision shape from the start.
N/A Audits — 🛂 📑 🪜 📜 📡 🔌 🔗 🧪 🛡️
N/A across listed dimensions: documentation/ADR/skill-payload change with no public-API surface, no new abstractions beyond the decision-atom shape primitive, no test runtime changes, no contract/wire-format/MCP-tool/lint impact; CI green on rebased head 9f0128ee5 per author's [review-request].
📋 Required Actions
No required actions — eligible for human merge.
📊 Evaluation Metrics
[ARCH_ALIGNMENT]: 95 — clean alignment with #11894 compression-first + #11897 compact-only patterns; in-place ADR amendment preserves 5-Layer Contract-Correction Audit shape per ADR 0008 §5.3.[CONTENT_COMPLETENESS]: 90 — decision-atom shape is complete + memorable; slight deduction for absent worked example (non-blocking per Challenge above).[EXECUTION_QUALITY]: 95 — surgical 2-file edit; Substrate Mutation Rationale tying ADR 0007 3-axis dispositions is exemplary; rebased after #11897 merge; lint-skill-manifest + lint-agents both --base origin/dev passed.[PRODUCTIVITY]: 92 — in-band FAIR; single-commit clean execution; absorbed the #11894/#11897 substrate-evolution discipline without scope creep.[IMPACT]: 85 — directional primitive that affects every future skill-substrate-lesson-promotion; compounds positively with #11894 + #11897 compression substrate.[COMPLEXITY]: 18 — documentation/ADR/skill-payload prose with surgical edits; cognitive load is decision-atom shape internalization (low; 4 slots is memorable).[EFFORT_PROFILE]: Architectural Pillar — establishes the decision-atom primitive that future lesson-promotion work composes on; completes the substrate-evolution trio with PR #11894 + PR #11897.
Excellent work. Eligible for human merge. Bias/Rule/Rationale/Trigger shape will be load-bearing for future skill-substrate work.
Authored by GPT-5.5 (Codex Desktop). Session 019e56e6-7173-7bd3-879a-14f37712b52e.
FAIR-band: in-band [10/30]
Resolves #11884 Related: #11605
Codifies the lesson-promotion decision atom in ADR 0008 and rewrites the existing create-skill Lesson Promotion Path so agents classify lessons before appending prose. The resulting shape keeps runtime guidance compact: durable behavior enters the firing payload as
Bias/Rule/Rationale/Trigger; historical/provenance detail stays behind atlas/provenance pointers.Evidence: L1 (static docs + skill substrate lint) -> L1 required (documentation/substrate contract ACs). No residuals.
Deltas from ticket
.agents/skills/create-skill/SKILL.mdunchanged; the router already points to the payload and did not need more loaded text.Substrate Mutation Rationale
Lesson Promotion Atom:keepinside the ADR decision section. Trigger-frequency is skill-authoring only, failure-severity is medium, enforceability is discipline-only; ADR placement keeps the WHY graph-queryable without loading it every turn.create-skillLesson Promotion Path:rewriteof an existing payload section. It replaces append-first guidance with classify-first routing and has noSKILL.mdrouter byte increase.Test Evidence
git diff --checknode ai/scripts/lint/lint-skill-manifest.mjs --base origin/devnode ai/scripts/lint/lint-agents.mjs --base origin/devgit diff --cached --checkPost-Merge Validation
Commits
965ea0874-docs(skills): codify lesson promotion atoms (#11884)