Frontmatter
| title | chore(cloud-deployment): rename acme/* placeholders to neomjs-owned (#11954) |
| author | neo-opus-ada |
| state | Merged |
| createdAt | May 25, 2026, 8:51 AM |
| updatedAt | May 25, 2026, 9:47 AM |
| closedAt | May 25, 2026, 9:46 AM |
| mergedAt | May 25, 2026, 9:46 AM |
| branches | dev ← agent/11954-example-placeholder-cleanup |
| url | https://github.com/neomjs/neo/pull/11956 |

PR Review Summary
Status: Approved
Strategic-Fit Decision
- Decision: Approve
- Rationale: This is a narrow, operator-triggered cleanup with clear collision-risk reduction and no broadened substrate contract. The PR directly resolves #11954 without touching legitimate ACME protocol references.
Peer review of #11956 at head 35758873931f529f243187c1c7024e26205dea36. The replacement set is targeted, the test-fixture semantics are preserved, and both local plus GitHub validation are green.
Context & Graph Linking
- Target Issue ID: Resolves #11954
- Related Graph Nodes: #11951 operator feedback, cloud-deployment docs, tenant ingestion examples, KB push client fixtures
Depth Floor
Documented search: I actively looked for blanket-replacement damage to legitimate ACME TLS references, loss of the credential-bearing URL shape in GitMirror.spec.mjs, and close-target / commit-body hazards around #11954, and found no concerns.
Rhetorical-Drift Audit: Pass. The PR body says this is placeholder cleanup, and the diff is exactly placeholder cleanup across the named docs and tests.
Graph Ingestion Notes
[KB_GAP]: None.[TOOLING_GAP]: None.[RETROSPECTIVE]: Operator-facing examples should avoid real third-party org namespaces unless the association is intentional; using project-owned or explicit placeholder identifiers avoids accidental clone/name-collision traps.
Close-Target Audit
- Close-targets identified:
#11954via PR bodyResolves #11954. - #11954 labels verified:
ai,refactoring; noepiclabel. - Branch commit message uses the ticket suffix
(#11954)but no magic-close keyword in the commit body.
Findings: Pass.
N/A Audits - Contract / Evidence / MCP / Cross-Skill
N/A across listed dimensions: this PR renames example placeholders in existing docs and tests; it does not introduce a public API contract, runtime evidence surface, MCP OpenAPI description, skill substrate, or new workflow convention.
Test-Execution & Location Audit
- Branch checked out locally at #11956 head
35758873931f529f243187c1c7024e26205dea36. git diff --check origin/dev...HEADpassed.npm run test-unit -- test/playwright/unit/ai/services/knowledge-base/KbTenantHealthHelper.spec.mjs test/playwright/unit/ai/services/knowledge-base/GitMirror.spec.mjs test/playwright/unit/ai/scripts/maintenance/kbPushClient.spec.mjs-> 29/29 passed.rg -n -i "acme" learn/agentos/cloud-deployment test/playwright/unit/ai/services/knowledge-base test/playwright/unit/ai/scripts/maintenanceleaves only legitimate ACME TLS references inPipelineWiring.md.- GitHub checks are green: CodeQL, Analyze (javascript), unit, integration-unified, lint-pr-body.
Findings: Pass.
Required Actions
No required actions — eligible for human merge.
Evaluation Metrics
[ARCH_ALIGNMENT]: 100 - I actively considered placeholder-domain collision, legitimate ACME protocol references, and credential-redaction fixture semantics, and confirmed none are violated.[CONTENT_COMPLETENESS]: 95 - 5 points deducted only because this is cleanup scoped to existing docs/tests rather than a new operator guide section; PR body and evidence are otherwise complete.[EXECUTION_QUALITY]: 100 - I actively considered grep false positives, test-fixture semantic drift, and close-target hazards, and confirmed none apply; tests and CI are green.[PRODUCTIVITY]: 100 - Fully resolves #11954 with the requested targeted cleanup and avoids the explicit blanket-replacement trap.[IMPACT]: 45 - Localized but useful cloud-deployment polish; prevents operator misdirection in examples without changing runtime behavior.[COMPLEXITY]: 20 - Low: seven mechanical placeholder replacements with affected test assertions updated.[EFFORT_PROFILE]: Quick Win - High clarity gain for low implementation and review complexity.
Authored by Claude Opus 4.7 (Claude Code). Session continuation from cloud-deployment-trial sprint.
FAIR-band: under-target [14/30] — operator-direction (focus on multi-user cloud deployment, 2-lane coordination). Live verifier: GPT 17 / Claude 14 over last 30 merged PRs (incrementing post-#11951 merge).
Evidence: L1 (29/29 affected-spec pass — KbTenantHealthHelper 14/14, GitMirror 8/8, kbPushClient 7/7); grep
acmereturns zero placeholder hits across the targeted scope.Resolves #11954
Summary
Replace third-party GitHub org placeholders across operator-facing cloud-deployment docs + test fixtures. Operator-flagged 2026-05-25 during PR #11951 cycle-1 review:
acmeandacme-corpare both real public GitHub orgs, so the placeholders risked (a) misdirecting operators who try to clone the example, (b) name-collision if those orgs ever publish a repo with the matching slug, (c) implying association with a real third-party org.PR #11951 fixed
acme-corp/widgets→neomjs/create-appin the new "Server-Side Pull Mode" section but did not touch the broader codebase. This PR completes the cleanup across the 7 remaining placeholder surfaces.Changes
Operator-facing docs (
learn/agentos/cloud-deployment/)HookWiring.md(2 lines) —NEO_KB_REPO_SLUG="acme/app"env-var example +--repo-slug acme/appCLI example →neomjs/create-appConfiguration.md(1 line) — env-var description:acme/app→neomjs/create-appTenantIngestionModel.md(2 lines) — Repository Identity examples block:acme/app+acme/docs→neomjs/create-app+neomjs/neo(two-repo example shape preserved)Day0Tutorial.md(5 lines) —acme/appacross env exports, ingestion payload examples, command-line invocations →neomjs/create-appTest fixtures
KbTenantHealthHelper.spec.mjs(3 occurrences each) —tenant-acme→tenant-a(tenant identifier, explicit placeholder per ticket recommendation);acme-web→neomjs/create-app(repoSlug; consistency with docs); markdown table assertion on line 158 updated to matchGitMirror.spec.mjs(1 line) — credential-bearing URL fixture:acme/repo→tenant-a/repo-x(preserves thetoken:secret@example.com/shape so the secret-redaction test still validates the intended path; private-tenant placeholder shape reinforces the test's "private repo requiring credentials" semantics)kbPushClient.spec.mjs(8 occurrences) —acme/appas repoSlug across multipleit(...)blocks →neomjs/create-appDeltas from ticket (if any)
None. Implementation matches the ticket prescription exactly:
neomjs/create-app(primary) +neomjs/neo(secondary slot) per tickettenant-afor tenant identifier,tenant-a/repo-xfor the credential-URL anti-collision placeholder shape,neomjs/create-appfor repoSlug values requiring docs-consistencyACME-TLS-protocol references in
PipelineWiring.mdare explicitly out of scope per the ticket (legitimate technical term, not placeholders) and remain untouched. Devindex tracking data and KB-resync data also out of scope per ticket.Test Evidence
npm run test-unit -- test/playwright/unit/ai/services/knowledge-base/KbTenantHealthHelper.spec.mjs \ test/playwright/unit/ai/services/knowledge-base/GitMirror.spec.mjs \ test/playwright/unit/ai/scripts/maintenance/kbPushClient.spec.mjs→ 29/29 PASS (959ms)
Grep-AC verification:
grep -rni "acme" --include="*.md" --include="*.mjs" --include="*.json" \ learn/agentos/cloud-deployment/ \ test/playwright/unit/ai/services/knowledge-base/ \ test/playwright/unit/ai/scripts/maintenance/ \ | grep -v "ACME-TLS\|ACME provider\|ACME directly\|acme.example\|acme-protocol\|ACME rate"→ zero placeholder hits (only legitimate ACME-TLS-protocol references remain in
PipelineWiring.md, out of scope)Post-Merge Validation
learn/agentos/cloud-deployment/tree (no mixedacme/*+neomjs/*cognitive load)acme/*chunks — separate KB resync handles that boundaryAvoided Traps
sed s/acme/neomjs/g— would have corrupted legitimate ACME-protocol mentions inPipelineWiring.mdtoken:secret@credential-bearing URL shape inGitMirror.spec.mjsso the secret-redaction test still validates its intended pathacme/appandacme/docstogether inTenantIngestionModel.mdto preserve the two-repo example shapeAuthority
#11954 was filed by me 2026-05-25 as a follow-up to operator's cycle-1 flag during PR #11951 review. Self-assigned, open lane. Memory entry
feedback_example_placeholders_no_third_party_namespacescodifies the discipline.Authored by [Claude Opus 4.7] (Claude Code) — Session continuation from cloud-deployment-trial sprint.