Frontmatter
| title | chore(content): remove retired issue-archive/pr-archive references (#12177) |
| author | neo-opus-ada |
| state | Merged |
| createdAt | May 29, 2026, 10:17 PM |
| updatedAt | May 29, 2026, 10:24 PM |
| closedAt | May 29, 2026, 10:24 PM |
| mergedAt | May 29, 2026, 10:24 PM |
| branches | dev ← claude/silly-goldberg-5aa653 |
| url | https://github.com/neomjs/neo/pull/12181 |
Merged
github-actions
commented on May 29, 2026, 10:17 PM
🚨 Agent PR Body Lint Violation
@neo-opus-ada — your PR body on PR #12181 does not match the pull-request template structure.
Required action: read .agents/skills/pull-request/SKILL.md BEFORE editing the PR body. The skill points at:
- Minimum-viable PR body structure:
.agents/skills/pull-request/references/pull-request-workflow.md §9 - Self-Identification mandate:
.agents/skills/pull-request/references/pull-request-workflow.md §5
Do NOT compose a substitute template or hallucinate section headings. The validator checks more structural anchors than this comment names. The only reliable path to passing is reading the actual workflow file and following its structure.
Diagnostic hint: at least one recognized anchor like ## Post-Merge Validation is missing.
Visible anchors missing (full list)
## Post-Merge Validation
This is the CI tool-boundary lint companion to PR #11494's MCP manage_pr_review validator and PR #11502's agent-pr-review-body-lint.yml reviewer-side lint.
Resolves #11501.
Authored by Claude Opus 4.8 (Claude Code), operating as the @neo-opus-ada swarm identity. Session: worktree
claude/silly-goldberg-5aa653.FAIR-band: over-target [22/30] — operator-directed (tobiu directed the neo-first ADR-0004 Phase-2 cleanup); cross-family review effectively unavailable this window (gpt rate-limited reviews-only, gemini benched).
Resolves #12177
Removes the retired
issue-archive//pr-archive/references left behind after ADR 0004's clean-slate chunk-N migration. Those dirs no longer exist on disk, so the refs were dead: two duplicatedgeneratedSyncPathsdefensive lists (SyncService.mjs,check-chore-sync.mjs) carried entries that can never match, andpublish.mjscarried a stale comment claiming the migration is still "in transition." Cleaned all three, plus the matching legacy staged paths incheck-chore-sync.spec.mjs.Micro-change exemption (§6.1):
chore+ 17 lines changed + zero runtime impact (dead entries never matched; comment + test-only edits). Flagging so this need not consume @neo-gpt's rate-limited review capacity — merge remains @tobiu's call.Evidence: L2 (ran the 2 affected specs under the unit config — 16/16 pass; grep confirms no live
issue-archive/pr-archivecode refs remain) → L2 required (no runtime-only ACs). No residuals.Deltas from ticket
The ticket body overcounted; V-B-A refined the real scope:
LocalFileService.spec.mjs:105'sissue-archive/88xxpath is a deliberate negative-assertion fixture (test: "getIssueById does not probe retired legacy paths") and was left intact.check-chore-sync.mjsentries required a coordinatedcheck-chore-sync.spec.mjsupdate (dropped the 2 legacy staged paths) — not flagged in the ticket.generatedSyncPathsis duplicated verbatim acrossSyncService.mjs+check-chore-sync.mjs— a DRY smell worth a future dedup ticket.Test Evidence
UNIT_TEST_MODE=true playwright -c test/playwright/playwright.config.unit.mjs check-chore-sync.spec.mjs LocalFileService.spec.mjs→ 16 passed.LocalFileService.specinitially failed on a missing gitignoredconfig.mjs; hydrated viabootstrapWorktree.mjs(worktree-env, not a regression) → green.grep -rn "issue-archive|pr-archive" ai/ buildScripts/ src/(non-test) → CLEAN; only the intentionalLocalFileService.specnegative-fixture remains undertest/.check-whitespace+check-shorthandpre-commit hooks pass.Related
learn/agentos/decisions/0004-github-content-architecture.md§2.3, §2.6