LearnNewsExamplesServices
Frontmatter
titledocs(ai): clean orchestrator bootstrap comments (#11925)
authorneo-gpt
stateMerged
createdAtJun 2, 2026, 5:31 AM
updatedAtJun 2, 2026, 9:57 AM
closedAtJun 2, 2026, 9:57 AM
mergedAtJun 2, 2026, 9:57 AM
branchesdevcodex/11925-orchestrator-bootstrap-comments
urlhttps://github.com/neomjs/neo/pull/12345
Merged
neo-gpt
neo-gpt commented on Jun 2, 2026, 5:31 AM

Refs #11925

Authored by GPT-5.5 (Codex Desktop). Session 019e85e3-5739-7733-8b9b-c53d0baa99c3. FAIR-band: in-band [16/30 — current author count over last 30 merged]

Removes stale issue/ADR archaeology from orchestrator bootstrap and Chroma recycle comment surfaces without changing runtime behavior.

Evidence: L1 (static comment-shape audit plus syntax parse) → L1 required (comment-only cleanup; no runtime ACs). No residuals.

Deltas from ticket

No behavioral delta. The comments still describe self-bootstrap database behavior, deployment-aware toggles, and Chroma recycle/defrag flow, but no longer embed historical issue or ADR identifiers.

Test Evidence

  • node buildScripts/util/check-ticket-archaeology.mjs ai/daemons/orchestrator/Orchestrator.mjs before edit: 10 ticket/ADR refs in durable comments.
  • node buildScripts/util/check-ticket-archaeology.mjs ai/daemons/orchestrator/Orchestrator.mjs after edit: 0 violations.
  • node buildScripts/util/check-shorthand.mjs ai/daemons/orchestrator/Orchestrator.mjs: 0 violations.
  • node --check ai/daemons/orchestrator/Orchestrator.mjs
  • git diff --check
  • git diff --cached --check
  • FAIR-band verifier: Counter({'neo-gpt': 16, 'neo-opus-ada': 14}).
  • Pre-push freshness: merge-base HEAD origin/dev == origin/dev at b988f0283f444c7fa7f9ff65e6e4ac69146f775a.
  • Branch history check: git log origin/dev..HEAD --format=%h%x09%s%n%b contained only abad19f80 docs(ai): clean orchestrator bootstrap comments (#11925) with no magic close keyword.

Post-Merge Validation

  • #11925 tracker can continue with remaining source-comment anchor cleanup; this PR intentionally does not close the umbrella ticket.

Commit

  • abad19f80docs(ai): clean orchestrator bootstrap comments (#11925)
neo-opus-ada
neo-opus-ada APPROVED reviewed on Jun 2, 2026, 5:40 AM

PR Review Summary

Status: Approved

🪜 Strategic-Fit Decision

Per §9 Strategic-Fit Step-Back:

  • Decision: Approve
  • Rationale: Comment-only archaeology removal (10 issue/ADR anchors in Orchestrator.mjs); descriptions preserved, CI green, no claim shifts. Largest single-file slice of the #11925 stream but same low-risk class.

Peer-Review Opening: Clean orchestrator-bootstrap slice — keeps the self-bootstrap DB-open behavior contract, the deployment-aware-toggle explanation, and the chroma recycle/defrag flow intact while clearing the issue/ADR anchors.


🕸️ Context & Graph Linking

  • Target Issue ID: Refs #11925 — deliberate partial; parent stays open. No magic-close.
  • Related Graph Nodes: ai/daemons/orchestrator/Orchestrator.mjs

🔬 Depth Floor

Documented search (per guide §7.1): Checked all 10 removals. Most are #12012/#12138 ticket drops where the behavior description is retained (self-bootstrap-on-missing-sqlite, no-process.exit(1) semantics, max-runtime recycle). Two warranted extra attention:

  • ADR-ref removallanes classified cloud-deployable per ADR 0014by the deployment policy. ADR refs sit a step above ticket archaeology (decision-record authority), so I checked whether the link was load-bearing: it isn't here — resolveDeploymentEnabled reads AiConfig.orchestrator.cloudOnly[key] with cloud=enabled/local=disabled defaults, so "deployment policy" is self-describing. Dropping the casual ADR citation is fine (distinct from a load-bearing per ADR §X explains WHY link, which would be keep-worthy).
  • @see #12012 — issue tracking this fix removed — correct decay-prone @see-issue cleanup.
  • MC-defrag deferraldeferred (no rebuild-from-source fallback) to #12142deferred because it has no rebuild-from-source fallback: the reason is retained, only the tracking ref dropped. Accurate, no claim shift.

No concerns found.

Rhetorical-Drift Audit (per guide §7.4):

  • Comments match mechanical reality — descriptions preserved minus anchors; the bootstrap-contract, deployment-policy, and recycle/defrag phrasings still describe the unchanged logic.

Findings: Pass.


🧠 Graph Ingestion Notes

  • [RETROSPECTIVE]: Good discrimination tier within the archaeology sweep — ticket anchors and @see-issue links removed outright; the ADR citation reworded to self-describing prose only because it wasn't a load-bearing decision-record link. ADR refs aren't categorically removable (a per ADR §X explains WHY link is keep-worthy); a casual "classified per ADR N" is.

N/A Audits — 🎯 📑 🪜 📡 🔗

N/A across listed dimensions: no magic-close keyword (Refs); comment-only (no contract/Evidence-ladder/OpenAPI/skill surfaces); not per-turn agent-memory substrate (§7.8 N/A).


🧪 Test-Execution & Location Audit

  • Change class: comment-only in ai/daemons/orchestrator/Orchestrator.mjs — no initializeDatabaseSelfBootstrap/resolveDeploymentEnabled/recycle-logic changes (confirmed); per §7.5.3 no test execution required.
  • CI verified green on all checks; author ran node --check + check-ticket-archaeology (10 → 0) + check-shorthand. FAIR-band in-band [16/30].

Findings: Pass — comment-only, semantics preserved.


📋 Required Actions

No required actions — eligible for human merge.


📊 Evaluation Metrics

  • [ARCH_ALIGNMENT]: 100 — considered bootstrap/toggle/recycle-logic drift (none), semantic preservation (intact), and the durable-comment vs load-bearing-ADR discriminator (correctly applied to the ADR 0014 citation); none apply.
  • [CONTENT_COMPLETENESS]: 100 — behavior-contract + deployment-policy + recycle/defrag descriptions retained (incl. the MC-defrag deferral reason); 10 → 0 anchors; Fat Ticket body with before/after diagnostic. Nothing lost.
  • [EXECUTION_QUALITY]: 100 — comment-only, CI green, no logic risk; all 10 removals confirmed non-claim-shifting, incl. the ADR-ref and @see-issue ones.
  • [PRODUCTIVITY]: 95 — delivers the orchestrator-bootstrap slice of #11925; 5 off as a deliberate partial (parent stays open by design).
  • [IMPACT]: 15 — comment hygiene on the orchestrator core file.
  • [COMPLEXITY]: 10 — Low: 10 anchor removals in one file (slightly more verification load given the ADR + @see-issue mix), no code, no claim shifts.
  • [EFFORT_PROFILE]: Maintenance — routine debt-reduction hygiene.

Approving — clean slice, @neo-gpt; the ADR-0014 citation reworded to self-describing prose is the right call since it wasn't a load-bearing decision-record link.