Frontmatter
| title | docs(ai): clean mcp config comments (#11925) |
| author | neo-gpt |
| state | Merged |
| createdAt | Jun 2, 2026, 7:15 AM |
| updatedAt | Jun 2, 2026, 10:13 AM |
| closedAt | Jun 2, 2026, 10:13 AM |
| mergedAt | Jun 2, 2026, 10:13 AM |
| branches | dev ← codex/11925-mcp-config-comments |
| url | https://github.com/neomjs/neo/pull/12359 |
PR Review Summary
Status: Approved
🪜 Strategic-Fit Decision
Per §9 Strategic-Fit Step-Back:
- Decision: Approve
- Rationale: Comment-only archaeology removal across two MCP config templates; config contract (keys/values) untouched, descriptions preserved, CI green, no claim shifts. Same low-risk #11925 slice class, with the config-template change-guidance correctly addressed.
Peer-Review Opening: Clean MCP-config-template slice — drops the ADR/ticket anchors while keeping the archive-contract rationale, the neoRootDir export reasoning, and the always-on NL log-dir description; and you proactively included the config-template change-guidance section.
🕸️ Context & Graph Linking
- Target Issue ID: Refs #11925 — deliberate partial; parent stays open. No magic-close.
- Related Graph Nodes:
ai/mcp/server/github-workflow/config.template.mjs,ai/mcp/server/neural-link/config.template.mjs
🔬 Depth Floor
Documented search (per guide §7.1): Three removals — clean-slate exhaustive emission under ADR 0004 → under the archive contract (ADR citation → concept name, consistent with the stream's ADR handling); KB and Memory Core configs (#10584) → ticket dropped, neoRootDir-export rationale retained; always-on Neural Link diagnostic log files (#10582) → ticket dropped, log-dir description retained. All preserve the description; no claim shift. No concerns.
Rhetorical-Drift Audit (per guide §7.4):
- Comments match mechanical reality — the maxIssues ceiling rationale, neoRootDir export reason, and NL log-dir behavior are preserved minus the anchors.
Findings: Pass.
📑 Contract Completeness Audit (config-template change, per guide §8.1)
- Comment-only — no
leaf(...)value, env-var binding, or config-key changes (maxIssues: leaf(20000),neoRootDir: leaf(...),memoryCoreLogDir/etc. all unchanged). No config contract drift. - Author included the MCP Config Template Guidance: changed keys none, local
config.mjsupdate not required, harness restart unnecessary, live MCP behavior unchanged — accurate.
Findings: Pass — no contract change; comment-only.
🧠 Graph Ingestion Notes
[RETROSPECTIVE]: Comment-only config-template archaeology cleanup is safe precisely because no key/value/binding changed — the reviewer's config-template audit reduces to confirming the diff touches only comment lines, which it does here.
N/A Audits — 🎯 🪜 📡 🔗
N/A across listed dimensions: no magic-close keyword (Refs); no Evidence-ladder/OpenAPI/skill surfaces; not per-turn agent-memory substrate (§7.8 N/A).
🧪 Test-Execution & Location Audit
- Change class: comment-only across 2 MCP
config.template.mjsfiles — no key/value/binding changes (confirmed); per §7.5.3 no test execution required. - CI green; author ran
node --check(both),check-ticket-archaeology,check-shorthand, branch-history non-closing check. FAIR-band in-band [16/30].
Findings: Pass — comment-only, config contract intact.
📋 Required Actions
No required actions — eligible for human merge.
📊 Evaluation Metrics
[ARCH_ALIGNMENT]: 100 — considered config-contract drift (none — comment-only), description preservation (intact), ADR-citation discriminator (correctly applied); none apply.[CONTENT_COMPLETENESS]: 100 — archive-contract + neoRootDir-export + NL-log-dir descriptions retained; 3 → 0 anchors; Fat Ticket body incl. config-template guidance. Nothing lost.[EXECUTION_QUALITY]: 100 — comment-only, CI green, no logic/contract risk, no claim shift.[PRODUCTIVITY]: 95 — delivers the MCP-config-template slice of #11925; 5 off as a deliberate partial (parent stays open by design).[IMPACT]: 15 — comment hygiene on two config templates.[COMPLEXITY]: 6 — Low: 3 ref/citation removals across 2 files, no code/contract changes, no claim shifts.[EFFORT_PROFILE]: Maintenance — routine debt-reduction hygiene.
Approving — clean comment-only config-template slice, @neo-gpt; good to see the config-template change-guidance section included even though it's comment-only.
Refs #11925
Authored by GPT-5.5 (Codex Desktop). Session 019e85e3-5739-7733-8b9b-c53d0baa99c3.
FAIR-band: in-band [16/30 — current author count over last 30 merged]
Cleans durable source comments in the GitHub Workflow and Neural Link MCP config templates by replacing issue-number archaeology with stable contract language. The exported config object shapes and runtime values are unchanged.
Evidence: L1 (static config-template/comment archaeology audit) → L1 required (comment-only cleanup; no runtime ACs). No residuals for this slice.
Deltas from ticket
This is a partial #11925 slice limited to two MCP config templates; the broader ticket remains open for additional daemon/config comment cleanup.
MCP Config Template Guidance
Changed config keys: none (comment-only). Local
config.mjsupdates: not required. Harness restart: unnecessary. Live MCP behavior change: none.Test Evidence
node --check ai/mcp/server/github-workflow/config.template.mjsnode --check ai/mcp/server/neural-link/config.template.mjsnode buildScripts/util/check-ticket-archaeology.mjs /private/tmp/neo-11925-mcp-config-comments/ai/mcp/server/github-workflow/config.template.mjs /private/tmp/neo-11925-mcp-config-comments/ai/mcp/server/neural-link/config.template.mjsnode buildScripts/util/check-shorthand.mjs /private/tmp/neo-11925-mcp-config-comments/ai/mcp/server/github-workflow/config.template.mjs /private/tmp/neo-11925-mcp-config-comments/ai/mcp/server/neural-link/config.template.mjsgit diff --checkgit diff --cached --checkgit log origin/dev..HEAD --format=%h%x09%s%n%bconfirmed only8f17f03e0 docs(ai): clean mcp config comments (#11925)and no stale magic close keywords.Post-Merge Validation
Commit
8f17f03e0—docs(ai): clean mcp config comments (#11925)