Refs #11925
Authored by GPT-5.5 (Codex Desktop). Session 019e85e3-5739-7733-8b9b-c53d0baa99c3.
FAIR-band: in-band [16/30 — current author count over last 30 merged]
Consolidates the remaining #11925 tail after the fragmentation halt: folds the closed #12365 harness lifecycle cleanup into one PR and removes uncovered durable ticket-comment refs from the GitLab MCP scaffold and common MCP base server comments. No runtime logic, config defaults, env keys, file paths, or import behavior changed.
Evidence: L1 (static comment-archaeology, shorthand, and diff-hygiene checks on modified files) → L1 required (source-comment cleanup with no runtime AC). Residual: #11925 full closeout remains gated on the already-open fragment PRs landing.
Deltas from ticket
- Corrects PR granularity after the operator/peer halt: this is a consolidated tail PR, not another per-file singleton.
- Uses
Refs #11925 rather than Resolves #11925 because the issue's full cleanup set still includes already-open singleton PRs.
Test Evidence
node buildScripts/util/check-ticket-archaeology.mjs /private/tmp/neo-11925-consolidated-tail/ai/scripts/lifecycle/harnessLifecycle.mjs /private/tmp/neo-11925-consolidated-tail/ai/mcp/server/gitlab-workflow/toolService.mjs /private/tmp/neo-11925-consolidated-tail/ai/mcp/server/gitlab-workflow/Server.mjs /private/tmp/neo-11925-consolidated-tail/ai/mcp/server/BaseServer.mjs — passed; 4 files scanned, 0 violations.
node buildScripts/util/check-shorthand.mjs /private/tmp/neo-11925-consolidated-tail/ai/scripts/lifecycle/harnessLifecycle.mjs /private/tmp/neo-11925-consolidated-tail/ai/mcp/server/gitlab-workflow/toolService.mjs /private/tmp/neo-11925-consolidated-tail/ai/mcp/server/gitlab-workflow/Server.mjs /private/tmp/neo-11925-consolidated-tail/ai/mcp/server/BaseServer.mjs — passed; 4 files scanned, 0 violations.
git diff --check — passed.
git diff --cached --check — passed before commit.
git log origin/dev..HEAD --format='%h%x09%s%n%b' — verified no magic close keyword in branch history.
Post-Merge Validation
Commit
6c75fd9d6 — docs(ai): consolidate remaining comment cleanup (#11925)
Evolution
After the duplicate singleton anti-pattern was caught, #12365 was closed and this branch consolidated the known remaining tail instead of opening another per-file PR.
Refs #11925
Authored by GPT-5.5 (Codex Desktop). Session 019e85e3-5739-7733-8b9b-c53d0baa99c3. FAIR-band: in-band [16/30 — current author count over last 30 merged]
Consolidates the remaining #11925 tail after the fragmentation halt: folds the closed #12365 harness lifecycle cleanup into one PR and removes uncovered durable ticket-comment refs from the GitLab MCP scaffold and common MCP base server comments. No runtime logic, config defaults, env keys, file paths, or import behavior changed.
Evidence: L1 (static comment-archaeology, shorthand, and diff-hygiene checks on modified files) → L1 required (source-comment cleanup with no runtime AC). Residual: #11925 full closeout remains gated on the already-open fragment PRs landing.
Deltas from ticket
Refs #11925rather thanResolves #11925because the issue's full cleanup set still includes already-open singleton PRs.Test Evidence
node buildScripts/util/check-ticket-archaeology.mjs /private/tmp/neo-11925-consolidated-tail/ai/scripts/lifecycle/harnessLifecycle.mjs /private/tmp/neo-11925-consolidated-tail/ai/mcp/server/gitlab-workflow/toolService.mjs /private/tmp/neo-11925-consolidated-tail/ai/mcp/server/gitlab-workflow/Server.mjs /private/tmp/neo-11925-consolidated-tail/ai/mcp/server/BaseServer.mjs— passed; 4 files scanned, 0 violations.node buildScripts/util/check-shorthand.mjs /private/tmp/neo-11925-consolidated-tail/ai/scripts/lifecycle/harnessLifecycle.mjs /private/tmp/neo-11925-consolidated-tail/ai/mcp/server/gitlab-workflow/toolService.mjs /private/tmp/neo-11925-consolidated-tail/ai/mcp/server/gitlab-workflow/Server.mjs /private/tmp/neo-11925-consolidated-tail/ai/mcp/server/BaseServer.mjs— passed; 4 files scanned, 0 violations.git diff --check— passed.git diff --cached --check— passed before commit.git log origin/dev..HEAD --format='%h%x09%s%n%b'— verified no magic close keyword in branch history.Post-Merge Validation
Commit
6c75fd9d6—docs(ai): consolidate remaining comment cleanup (#11925)Evolution
After the duplicate singleton anti-pattern was caught, #12365 was closed and this branch consolidated the known remaining tail instead of opening another per-file PR.