LearnNewsExamplesServices
Frontmatter
titlerefactor(ai): read AiConfig graph leaf directly (#12464)
authorneo-gpt
stateClosed
createdAtJun 4, 2026, 3:36 AM
updatedAtJun 4, 2026, 3:46 AM
closedAtJun 4, 2026, 3:46 AM
mergedAt
branchesdevcodex/12464-aiconfig-analyze-nl-telemetry
urlhttps://github.com/neomjs/neo/pull/12468
Closed
neo-gpt
neo-gpt commented on Jun 4, 2026, 3:36 AM

Resolves #12464 Related: #12456 Related: #12438

Authored by GPT-5 (Codex Desktop). Session 032b788b-aac0-40ae-9a48-f595ffb3e4e8. FAIR-band: over-target [20/30] — taking this lane despite over-target because the operator restored GPT capacity, both Claude lanes were active or winding down, and #12464 is a narrow unassigned micro-split that avoids collision with #12435/#12451/#12461/#12462.

Drops the redundant process.env.NEO_MEMORY_DB_PATH || fallback in ai/scripts/diagnostics/analyzeNlTelemetry.mjs. The script already imports the Memory Core AiConfig provider, and storagePaths.graph already binds NEO_MEMORY_DB_PATH through the leaf declaration, so the direct leaf read keeps behavior equivalent while aligning with ADR 0019.

Evidence: L1 (static source/syntax check) → L1 required (behavior-equivalent direct AiConfig leaf read; no runtime-only ACs). No residuals.

Deltas from ticket

None — implements the ticket prescription exactly.

Decision Record impact

aligned-with ADR 0019.

Test Evidence

  • node --check ai/scripts/diagnostics/analyzeNlTelemetry.mjs
  • git diff --check
  • rg -n "process\.env\.NEO_MEMORY_DB_PATH \|\| aiConfig\.storagePaths\.graph|const DB_PATH = aiConfig\.storagePaths\.graph" ai/scripts/diagnostics/analyzeNlTelemetry.mjs returned only the direct leaf read.
  • Commit hook ran check-whitespace, check-shorthand, and check-ticket-archaeology successfully.

Post-Merge Validation

None required; the close-target ACs are satisfied by the static source change plus syntax validation.

neo-gpt
neo-gpt commented on Jun 4, 2026, 3:45 AM

Input from GPT-5 (Codex Desktop):

● [REJECTED_WITH_RATIONALE]

Withdrawing this PR. The operator rejected the lane, and the rejection is valid: this was a V-B-A failure by the author. I accepted #12464 as a micro-ticket and opened a 1-line PR that spent the full CI matrix, instead of rejecting the ticket as flawed/under-scoped after accounting for the graph history, related Discussions, and adjacent open tickets.

Do not review or merge #12468. Closing the PR and routing #12464 to not-planned/needs-re-triage.