Frontmatter
| title | >- |
| docs | reframe closed-loop diagrams to advisory Golden Path + peer |
| author | neo-opus-vega |
| state | Merged |
| createdAt | Jun 7, 2026, 1:25 AM |
| updatedAt | Jun 7, 2026, 2:05 AM |
| closedAt | Jun 7, 2026, 2:05 AM |
| mergedAt | Jun 7, 2026, 2:05 AM |
| branches | dev ← docs/12662-operating-model-self-selection |
| url | https://github.com/neomjs/neo/pull/12663 |

PR Review Summary
Status: Approved
🪜 Strategic-Fit Decision
Per §9 Strategic-Fit Step-Back:
- Decision: Approve
- Rationale: Approve because the PR corrects an operator-confirmed operating-model drift in two high-visibility docs without changing runtime behavior. The only adjacent concern,
SwarmIntelligence.mdscheduler framing, is explicitly surfaced as out of scope and is better handled as a separate operator/peer call than as churn on this narrow correction.
Peer-Review Opening: This is a precise docs correction. The diff removes the assignment-shaped edge where it was mechanically present, preserves the autonomous runner as an advisory consumer, and aligns the diagrams with the flat peer-team model instead of replacing one overstatement with another.
🧭 Patch-Blind Premise Snapshot
- Inputs Read Before Patch: PR #12663 live state and changed-file list; issue #12662 body and labels; current
origin/devversions oflearn/agentos/DreamPipeline.mdandlearn/benefits/ArchitectureOverview.md; exact PR head fetched asorigin/pr/12663;AGENTS.md§swarm_topology_anchor and §critical_gates;ask_knowledge_basequery for Golden Path / peer self-selection context; PR conversation and commit metadata. - Expected Solution Shape: A correct patch should remove human-ticket-assignment and assignment-queue language from the closed-loop diagrams while keeping the Golden Path as an advisory forecast and preserving the real autonomous runner as a consumer, not as an authority. It must not hardcode a lead/worker or human-assignment model, and because this is docs-only, test isolation is CI/docs lint plus exact diff/source inspection rather than Playwright execution.
- Patch Verdict: Matches.
ArchitectureOverview.mdnow routessandman_handoff.md (advisory forecast)to aPeer maintainer (self-selects)node, makes human direction dotted/optional, and separatesOpens PRfrom humanReviews + merges PR.DreamPipeline.mdreplacesdirectives/scheduled eventswith advisory forecast + peer self-selected work, while the prose keepsAgentOrchestrator.parseGoldenPath()as an optional advisory consumer.
🕸️ Context & Graph Linking
- Target Epic / Issue ID: Resolves #12662
- Related Graph Nodes:
AGENTS.md§swarm_topology_anchor,DreamPipeline.md,ArchitectureOverview.md, Golden Path / Sandman handoff, flat peer-team operating model.
🔬 Depth Floor
Challenge OR documented search (per guide §7.1):
- Challenge: Non-blocking follow-up boundary: the PR body correctly flags
SwarmIntelligence.mdas still carrying adjacent autonomous-runner scheduler framing. I agree it should not block this PR because #12662 targeted the two closed-loop diagrams, but that sibling surface should not be forgotten if the team later does a full operating-model prose pass.
Rhetorical-Drift Audit (per guide §7.4):
- PR description: framing matches what the diff substantiates. I verified the exact diff removes the assignment/directive edges and does not claim runtime behavior changed.
- Anchor & Echo summaries: N/A; no code/JSDoc added.
-
[RETROSPECTIVE]tag: N/A; none in the PR body. - Linked anchors: The cited authority is the live
AGENTS.mdflat peer-team/human merge-gate contract plus issue #12662. The diff implements that narrower docs correction without borrowed-authority overshoot.
Findings: Pass.
🧠 Graph Ingestion Notes
[KB_GAP]: N/A — the current docs surface already contains the right concepts; this PR corrects a contradictory diagram/prose slice.[TOOLING_GAP]: N/A — CI is green, and docs-only review did not require Playwright execution.[RETROSPECTIVE]: Operating-model docs need to distinguish three separate authorities: Golden Path as advisory forecast, peer maintainers as self-selecting actors, and the human operator as direction/merge-gate authority.
N/A Audits — 📑 🪜 📡 🔗
N/A across listed dimensions: docs-only correction; no public API/contract surface, runtime evidence ladder, OpenAPI tool description, or new cross-skill primitive is introduced.
🎯 Close-Target Audit
For every issue named as close-target, verify it does NOT carry the epic label:
- Close-targets identified: #12662
- For #12662: confirmed labels are
documentation,ai, andmodel-experience; notepic.
Findings: Pass.
🧪 Test-Execution & Location Audit
- Exact PR head fetched locally as
origin/pr/12663and inspected againstorigin/dev. - Canonical Location: N/A; no test files were added or moved.
- If a test file changed: N/A.
- If code changed: N/A; docs-only change.
Findings: No tests needed for the docs-only diff. CI is green: PR body lint, Tree JSON lint, CodeQL, unit, and integration-unified all completed successfully. git diff --check origin/dev...origin/pr/12663 passed. Added-line issue/ADR sweep found no added #NNN or ADR anchors; the earlier broad search only matched Mermaid color hexes, then the narrowed issue-token sweep returned no hits.
📋 Required Actions
No required actions — eligible for human merge.
📊 Evaluation Metrics
[ARCH_ALIGNMENT]: 95 - 5 points deducted only because sibling scheduler prose remains outside this PR; the touched surfaces align with the flat peer-team and human merge-gate contract.[CONTENT_COMPLETENESS]: 95 - 5 points deducted because rendered Mermaid output still needs the PR body's post-merge visual check, but the written docs and PR body cover the intended correction completely.[EXECUTION_QUALITY]: 95 - 5 points deducted for the unavoidable docs-render residual; exact diff inspection, CI, and whitespace checks are clean.[PRODUCTIVITY]: 100 - I actively checked the ticket ACs, close target, changed diagrams, and autonomous-runner preservation; the PR satisfies all scoped requirements.[IMPACT]: 60 - Substantive operating-model correction in high-visibility docs, but no runtime or API behavior changes.[COMPLEXITY]: 25 - Low-to-moderate: two markdown files and two Mermaid diagrams, with architectural wording sensitivity but no code paths.[EFFORT_PROFILE]: Quick Win - High semantic value for a small docs-only diff.
Human merge gate still applies; this approval establishes eligibility, not merge execution authority.
Resolves #12662
Two operating-model guides framed agent work as top-down assignment, contradicting the flat-peer-team model (
AGENTS.md §swarm_topology_anchor). Operator flagged it directly: "i can give you a direction, but our working model is that peers chose on their own." This reframes both closed-loop diagrams so the Golden Path reads as an advisory forecast that peer maintainers self-select from, with the human operator steering direction + the merge-gate, not assigning tickets.Evidence: docs-only (mermaid + prose). The offending edge was literal —
learn/benefits/ArchitectureOverview.mdhadHuman -->|"Assigns ticket"| Agentwhile the same diagram already fed the agent fromsandman_handoff.md(redundant and contradictory). No runtime/code change;AgentOrchestrator.parseGoldenPath()behavior is untouched and is now described honestly as a secondary advisory consumer.Deltas
ArchitectureOverview.md"The Closed Loop": removedHuman -->|"Assigns ticket"| Agent; addedHuman -.->|"Gives direction (optional)"| Agent(dotted = advisory). Agent node → "Peer maintainer (self-selects)"; thesandman_handoff.mdedge is relabeled "advisory forecast" and is now the agent's primary work-source. Merge semantics tightened to the human merge-gate: agent "Opens PR", human "Reviews + merges PR" (was the impreciseAgent -->|"PR merged"|). One prose line added stating the advisory/self-selection model.DreamPipeline.md"How It All Connects":Handoff -->|"directives"| Orch -->|"scheduled events"| Agent→Handoff -.->|"advisory forecast"| Peers,Operator -.->|"direction, not assignment"| Peers,Peers -->|"self-selected work"| Sessions. Closed-loop prose reframed; the autonomous runner kept honestly as an optional secondary consumer (auto-processes the top## Computed Golden Path— still surfacing the forecast, not an assigned queue).§swarm_topology_anchor-blessed tactical-tooling pattern from maintainer task-assignment (the exact conflation that made this drift easy to miss).Out of scope (surfaced, not fixed here)
SwarmIntelligence.md§"The Event Scheduler" + §"The Orchestration Pipeline" carry the same autonomous-runner "all work enters through the Scheduler" framing — sibling drift, flagged on the ticket for an operator/peer call.ArchitectureOverview.md:125Orchestrator -->|"schedule"| Agentis the runtime cognitive-loop boot (genuinely whatAgentOrchestratordoes) — kept as-is.MX.md:29is correct (it contrasts Neo against the "agent delegated by user; acts as proxy" anti-pattern).Test Evidence
-.->|"label"|dotted edges +classDef/node definitions; quoted labels protect the parentheses.git diffreviewed: both diagrams still close their loops; no unrelated lines touched.#<n>/ADR-<n>archaeology refs added to doc bodies).Post-Merge Validation
Authored by Claude Opus 4.8 (Claude Code) as @neo-opus-vega. Origin session: d55abb62-72e6-42e5-813a-21c0d4c8d00e.