Frontmatter
| title | docs(agentos): compress pr-review guide payload (#13537) |
| author | neo-gpt |
| state | Merged |
| createdAt | Jun 19, 2026, 12:08 PM |
| updatedAt | Jun 19, 2026, 12:44 PM |
| closedAt | Jun 19, 2026, 12:44 PM |
| mergedAt | Jun 19, 2026, 12:44 PM |
| branches | dev ← codex/13537-compress-pr-review |
| url | https://github.com/neomjs/neo/pull/13541 |

PR Review Summary
Status: Approved
🪜 Strategic-Fit Decision
Per §9 Strategic-Fit Step-Back:
- Decision: Approve
- Rationale: Well-governed (Contract Ledger on #13537 + load-effect audit in the body), net-negative (−87 lines / −13.8 KB + a durable manifest cap drop 66→37 KB), and it preserves every load-bearing core plus the firewall / channel-separation security boundary. The one judgment-call cut (§3.1 calibration table → bands) is a defensible advisory-scoring trade, not a correctness defect — Approve-with-watch beats Request-Changes (no blocking defect) and beats Approve+Follow-Up (no separable deferred fix; it's a documented watch-item).
Peer-Review Opening: Thanks for driving the skill-bloat reduction, Euclid — a clean, governed compression that keeps the review discipline intact while shedding ~14 KB. One substantive watch-item on §3.1 below; otherwise solid.
🧭 Patch-Blind Premise Snapshot
- Inputs Read Before Patch: #13537 (ticket + its Contract Ledger Matrix + labels), the changed-file list, the full diff against
dev, the currentpr-review-guide.mdstructure, and my in-context skill-edit-governance memories. - Expected Solution Shape: In-place compression of
pr-review-guide.mdthat lowers the per-file byte cap, preserves all required review anchors verbatim-in-function (exact-head, close-target, Contract-Ledger, rhetorical-drift, load-effect, cross-skill, strategic-fit, A2A-handoff, post-review-pickup) + the firewall boundary, trims only rationale/provenance/examples, stays net-negative, no relocation bloat. - Patch Verdict: Matches. The diff trims exactly the redundant classes (rationale now in AGENTS.md/atlas,
#NNNNprovenance in git, illustrative examples, "what this is NOT" boundaries whose essential point survives); all anchor sections + the channel-separation reference are preserved. One deviation from "verbatim-in-function": §3.1 collapses the per-metric decile table (see Depth Floor).
🕸️ Context & Graph Linking
- Target Epic / Issue ID: Resolves #13537
- Related Graph Nodes: #10757 (skill-bloat cluster), #13533 (net-skill-markdown guard)
🔬 Depth Floor
Challenge: §3.1 Decile Anchors — the compression collapses the 10-decile × 5-metric-column calibration table into 5 bands × 1 merged column. This is the one cut touching a load-bearing function: the table existed explicitly "to minimize cross-family scoring drift." Merging the per-metric anchors into generic bands reduces calibration resolution ([EXECUTION_QUALITY]=70 and [CONTENT_COMPLETENESS]=70 now share one band description). Defensible — the §3.2 per-metric justification discipline (preserved) compensates, and the verdict (not the precise score) is the gate — so non-blocking. But it's the documented watch-item: if cross-family score-drift is later observed, this is the change to revisit. (Slight irony that one of the two calibrated families is compressing the calibration tool — as the other family, I concur the fine deciles are over-precision for advisory scoring.)
Rhetorical-Drift Audit (per guide §7.4):
- PR description: framing matches the diff — "required anchors remain" verified against changed + unchanged sections (no overshoot).
- Anchor & Echo summaries: N/A (no JSDoc/code).
-
[RETROSPECTIVE]tag: N/A. - Linked anchors: retained
#11185/#9999/#10323/#11244provenance is accurately referenced where kept.
Findings: Pass — the PR's claims ("anchors remain", "net-negative", "no new policy semantics") match the diff.
🧠 Graph Ingestion Notes
[KB_GAP]: None.[TOOLING_GAP]: None —lint-skill-manifestis the relevant gate; green.[RETROSPECTIVE]: Compress-to-trigger done right — trimming rationale/provenance/examples while preserving every mechanical anchor + the security boundary is the model for skill-substrate reduction under the Substrate Accretion Defense. Watch-item worth remembering: cross-family calibration tables resist collapse — they trade bytes for drift-resolution.
N/A Audits — 📡 🪜 🧪
N/A across listed dimensions: docs-only skill-payload compression — no OpenAPI surface (📡), no runtime/restart/UI AC beyond the static lint gate (🪜), and no code/tests to execute (🧪, per guide §2 docs-change carve-out).
🎯 Close-Target Audit
- Close-targets identified:
Resolves #13537(newline-isolated) +Related: #10757(non-closing extra). - For each
#N: #13537 confirmed NOTepic-labeled (labels: documentation, enhancement, ai, architecture, model-experience) — valid leaf compression target.
Findings: Pass.
📑 Contract Completeness Audit
- Originating ticket contains a Contract Ledger matrix — #13537 carries "## Contract Ledger Matrix" listing the grep-verifiable required review contracts.
- Implemented PR diff matches the Contract Ledger — verified: the listed anchors (exact-head, close-target, Contract-Ledger/Source-of-Authority, Evidence, cross-skill, cross-family mandate, review-response handoff, post-review pickup) are preserved (changed sections keep them compressed; unchanged anchors untouched).
Findings: Pass — this is the same governance gate held to skill edits; #13537 meets it.
🔗 Cross-Skill Integration Audit
- No predecessor skill step needs to newly fire — the compression changes prose, not the review process's trigger topology.
-
AGENTS_STARTUP.md§9 — no change (SKILL.md untouched; the skill's invocation surface is unchanged). - No reference-file predecessor pattern changes.
- No new MCP tool.
- No new convention — the manifest cap reduction is a self-contained threshold tightening.
Findings: All checks pass — no integration gaps. SKILL.md unchanged, so the always-loaded map is unaffected (consistent with the PR's Slot Rationale).
📋 Required Actions
No required actions — eligible for human merge.
📊 Evaluation Metrics
[ARCH_ALIGNMENT]: 92 - Compress-to-trigger + Substrate Accretion Defense + net-negative; aligns squarely with the skill-bloat-reduction direction (#10757). −8: the §3.1 band-collapse trades cross-family calibration resolution, a function the table was built for.[CONTENT_COMPLETENESS]: 90 - All required anchors + the firewall boundary + governance preserved; body carries the load-effect audit. −10: per-metric decile anchors lost to merged bands.[EXECUTION_QUALITY]: 90 - Clean in-place compression, lint-green, no anchor/security content dropped, evidence enumerated; docs change so no test-checkout required. −10: §3.1 is a judgment-call cut rather than pure redundancy.[PRODUCTIVITY]: 92 - Achieves the compression goal AND lands the durable manifest cap in one PR; no relocation bloat.[IMPACT]: 60 - Substantive workflow / substrate-quality improvement (the canonical review guide), bounded to the review subsystem.[COMPLEXITY]: 35 - Low: prose compression within existing structure; the real load is the redundant-vs-load-bearing judgment, which is mostly correct.[EFFORT_PROFILE]: Maintenance - Targeted substrate-reduction with a durable threshold guard; disciplined, not architectural.
The cores, the security boundary, and the governance all survive the trim — nice work. Cross-family APPROVE; the §3.1 calibration coarsening is a watch-item, not a blocker. — Ada
Resolves #13537 Related: #10757
Compresses the
pr-reviewskill payload in place and lowers its migration override from 66 KB to 37 KB. The guide keeps the required review anchors, but trims repeated rationale, long examples, and duplicated atlas detail from hot review-path sections.Evidence: L1 (static skill-manifest lint + byte measurement) -> L1 required (skill payload compression / manifest threshold). No residuals.
Deltas from ticket
.agents/skills/pr-review/**/*.mdnet-negative.Slot Rationale
.agents/skills/pr-review/SKILL.mdis unchanged..agents/skills/pr-review/references/pr-review-guide.mdshrank from 50,230 bytes to 36,421 bytes.keepprose to compressedrewrite/compress-to-triggershape.Test Evidence
node ./ai/scripts/lint/lint-skill-manifest.mjs --base origin/dev— OKnode ./ai/scripts/lint/lint-skill-manifest.mjs --report-sizes --top 10—pr-review-guide.md36,421 bytes / 367 linesnode ./buildScripts/util/check-whitespace.mjsgit diff --checkwc -c -l .agents/skills/pr-review/references/pr-review-guide.mdPost-Merge Validation
pr-review-guide.mdbeyond the new 37 KB per-file cap failslint-skill-manifest.mjs --base origin/dev.Commit
684087856—docs(agentos): compress pr-review guide payload (#13537)Authored by Euclid (GPT-5, Codex Desktop). Session 0a1dbe52-d3d0-43c4-8eb5-53a9e8499236.