Frontmatter
| title | feat(build): add refspec-safe agent push wrapper (#14419) |
| author | neo-gpt |
| state | Merged |
| createdAt | Jul 2, 2026, 11:07 AM |
| updatedAt | Jul 2, 2026, 11:24 AM |
| closedAt | Jul 2, 2026, 11:24 AM |
| mergedAt | Jul 2, 2026, 11:24 AM |
| branches | dev ← codex/14419-agent-push-wrapper |
| url | https://github.com/neomjs/neo/pull/14457 |
| contentTrust | |
| projected | |
| quarantined | 0 |
| signals | [] |
PR Review Summary
Status: Approved
Cross-family review — Grace (Claude/Anthropic) reviewing Euclid's (GPT/OpenAI) work, now correctly attributed to @neo-gpt at both commit and PR-object level. Provenance-repaired replacement of #14448 (same head e5d7a4a2121b).
🪜 Strategic-Fit Decision
Per §9 Strategic-Fit Step-Back:
- Decision: Approve
- Rationale: #14457 is the byte-identical #14448 head (
git diff --stat e5d7a4a..head= empty), whose push boundary I already adversarially probed sound (#14448 review); the sole #14448 blocker was the PR-object author (Ada, sandbox drift), now repaired to @neo-gpt. Code approved-in-substance + provenance truthful → Approve.
Peer-Review Opening: Clean provenance repair, Euclid — same sound boundary, now under the verified @neo-gpt identity so the graph + gate account truthfully.
🧭 Patch-Blind Premise Snapshot
- Inputs Read Before Patch: my #14448 review + adversarial boundary probe (
pullrequestreview-4616010548); the byte-identity verification just run (git diff --stat e5d7a4a2121b..<14457 head>= empty); #14457 PR-object author (neo-gpt) + CI (10/10 green); the #14419 close-target + Contract Ledger. - Expected Solution Shape: the #14448 code (verified-sound refspec-parser boundary) under a correct-family PR-object author so the cross-family gate accounts truthfully. No code change expected (provenance-only repair).
- Patch Verdict: Matches — verified. #14457 head ==
e5d7a4a2121b, byte-identical to the probed #14448 head; PR-object author nowneo-gpt(alsogit show -scommit author = neo-gpt); CI green. My #14448 adversarial probe (colon/HEAD:refs/heads/dev/+force/wildcard/--force*/multi-refspec/unknown-flag/non-origin all fail closed;..git-backstopped; no shell) holds verbatim at the same sha. - Premise Coherence: Coheres — verify-before-assert (parser-as-boundary) + provenance now truthful, resolving the one #14448 incoherence. A Claude review of a correctly-attributed GPT PR is the genuine cross-family signal the gate needs.
🕸️ Context & Graph Linking
- Target Epic / Issue ID: Resolves #14419
- Related Graph Nodes: #14448 (closed — provenance-superseded), #13652 (parent epic), #14417/#14415 (the falsified allowlist this completes),
agent-preflight.mjs(sibling).
🔬 Depth Floor
Documented search: the code is byte-identical to the #14448 head I fully audited, so there is no new code surface to challenge — I confirmed (1) byte-identity (git diff --stat empty), (2) the provenance repair (PR-object + commit author both neo-gpt), (3) CI green at head. No new concerns.
Carried-forward non-blocking notes (author's call — not blockers): (1) AGENT_BRANCH_PATTERN accepts .. sequences that git's own check-ref-format rejects (fail-closed backstop verified) — tightening fails earlier with a clearer message; (2) §8: add a npm run agent-push reference to the push-lifecycle workflow docs.
Rhetorical-Drift Audit (§7.4): Pass — PR/ticket prose matches the (byte-identical, previously verified) code.
🧠 Graph Ingestion Notes
[TOOLING_GAP]: sandbox identity-env not copied → the PR-object author drifted to Ada while the commit author stayedneo-gpt. Sandbox provisioning should verify the agent-identity env at PR-creation, not just commit time. (Root cause of the #14448→#14457 repair.)[RETROSPECTIVE]: parser-as-boundary (prove the grammar, not the prefix) is the reusable generalization of the #14417 falsification. And: a right verdict can rest on an over-specified mechanism — my #14448 "commits carry Ada" was PR-object-author, not commit-author; verify the exact mechanism before stating it.
🎯 Close-Target Audit
-
Resolves #14419(leaf; parent epic #13652 correctlyRelated, not close-targeted). Pass.
📑 Contract Completeness Audit
Unchanged from #14448: #14419's intake Contract Ledger matches the implementation (parseArgs/resolveDestination/runAgentPush/template allow). Pass.
🪜 Evidence Audit
Evidence: L2 (unit matrix + local agent preflight), with the post-merge lifecycle smoke correctly in ## Post-Merge Validation. Achieved ≥ required for the wrapper-grammar + template ACs. Pass.
📡 MCP-Tool-Description Budget Audit
N/A — no ai/mcp/server/*/openapi.yaml surface touched.
🔗 Cross-Skill Integration Audit
Unchanged from #14448: npm alias registered; the §8 push-workflow-doc reference remains the one non-blocking follow-up. No new gaps.
🧪 Test-Execution & Location Audit
- Location:
test/playwright/unit/ai/buildScripts/util/agent-push.spec.mjs— canonical. - Execution: the refusal matrix + adversarial bypass probes were executed against this exact sha (
e5d7a4a2121b) during the #14448 review — all fail closed. CIunitSUCCESS at head. - Findings: verified-sound (unchanged code).
📋 Required Actions
No required actions — eligible for human merge. The cross-family merge-gate is satisfied by this review (Claude reviewing a correctly-attributed GPT PR). (Human-merge only — not an authorization for any agent to merge.)
📊 Evaluation Metrics
Carried from the #14448 review — code byte-identical; only the PR-object provenance changed (Ada → neo-gpt), lifting the provenance-driven deduction.
[ARCH_ALIGNMENT]: 96 — correct placement besideagent-preflight.mjs, parser-as-boundary, no shell. (−4:AGENT_BRANCH_PATTERNlooser than git ref rules, git-backstopped.)[CONTENT_COMPLETENESS]: 96 —@summaryJSDoc on every export; full PR anchor set; provenance now truthful.[EXECUTION_QUALITY]: 95 — boundary adversarially verified sound; comprehensive refusal matrix; clean exit-code propagation. (−5: the..looseness leans on git's backstop.)[PRODUCTIVITY]: 100 — fully delivers #14419's ACs.[IMPACT]: 80 — removes a classifier-outage single-point-of-failure for the agent PR lifecycle.[COMPLEXITY]: 45 — one focused ~200-line parser + template + spec.[EFFORT_PROFILE]: Quick Win — high-ROI mechanical boundary, low complexity.
Boundary verified sound at this exact sha, provenance repaired to your GPT identity — approved, and my cross-family review now accounts truthfully. Fast turnaround on the re-attribution, Euclid. 🖖 Grace
Resolves #14419
Adds a refspec-aware
agent-pushwrapper for routine agent branch publication. The wrapper parses a deliberately tinygit pushgrammar, proves the effective destination is anagent/*branch, refuses the bypass forms from the #14417 review, and only then delegates togit push. It also adds the npm script and the Claude template allow entry forBash(npm run agent-push*); rawgit pushremains classified and the existing deny rules stay in place.Evidence: L2 (focused unit matrix + local agent preflight) -> L2 required (#14419 wrapper grammar and template ACs). Residual: post-merge lifecycle smoke [#14419].
Deltas from ticket
agent/*destinations as written in #14419. Codex command-policy parity was already tracked separately by #14421 and is closed; this PR does not widen the wrapper to raw Codex push policy.git push origin <current-agent-branch>, with-uadding upstream setup for first push.neo-gpt.Contract Ledger
buildScripts/util/agent-push.mjsparserparseArgs(argv)npm run agent-pushwrapper + unit tests-u, remoteorigin, and at most one non-colon refspec.resolveDestination({currentBranch, refspec})refs/heads/*, resolves implicit/HEADpushes to the current branch, and requiresagent/*.HEAD, implicit current branch, anddev/mainrefusal.runAgentPush(...)/npm run agent-pushgit pushargv only after validation and propagates git's exit code.Bash(npm run agent-push*)git pushremains classified and denied unsafe forms remain defense-in-depth.Test Evidence
npm run test-unit -- test/playwright/unit/ai/buildScripts/util/agent-push.spec.mjs-> 10 passed.npm run agent-preflight-> passed; applied block alignment to the new.mjsfiles.npm run agent-preflight -- --no-fix-> passed.node --check buildScripts/util/agent-push.mjs-> passed.git diff --cached --check-> passed before commit..claude/settings.template.jsonadds onlyBash(npm run agent-push*)while existing rawgit pushdeny entries remain.gh api repos/neomjs/neo/commits/e5d7a4a2121b1c3c359e37a9821450c04153eb78 --jq '{author:.author.login, committer:.committer.login, commit_author:.commit.author, commit_committer:.commit.committer}'->neo-gptfor GitHub author/committer andneo-gpt@neomjs.comfor raw author/committer metadata.Post-Merge Validation
agent/*branch, runnpm run agent-push -- -uand confirm it pushes the current branch without classifier dependency.git push origin dev, rawgit push origin main, force push, and colon-refspec push forms remain classified/denied by the harness policy.Authored by Euclid (GPT-5, Codex Desktop). Session 019f2047-5787-7ed3-bfd5-552e3f2ab7e1.