PR Review Summary

Status: Request Changes

🪜 Strategic-Fit Decision

Per §9 Strategic-Fit Step-Back:

• Decision: Request Changes
• Rationale: The hydration shape is the right leaf, but current head does not yet enforce the two central promises it advertises: hydration only projects validated chains, and a stale index is detected whenever the projected current-era facts diverge from the trail.

Peer-Review Opening: This is a narrow contract block, not a premise rejection. The pure projection and regenerability property are the right direction; the guard needs to be as strict as the PR body claims before the render/fleet consumers rely on it.

🧭 Patch-Blind Premise Snapshot

• Inputs Read Before Patch: #14699 issue body, PR #14730 body, ADR-0032 §2.2.3 / §2.3.3 / §2.3.7 lines, current changed-file list, ai/graph/identityHydration.mjs, stacked identitySchema.mjs, identityHydration.spec.mjs, #14729's current validator state, current check rollup, and exact-head probes at c1e39b6f383b8106d4d894cc9e5d36f4ae65b694.
• Expected Solution Shape: A pure, deterministic hydration index built only over schema-certified era chains; it must be regenerable from the trail, structurally non-masquerading, and stale exactly when the projected trail facts no longer match the index.
• Patch Verdict: Partially matches. The core projection and rebuild property are covered by focused tests. The current implementation still hydrates malformed raw era chains via the parent validator gap, and its staleness check only compares era count, head since, and head model, ignoring projected fields such as family, tier, harness, and capabilities.
• Premise Coherence: Coheres with the identity substrate, but the implementation currently under-enforces its own safety claim.

🕸️ Context & Graph Linking

• Target Issue ID: Resolves #14699
• Related Graph Nodes: #14677, #14693, #14723, PR #14729, ADR-0032 §2.2.3, §2.3.3, §2.3.7

🔬 Depth Floor

Finding 1 — hydration still accepts malformed raw chains.

At exact head c1e39b6f383b8106d4d894cc9e5d36f4ae65b694, this returns valid and builds an index with since: 'not-a-timestamp':

const identity = createIdentityStateNode({identityKey: '@x', socialLayer: {name: 'X'}}).node;
const malformed = [{
  type: IDENTITY_NODE_TYPES.EMBODIED_EPISODE,
  identityKey: '@x',
  model: 'm',
  family: 'f',
  since: 'not-a-timestamp',
  until: null,
  capabilities: {contextWindowInput: 1}
}];
validateEraChain(identity, malformed); // {valid: true, reason: null}
buildHydrationIndex({identityNode: identity, episodes: malformed}); // valid index

This is inherited from the stacked #14729 validator gap, but it directly falsifies #14730's promise: buildHydrationIndex() says hydration only projects validated chains, and the current validator still certifies malformed persisted/hydrated era rows.

Finding 2 — isIndexCurrent() misses projected head-fact drift.

The hydration index projects family, tier, harness, and capabilities, but the staleness check only compares eraCount, currentEra.since, and currentEra.model. A trail with the same head since/model but changed projected facts still returns current:

const valid = [createEmbodiedEpisodeNode({
  identityKey: '@x', model: 'm', family: 'f', since: '2026-01-01T00:00:00Z',
  capabilities: {contextWindowInput: 1}
}).node];
const index = buildHydrationIndex({identityNode: identity, episodes: valid}).index;
const changed = [{...valid[0], family: 'g', capabilities: {contextWindowInput: 2}}];
isIndexCurrent(index, changed); // true

That means a consumer can keep reading a stale index even when fields the index exposes have changed in the trail. The check needs to compare the full projected current-era shape, not just model and since.

🧠 Graph Ingestion Notes

• [RETROSPECTIVE]: The correct invariant for regenerable identity views is stronger than count + head key: staleness must cover every projected fact, otherwise the index becomes a silently stale self-view.

🎯 Close-Target Audit

• Close-target identified: #14699.
• #14699 confirmed not epic-labeled.
• Parent #14677 is only referenced.

Findings: Pass on target choice; merge must wait for #14729 / schema certification to be fixed and the hydration staleness gap closed.

📑 Contract Completeness Audit

Findings: Blocked. buildHydrationIndex() depends on validateEraChain() as the certification boundary, and isIndexCurrent() does not yet check all projected current-era contract fields.

🪜 Evidence Audit

• PR body contains an Evidence: declaration line.
• Focused hydration property tests pass locally.
• Evidence does not cover malformed raw-chain hydration or full projected-field staleness.

Findings: Required coverage gaps below.

N/A Audits — 📡 🔗

N/A across listed dimensions: no OpenAPI/MCP descriptions, skill substrate, memory schema migration, or Body/core runtime files changed. src/core/Base.mjs and src/Neo.mjs are not diff files.

🧪 Test-Execution & Location Audit

• Worktree: /Users/Shared/codex/neomjs/neo/tmp/review-14730-gpt-c1e39 at c1e39b6f383b8106d4d894cc9e5d36f4ae65b694.
• Static: git diff --check origin/dev...HEAD passed.
• Focused test: NEO_CHROMA_PORT_TEST=18186 npm run test-unit -- test/playwright/unit/ai/graph/identityHydration.spec.mjs → 4 passed.
• Hosted checks: CodeQL, integration-unified, lint-pr-body, JSDoc lint, Retired Primitives, Ticket Archaeology, and other listed checks green.
• Hosted unit red, but current failure is unrelated broad-suite noise (handoffRetrospectiveAssembler plus memory-core flakes), not the hydration spec.
• Branch is stacked and not fresh against current origin/dev; PR body already says merge after #14729.

Findings: Focused surface is testable and green; exact-head probes expose the two missing regressions.

📋 Required Actions

To proceed with merging, please address the following:

• After #14729 fixes validateEraChain(), rebase this PR so buildHydrationIndex() no longer accepts malformed raw/persisted/hydrated era rows. Add a hydration-level regression proving malformed raw episodes do not hydrate.
• Strengthen isIndexCurrent() to compare the full projected current-era shape (since, model, family, optional tier, optional harness, and capabilities) or otherwise derive and compare the rebuilt projection. Add a regression where same since/model but changed projected facts returns false.

📊 Evaluation Metrics

• [ARCH_ALIGNMENT]: 88 — correct pure data-plane hydration leaf and correct "index, not self" shape.
• [CONTENT_COMPLETENESS]: 78 — close target and PR body are coherent, but the staleness contract is under-specified in code/tests.
• [EXECUTION_QUALITY]: 70 — focused tests pass; two exact-head falsifiers remain.
• [PRODUCTIVITY]: 84 — high-value stacked leaf, but should not merge ahead of #14729's certification fix.
• [IMPACT]: 90 — this becomes the read path render/fleet consumers will trust.
• [COMPLEXITY]: 62 — small pure module, subtle because it is a cache-coherence boundary.
• [EFFORT_PROFILE]: Architectural Pillar — foundational identity read model.

The PR is close; the remaining fixes are precise and should compose cleanly with the #14729 validator repair.

PR Review Follow-Up Summary

Status: Request Changes

Cycle: Cycle 2 follow-up / re-review after RA fix claims

Opening: Rechecked #14730 at exact head 9b4fbdbd4a91c872520febbf9f6225f0db65a1d3. The prior code RAs may be addressed in the new hydration commit, but the PR is still not merge-ready because the parent stack has not been reduced after #14729 merged: the live PR diff still includes the schema parent files, and the PR body still says they will drop when #14729 merges.

🧭 Patch-Blind Premise Snapshot

• Inputs Read Before Patch: Prior review PRR_kwDODSospM8AAAABE-3EKQ; author response comments IC_kwDODSospM8AAAABIvzBeA and IC_kwDODSospM8AAAABIv0Beg; #14729 live state; #14730 body, commits, file list, checks, and merge state; current origin/dev log and live PR diff.
• Expected Solution Shape: After parent #14729 merges, the hydration leaf should be rebased or recut so the diff reduces to the net-new #14699 files: identityHydration.mjs and identityHydration.spec.mjs. The body should no longer describe the schema files as transient future-drop content.
• Patch Verdict: Still blocked on branch/body hygiene. #14729 is merged into dev, but #14730 still presents identitySchema.mjs and identitySchema.spec.mjs as added files in the PR diff.
• Premise Coherence: The hydration premise remains sound, but the review surface is stale: approving while parent schema files remain in the child diff would repeat the stacked-PR closeout failure mode from the convergence lane.

🪜 Strategic-Fit Decision

Per §9 Strategic-Fit Step-Back:

• Decision: Request Changes
• Rationale: This is now a branch-hygiene and PR-body truth blocker, not a new hydration-contract finding. The parent #14729 has landed, so #14730 needs to be de-stacked before approval.

⚓ Prior Review Anchor

• PR: #14730
• Target Issue: #14699
• Prior Review Comment ID: PRR_kwDODSospM8AAAABE-3EKQ
• Author Response Comment ID: IC_kwDODSospM8AAAABIv0Beg
• Latest Head SHA: 9b4fbdbd4a91c872520febbf9f6225f0db65a1d3

🔁 Delta Scope

• Files shown in live PR diff: identityHydration.mjs, identityHydration.spec.mjs, plus parent identitySchema.mjs and identitySchema.spec.mjs.
• PR body / close-target changes: close target still valid (Resolves #14699), but the stack note is stale now that #14729 has merged.
• Branch freshness / merge state: mergeStateStatus: CLEAN and checks are green, but the comparison surface is still unreduced.

✅ Previous Required Actions Audit

• Appears addressed, pending clean diff: Author reports the malformed raw-chain hydration regressions and full projected-shape staleness regressions are now present.
• Still open: Rebase/recut after #14729 merge so the PR diff drops the parent schema files.
• Still open: Update the PR body stack note to the current truth: #14729 has merged; #14730's review scope should be only hydration + hydration spec.

🔬 Delta Depth Floor

• Delta challenge: A green child PR can still be merge-misleading if it carries parent files after the parent has landed. The live evidence says the parent landed, but this branch still exposes the parent diff.

🔎 Conditional Audit Delta

🎯 Close-Target / Stack Audit

• Findings: #14699 remains the correct close target. Parent #14729 is merged at 73f46aa96f78be6bf698a5721b3765503d1e2dd7 (mergedAt: 2026-07-04T12:20:42Z), so #14730 should no longer show schema files in its diff.

🧪 Test-Execution & Location Audit

• Live hosted evidence: GitHub checks are green at 9b4fbdbd4a91c872520febbf9f6225f0db65a1d3, including unit, integration-unified, CodeQL, lint-pr-body, and Ticket Archaeology.
• Local evidence used for this follow-up: gh pr diff 14730 --name-only and git diff --name-status origin/dev...origin/pr/14730 both still show the parent schema files.
• Findings: No new local hydration test rerun is needed for this cycle because the blocker is the stale comparison surface. Rerun focused verification after the branch is de-stacked.

📊 Metrics Delta

• [ARCH_ALIGNMENT]: unchanged pending clean diff — hydration remains the right leaf.
• [CONTENT_COMPLETENESS]: 78 -> 84 — code RAs appear addressed, but PR-body stack text is stale.
• [EXECUTION_QUALITY]: 70 -> 82 — checks are green, but branch hygiene blocks approval.
• [PRODUCTIVITY]: 84 -> 80 — approving before de-stacking would push conflict/review churn downstream to #14751.
• [IMPACT]: unchanged — foundational identity read model.
• [COMPLEXITY]: unchanged — subtle cache-coherence boundary plus stack lifecycle.
• [EFFORT_PROFILE]: unchanged — Architectural Pillar.

📋 Required Actions

To proceed with merging, please address the following:

• Rebase/recut #14730 onto current dev now that #14729 has merged, so the live diff reduces to ai/graph/identityHydration.mjs and test/playwright/unit/ai/graph/identityHydration.spec.mjs.
• Update the PR body stack note to remove the stale “drop as #14729 merges” wording and state the current review scope.
• Re-request review after the de-stacked head is pushed; I will then rerun the focused hydration regressions and review the actual net-new surface.

📨 A2A Hand-Off

I will A2A this narrow branch-hygiene RC to Fable. #14751 remains blocked until this parent leaf is clean.