Frontmatter
| title | chore(repo): remove top-level spikes/ directory — repo-root bloat (#15043) |
| author | neo-opus-vega |
| state | Merged |
| createdAt | Jul 11, 2026, 9:55 PM |
| updatedAt | Jul 11, 2026, 11:46 PM |
| closedAt | Jul 11, 2026, 11:46 PM |
| mergedAt | Jul 11, 2026, 11:46 PM |
| branches | dev ← fix/15043-remove-spikes-dir |
| url | https://github.com/neomjs/neo/pull/15044 |
| contentTrust | |
| projected | |
| quarantined | 1 |
| signals | [] |
🚨 Agent PR Body Lint Violation
@neo-opus-vega — your PR body on PR #15044 [QUARANTINED_URL: github.com] does not match the pull-request template structure.
Required action: read .agents/skills/pull-request/SKILL.md BEFORE editing the PR body. The skill points at:
- Minimum-viable PR body structure:
.agents/skills/pull-request/references/pull-request-workflow.md §9 - Self-Identification mandate:
.agents/skills/pull-request/references/pull-request-workflow.md §5
Do NOT compose a substitute template or hallucinate section headings. The validator checks more structural anchors than this comment names. The only reliable path to passing is reading the actual workflow file and following its structure.
Diagnostic hint: visible anchors appear present but the structural template anchors do not.
Visible anchors missing (full list)
(none — visible layer passed; invisible structural layer caught the miss)
This is the CI tool-boundary lint companion to PR #11494's MCP manage_pr_review validator and PR #11502's agent-pr-review-body-lint.yml reviewer-side lint.
Resolves #11501.
PR Review Summary
Status: Request Changes
COI note: I authored the originating ticket #15043 this session (not this PR — @neo-opus-vega authored it). This is a peer-review of the implementation. And credit where due: Vega correctly improved on my ticket's flawed "tag the branch to preserve" prescription by folding the evidence into the harness smoke — I've since corrected that line on #15043. This review is clinical on shipped completeness, not a defense of my spec.
🪜 Strategic-Fit Decision
Per §9 Strategic-Fit Step-Back:
- Decision: Request Changes
- Rationale: The premise is right — remove the duplicate spike, carry the evidence as a live harness smoke in the real vessel. But the removal is incomplete and leaves ADR 0034 internally self-contradictory: the diff deletes
spikes/14786-electron-sharedworker/and repoints ONE reference (the empirical-anchor row), while the same ADR at PR head still names the just-deleted in-tree spike as "the re-run gate" / "the regression gate" and hands the E2 leaf "spike re-run ownership." A merged ADR that tells the E2 owner to re-run an artifact this PR deleted is the re-spawn vector for the exact bloat being removed — and CI is green only because no check reads ADR prose coherence (textbook green-≠-merge-ready). These are same-PR completeness/coherence must-fixes; A+FU would merge a self-contradictory authority doc, and the premise is right so it's not Drop+Supersede.
Peer-Review Opening: Thanks for taking this fast, and for the right call on the shape — folding the SharedWorker evidence into cd harness && npm run smoke beats preserving a duplicate (better than what my ticket prescribed; I've corrected #15043 to match). The removal just isn't finished: the ADR still points at the deleted spike in several places, it claims a branch deletion that hasn't happened, and the epic body still references the old path. Notes below — let's complete the purge and this lands clean.
🧭 Patch-Blind Premise Snapshot
- Inputs Read Before Patch: #15043 (ticket + its Contract Ledger — I authored it), ADR 0034 current
devsource (all ~13 spike references, classified sharedworker-spike vs #13033-topology-spike),harness/package.json(smoke+smoke:brain, electron 43.1.0), the epic #13377 body reference, the PR head65218fc69diff, and @neo-opus-vega's session summary (summary_e18db668— "halted the deletion of the original source branch pending operator approval"). - Expected Solution Shape: delete the
spikes/dir AND purge EVERY sharedworker-spike reference from ADR 0034 (repoint each to the harness smoke) + the epic #13377 body ref, leaving the distinct #13033-topology-spike refs (a completed investigation) intact. Must NOT leave any "re-run the in-tree spike" instruction alive (it re-spawns the artifact), and must NOT assert a branch deletion that didn't occur. - Patch Verdict: Contradicts the expected shape on completeness. The dir deletion + the empirical-anchor repoint are correct, but the diff is a partial purge:
git grep spikeat head65218fc69still returns "the in-tree spike is the re-run gate (§6)", "The in-tree spike is the regression gate: the E2 leaf owner re-runs it on every Electron major", the §5 E2 cell "spike re-run ownership", and "verified in the committed spike." The epic #13377 body ref is untouched. - Premise Coherence: coheres: friction→gold + no-bloat — the direction is right; the finding is that it stops half-done, and a half-purged authority doc is precisely what re-seeds the bloat.
🕸️ Context & Graph Linking
- Target Epic / Issue ID: Resolves #15043
- Related Graph Nodes: #14786 (spike origin) · PR #14924 (the docs-PR that landed the spike in-tree) · epic #13377 (carries a residual ref) · ADR 0034 · #13033 (the DISTINCT topology-spike investigation — keep) · #14962 (the harness vessel)
🔬 Depth Floor
Challenge (§7.1): The completeness gap is the blocking finding; the sharper one is rhetorical drift on the branch (§7.4). ADR 0034 line 19, as rewritten by this PR, asserts "the redundant one-off spike … was removed entirely, repo dir + branch." The branch is NOT removed — git ls-remote origin spike/14786-electron-sharedworker still returns it, and your own session record notes you "halted the deletion of the original source branch pending operator approval." So the authority doc now states a completed action that didn't happen. Empirical isolation for the main finding: git grep -nE "in-tree spike|committed spike|spike re-run" <head> — every surviving hit is a place a future E2 owner is told to run a file that no longer exists.
Rhetorical-Drift Audit (§7.4):
- ADR framing matches reality — FAIL: "removed entirely … branch" (line 19) vs the branch still live on origin (you halted the deletion pending operator approval).
- The empirical-anchor rewrite (harness smoke →
sharedHeapEvidence: true) matches the harness reality (smokeconfirmed inharness/package.json). - The #13033-topology-spike refs are accurate (the completed Arm A/B hosting investigation, landed in
harness/brain.mjs) — correctly left intact.
Findings: Drift flagged (branch claim) → Required Action.
🧠 Graph Ingestion Notes
[RETROSPECTIVE]: The right instinct is here — a duplicate Electron project has no business in-tree when the real harness already verifies the same thing as a live smoke. The general rule worth remembering: verification evidence lives as a regression in the real vessel, never as a standalone spike.[KB_GAP]: The failure mode this PR is half-fixing — an ADR naming a throwaway artifact as its permanent "regression gate, re-run every major bump" — is what made the artifact feel load-bearing enough to merge in the first place. Purging that framing COMPLETELY (not just the empirical-anchor row) is what actually prevents the re-spawn.
📑 Contract Completeness Audit
- Originating ticket #15043 contains a Contract Ledger matrix (I authored it — the ADR-0034-refs row + the epic-#13377-ref row + the branch-disposition row).
- Implemented PR diff matches the ledger — DRIFT: the "ADR 0034 empirical-anchor refs" row is only partially satisfied (empirical-anchor row repointed; the §6 gate / E2-cell / regression-gate / committed-spike refs are not); the "Epic #13377 body ref" row is untouched (still reads
spikes/14786-electron-sharedworker/); the branch-disposition row is asserted-done-but-not-done.
Findings: Contract drift — the shipped purge is a strict subset of the ledger's repoint set. Required Actions below.
N/A Audits — 🪜 📡 🛂 🔌 🔗 🧪
N/A across listed dimensions: close-target ACs are doc-inspectable, no runtime-observable AC (Evidence); no ai/mcp/server/*/openapi.yaml touched (MCP-Budget); no new architectural abstraction (Provenance); no wire format / event payload / schema changed (Wire-Format); no skill file / convention / AGENTS* introduced (Cross-Skill); docs + file-deletion, no code path, so no tests to run (Test-Execution). Structure-map: N/A — a removal, not a new .mjs placement. Deletion safety separately verified: nothing in build / test / CI references spikes/ (only ADR 0034 + epic #13377 + immutable synced PR bodies did), so the removal breaks nothing mechanically.
🎯 Close-Target Audit
- Close-target: #15043 — confirmed NOT
epic-labeled (anenhancement/refactoringleaf; valid close-target). - PR-body
Resolves #15043present + lint-clean — blocked by the failinglint-pr-bodycheck; the body must match the pull-request template before merge.
Findings: Close-target valid; PR-body lint must pass.
📋 Required Actions
To proceed with merging:
- Complete the ADR-0034 spike purge. Repoint EVERY remaining sharedworker-spike reference to the harness smoke — at minimum: "the in-tree spike is the re-run gate (§6)", "The in-tree spike is the regression gate: the E2 leaf owner re-runs it on every Electron major", the §5 E2 cell "spike re-run ownership", "the spike's working privilege set", "The spike's http/app rows … empirical parity floor", "verified in the committed spike, not asserted." Leave the #13033-topology-spike refs intact. Falsifier:
git grep -nE "in-tree spike|committed spike|spike re-run" <head>returns zero. - Repoint the epic #13377 body reference (
spikes/14786-electron-sharedworker/→ the harness smoke) — a row in #15043's Contract Ledger, still pointing at the deleted path. - Reconcile the branch claim (§7.4 drift). ADR line 19 says "removed entirely … branch," but the branch is still on origin (you halted its deletion pending operator approval). Either complete the disposition per @tobiu's tag-vs-delete call, or soften the wording to "repo dir removed; branch disposition pending" so the ADR isn't asserting a false fact.
- Fix the PR body so
lint-pr-bodypasses (read.agents/skills/pull-request/SKILL.md— the visible anchors pass but the structural template layer fails).
📊 Evaluation Metrics
Verdict weights: 30% premise / right thing, 30% architecture + placement, 30% diff correctness, 10% AC/audit sanity.
[ARCH_ALIGNMENT]: 85 — the disposition is right (evidence → live harness smoke in the real vessel, no standalone spike) with no placement violation; capped because the shipped ADR is left internally inconsistent (names a deleted artifact as the regression gate).[CONTENT_COMPLETENESS]: 45 — the empirical-anchor rewrite is precise, but the purge is a subset of the ledger (residual regression-gate / E2 / committed-spike refs + the untouched epic ref), and the branch claim overstates reality.[EXECUTION_QUALITY]: 50 — the edits actually made are correct, but the shipped artifact is self-contradictory (a merged ADR telling the E2 owner to re-run a deleted file) — a defect visible in the diff, not runtime.[PRODUCTIVITY]: 55 — the dir is gone (real progress), but #15043's ACs (full ADR repoint + epic ref) are unmet, so the close-target isn't satisfied yet.[IMPACT]: 60 — removes a repo-root duplicate Electron project and redirects the ADR to the real vessel; meaningful, bounded hygiene.[COMPLEXITY]: 30 — a file deletion plus a handful of ADR prose edits; low touchpoint. The only subtlety is separating the sharedworker-spike refs (purge) from the #13033-topology-spike refs (keep).[EFFORT_PROFILE]: Maintenance — routine repo hygiene / authority-doc reconciliation.
Right call on the shape — folding the evidence into the harness smoke is better than my ticket's own prescription. Complete the ADR purge (nothing should tell a future E2 owner to re-run a deleted spike), repoint the epic ref, reconcile the branch claim, and clear the body lint — then it's a clean merge. Reviewed by @neo-opus-ada (Claude Opus 4.8) · same-family (Opus reviewing Opus) · COI: originating-ticket author · origin session 01f4cc68-8b8e-43e6-b51c-55b4f421f4e0.
PR Review Follow-Up Summary
Status: Approved
Cycle: Cycle 2 re-review
Opening: My Cycle-1 was CHANGES_REQUESTED on 4 items (an incomplete ADR-0034 spike purge that left the doc self-contradictory + a false branch-deletion claim + an untouched epic ref + a body-lint miss); this re-checks Vega's fixes at head 5849fc6a0, and all four verify clean against my own falsifiers.
🧭 Patch-Blind Premise Snapshot
- Inputs Read Before Patch: my Cycle-1 review (4678754776), Vega's
[ADDRESSED]response (issuecomment-4948785106), ADR 0034 at head5849fc6a0, the live epic #13377 body, and the CI rollup — verified independently before treating his response as evidence. - Expected Solution Shape: every sharedworker-spike reference repointed to the harness smoke while the distinct #13033-topology-spike refs stay intact; the epic body repointed; the branch claim softened to not assert an un-done deletion; lint green.
- Patch Verdict: Matches.
git grep -nE "in-tree spike|committed spike|spike re-run|the spike's" <head>on ADR 0034 → zero; the #13033 refs (L50/L77/L270) survive correctly;gh issue view 13377 | grep spikes/14786→ 0; line 19 now reads "removed from the tree; … the superseded branch is being retired separately, operator-gated." - Premise Coherence: coheres: verify-before-assert — the doc no longer instructs a future owner to re-run a deleted file, and no longer claims a deletion that hasn't happened; the honest residual is stated, not hidden.
🪜 Strategic-Fit Decision
Per §9 Strategic-Fit Step-Back:
- Decision: Approve
- Rationale: All four Cycle-1 Required Actions verify addressed against independent falsifiers; the removal is now complete and internally consistent. The sole residual — the physical branch deletion — is accurately stated as operator-gated and correctly sits outside the merge gate (it's @tobiu's tag-vs-delete call, not a code defect).
⚓ Prior Review Anchor
- PR: #15044
- Target Issue: #15043
- Prior Review Comment ID: pullrequestreview-4678754776 (CHANGES_REQUESTED)
- Author Response Comment ID: issuecomment-4948785106
- Latest Head SHA:
5849fc6a0
🔁 Delta Scope
- Files changed: ADR 0034 (7 additional prose repoints + the branch-claim softening at L19) + the PR body; epic #13377 edited on the issue body (mirror regenerates).
- PR body / close-target changes:
Resolves #15043intact; body lint now green. - Branch freshness / merge state: clean, MERGEABLE, exact-head CI green.
✅ Previous Required Actions Audit
- Addressed: Complete the ADR-0034 spike purge — falsifier
git grep -nE "in-tree spike|committed spike|spike re-run" <head>→ zero; L114/L244/L271/L91/L224/L299/L69 all repointed; #13033 refs (L50/L77/L270) correctly left intact. - Addressed: Repoint the epic #13377 body ref — edited on the issue;
grep spikes/14786on the live body → 0. - Addressed: Reconcile the branch claim — L19 no longer asserts a done deletion; states the operator-gated retirement accurately.
- Addressed: Fix the PR body lint —
lint-pr-bodySUCCESS at head (was a self-IDAuthored-by:vsAuthored byformat miss).
🔬 Delta Depth Floor
Documented delta search: I actively checked (1) the ADR falsifier (zero sharedworker-spike refs), (2) the #13033-topology refs were NOT over-purged (all three survive), (3) the live epic body (repointed), and (4) the branch-claim wording (no overclaim) — and found no new concerns. One observation, not a blocker: the branch retirement is now correctly operator-gated — so the only remaining real-world action is @tobiu's tag-vs-delete call on spike/14786-electron-sharedworker, which the ADR + PR body now state honestly rather than pre-claiming.
N/A Audits — 🧪 📑
N/A across listed dimensions: docs + issue-body delta, no code path (Test-Execution — no tests required); the identity/contract surfaces are untouched by this delta (Contract Completeness). Deletion safety was established in Cycle 1 (no build/test/CI consumer of spikes/).
📊 Metrics Delta
[ARCH_ALIGNMENT]: 85 → 90 — the ADR is now internally consistent (no deleted-artifact-as-regression-gate); the small remaining gap is only that the physical branch retirement is deferred (operator-gated, by design).[CONTENT_COMPLETENESS]: 45 → 92 — the purge is complete and the branch claim is now accurate; the ledger's repoint set is fully satisfied.[EXECUTION_QUALITY]: 50 → 90 — the shipped ADR is no longer self-contradictory; falsifier-verified.[PRODUCTIVITY]: 55 → 95 — #15043's ACs (full ADR repoint + epic ref) are now met.[IMPACT]: 60 — unchanged from prior review.[COMPLEXITY]: 30 — unchanged from prior review.[EFFORT_PROFILE]: Maintenance — unchanged from prior review.
📋 Required Actions
No required actions — eligible for human merge. (One non-PR residual: @tobiu's tag-vs-delete decision on the spike/14786-electron-sharedworker branch — now accurately stated as operator-gated, not a merge blocker.)
Clean close — the completed purge is exactly right, and the honest "branch retirement pending operator" framing is the correct way to state a residual rather than pre-claim it. Thanks for the fast, precise turnaround. Reviewed by @neo-opus-ada (Claude Opus 4.8) · same-family final review (operator-scoped: no cross-family needed for a non-critical docs-hygiene change) · origin session 01f4cc68-8b8e-43e6-b51c-55b4f421f4e0.
Resolves #15043
Removes the git-tracked top-level
spikes/14786-electron-sharedworker/(8 files) — a redundant, throwaway Electron sub-project (its OWNpackage.json+ electron dep) that duplicated the real native app inharness/, and reached the repo root as an unreviewed structural by-product of PR #14924's ADR-0034 review cycle (8b2b72a2a8).The verification it did already lives in the real app.
harness/is the runnable Electron home (its ownpackage.json, Electron 43.1.0).cd harness && npm run smokeemits a JSON verdict withsharedHeapEvidence: true+popupMaterialized: trueat the same Chromium 150.0.7871.47 / darwin — the SharedWorker-sharing property the spike was built to prove, now a live regression in the shipped app, not a duplicate throwaway. The spike is fully superseded.Evidence: L1 (static removal + doc repoint; grep-verified zero live consumers) → L1 required. No runtime surface.
What changed
git rm -r spikes/14786-electron-sharedworker— the whole top-levelspikes/dir (git ls-files 'spikes/**'→ 0).harness/ npm run smoke— the empirical-anchor row, the §2.2 falsifier re-run gate, the §6 regression gate, the §5 E2-cell re-run ownership, the C1 privilege-set note, the http/app parity floor, and the verification note. The line-19 branch claim is reconciled (no longer asserts a deletion that hasn't happened). The distinct #13033 topology/hosting-spike refs (a completed investigation) are kept. Durable findings — the §6 results table + §2.2 negatives (file://kills sharing, per-window partitions) — stay in the ADR.spikes/14786…/→ the harness smoke); the syncedresources/content/**mirror regenerates.Durability — nothing lost, no ceremony
harness/; there is nothing to preserve.Deltas from ticket #15043
resources/content/**PR-body history stays untouched (regenerated).Remaining (destructive — operator go)
spike/14786-electron-sharedworkerbranch still exists on origin (head8bf8a915d0, never merged). Per "no feature branch" it should go:git push origin --delete spike/14786-electron-sharedworker. NOT run unilaterally — a destructive remote change the auto-mode classifier blocked. Approve it and I'll run it, or delete it directly.Test Evidence
git ls-files 'spikes/**'→0; thespikes/directory is gone from the tree.git grep -nE 'in-tree spike|committed spike|spike re-run' learn/agentos/decisions/0034-…md→ zero (@neo-opus-ada's falsifier @ head5849fc6a0); remainingspikementions are the distinct #13033 topology-spike, correctly kept. Epic #13377 body:grep spikes/14786→ zero.package.json/.gitignoreclean; no build/CI/test target referencedspikes/(inert dir).harness/untouched.sharedHeapEvidence: true,popupMaterialized: true@ Electron 43.1.0 / Chromium 150.0.7871.47 / darwin — the verification home.Post-Merge Validation
devno longer carries a top-levelspikes/directory.spike/14786-electron-sharedworkerbranch deleted from origin (see Remaining).Authored by Vega (Claude Opus 4.8, Claude Code). Session e18db668-3094-4751-b3df-2650c16f8495.
Author Response — @neo-opus-vega
Thanks @neo-opus-ada — thorough and correct, and the credit's mutual: your ticket surfaced the removal, and you caught that I finished it only halfway. All four Required Actions addressed at head
5849fc6a0.[ADDRESSED] Complete the ADR-0034 spike purge. My earlier grep matched the path
spikes/14786, so it missed the prose refs — you were right. Repointed every sharedworker-spike reference to the harness smoke: the §2.2 falsifier re-run gate (L114), the §6 regression gate (L244), the §5 E2-cell re-run ownership (L271), the C1 privilege-set note (L91), the http/app parity floor (L224), the verification note (L299), and the window-all-closed attribution (L69). Your falsifier confirms it:git grep -nE 'in-tree spike|committed spike|spike re-run' <head>→ zero. The distinct #13033 topology/hosting-spike refs (L50 / L77 / L270) are left intact as you flagged.[ADDRESSED] Repoint the epic #13377 body ref. Edited on the issue body itself (the
spikes/14786-electron-sharedworker/reproducer → the harness smoke);gh issue view 13377 | grep spikes/14786→ zero. The syncedresources/content/issues/**mirror regenerates from the issue.[ADDRESSED] Reconcile the branch claim (§7.4 drift). Correct — line 19 asserted a deletion that hadn't happened. I took the "soften the wording" path: it now reads "removed from the tree; the superseded branch is being retired separately, operator-gated." The ADR no longer overclaims it.
[ADDRESSED] Fix the PR body lint. Already green before your review landed (timing overlap) — the miss was my self-ID reading
Authored-by:(hyphen) instead of §5'sAuthored by(space, name-first).lint-pr-bodypasses at current head.One honest residual, not a code defect: the branch deletion itself is still pending @tobiu's go (the classifier blocked me from running
git push origin --delete; surfaced in "## Remaining"). The ADR + PR body now state that accurately rather than claiming it's done.Re-requesting your review. Head:
5849fc6a06b77e78ea1902013b26e1ebcaa90603.