Frontmatter
| title | test(util): cover Json extraction |
| author | Bortlesboat |
| state | Merged |
| createdAt | 3:10 AM |
| updatedAt | 3:25 AM |
| closedAt | 3:25 AM |
| mergedAt | 3:25 AM |
| branches | dev ← test/15117-json-util-coverage |
| url | https://github.com/neomjs/neo/pull/15120 |
| contentTrust | |
| projected | |
| quarantined | 0 |
| signals | [] |
Two clean contributions in a row — welcome back, @Bortlesboat! 🎉 And you picked up the PR template this time; nicely done.
I ran this spec locally too: 5/5 pass. This one's even more thorough than your first — you covered Json.extract's signature feature (pulling JSON out of Markdown fences across json / javascript / js / untagged forms), the finds-a-block-inside-surrounding-text case, no-throw handling of malformed + empty input, and nested-value preservation. That's exactly the surface these extractors tend to regress on — really well chosen.
Two small housekeeping notes (nothing to change here):
- I've assigned you to #15117 ✅ so the board reflects you're on it. As a general habit for good-first-issues, a quick comment to claim one before starting helps avoid two people grabbing the same ticket — but honestly, your just-go-do-it initiative is exactly the energy we love, so no complaints here.
- Same friendly
Resolves #NoverCloses #Nnote as on #15119 — fully non-blocking, just a one-word habit for next time.
CI auto-ran this time (the first-PR approval gate is behind you now) — mostly green already, and the unit job runs your spec, which I've verified locally. Verified and ready from my side; cc @tobiu for the merge.
Keep 'em coming — this is a genuinely strong start. 🖖 — Grace
Approved ✅ — verified the spec locally (5/5 pass); full review in the comment above. Two strong contributions in a row — welcome aboard! 🖖 — Grace
PR Micro-Review
Class: micro — a single, purely-additive unit-test file (−0 production change).
Verdict: APPROVED ✅
Glance: Verified locally — 5/5 pass against the current util. Idiomatic (follows Neo's unit-test conventions), well-chosen edge cases, zero risk to existing behavior. Full welcoming review + onboarding notes are in the PR comment above. Welcome aboard, @Bortlesboat! 🖖 — Grace
Does this PR resolve an issue? (Required)
Closes #15117
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills this requirement:
devbranch, not themainbranchOther information:
Adds a focused
Neo.util.Json.extract()spec covering:json,javascript,js, and untagged Markdown fencesnullVerification:
git diff --checkpassedAI disclosure: Codex assisted with implementation and verification. I reviewed the complete diff and ran the checks reported above locally.