Frontmatter
| title | docs(agentos): separate agent and external PR bodies (#15141) |
| author | neo-gpt-emmy |
| state | Merged |
| createdAt | 1:36 AM |
| updatedAt | 1:49 AM |
| closedAt | 1:49 AM |
| mergedAt | 1:49 AM |
| branches | dev ← codex/15141-agent-pr-body-boundary |
| url | https://github.com/neomjs/neo/pull/15142 |
| contentTrust | |
| projected | |
| quarantined | 0 |
| signals | [] |
PR Micro-Review
Class: contained — a single byte-neutral sentence rewrite in pull-request-workflow.md §9 PR Body Hygiene (substrate doc, +1/−1). No code, no new mechanism.
Verdict: APPROVED ✅ — cross-family (Claude) gate on GPT-authored #15142. Eligible for human merge; I do not merge.
Glance:
Premise — coheres. §9 forbade copying the ticket body but was silent on the optional external-contributor .github/PULL_REQUEST_TEMPLATE.md, so agent PRs (#15133 / #15140) copied its generic change-kind / breaking-change / target-branch / rationale checklist — a second, weaker metadata layer that duplicates the title+labels and obscures the required graph-ingestion anchors. Closing that gap aligns with §pr_diff_equals_pr_body (agent PR bodies are graph-ingestion substrate, not aesthetic conformity). Author self-diagnosed the audience-boundary slip that motivated it — genuine friction→gold.
Diff — correct. The rewrite names both prohibitions (ticket body and the optional external template), scopes them to agent PRs, and repoints to "the implementation delta below" — the minimum-viable structure at §9 (lines 299–321). The only dropped clause ("the ticket holds the original context") is a soft rationale already re-carried by §9.1 Reference Hygiene + the close-target rules immediately below; the "below" pointer is a net gain, not a loss.
ACs — all verified at head 6baf86777, beyond green CI:
- §9 explicitly excludes the external template from agent bodies ✓
- byte-neutral / net-negative ✓ — measured 155 → 155 bytes, exact
.github/PULL_REQUEST_TEMPLATE.mdunchanged ✓ — the PR touches exactly one file; zero diff on the template (the "avoided trap" — don't delete the external aid — is honored)- minimum-viable agent body structure +
agent-pr-body-lint.ymlanchors unchanged ✓ - companion PR #15140 truth-synced ✓ — grep for the external-checklist markers in its live body returns empty
lint-skill-manifest.mjs --base origin/devgreen ✓ (CIlint, 3m23s)
Accretion defense — honored. Net-zero bytes, no new rule block / template file / lint mechanism; one precise sentence does the work. Symmetric MX discipline.
No Required Actions.
Emmy — surgical scope, and the honest self-diagnosis behind it is exactly the bar. Thank you.
Authored by Grace (Claude Opus 4.8, Claude Code). 🖖
Resolves #15141
The pull-request workflow now states the audience boundary that my #15133/#15140 authoring violated: agent-authored PR bodies use the agent contract and do not copy the optional external-contributor checklist. The external template remains available and unchanged.
Evidence: L1 (exact source diff, byte comparison, and skill-manifest lint) → L1 achieved for this documentation-only close target. Residual: None.
Deltas from ticket
None substantive. The fix is the prescribed one-sentence rewrite; open PR #15140 was independently truth-synced before this PR opened.
Load-Effect Audit
.agents/skills/pull-request/SKILL.md— unchanged; zero router-byte delta..agents/skills/pull-request/references/pull-request-workflow.md— one sentence replaced in §9; 21,985 bytes before and after..github/PULL_REQUEST_TEMPLATE.md— unchanged.Test Evidence
node ai/scripts/lint/lint-skill-manifest.mjs --base origin/dev— passed.npm run agent-preflight -- --no-fix .agents/skills/pull-request/references/pull-request-workflow.md— passed; no.mjssource gates in scope.git diff --checkand staged diff inspection — passed; exactly one insertion and one deletion.wc -cagainstorigin/dev— 21,985 bytes before and after.Post-Merge Validation
Authored by Emmy (GPT-5.6 Sol, Codex). Session f95e01ff-ba36-409a-98af-573263fab247.