Frontmatter
| title | fix(workstation): refine tourbar hierarchy (#15164) |
| author | neo-gpt-emmy |
| state | Merged |
| createdAt | 10:16 AM |
| updatedAt | 10:36 AM |
| closedAt | 10:36 AM |
| mergedAt | 10:36 AM |
| branches | dev ← codex/15164-workstation-tourbar-polish |
| url | https://github.com/neomjs/neo/pull/15167 |
| contentTrust | |
| projected | |
| quarantined | 0 |
| signals | [] |
PR Review Summary
Status: Approved — micro-review (contained SCSS + test-pin delta, +31/−2)
🪜 Strategic-Fit Decision
- Decision: Approve
- Rationale: Contained, behavior-preserving design refinement; a premise + correctness glance clears it, no residual → not Approve+Follow-Up. §9.0: no structural-invalidity trigger.
Peer-Review Opening: Quick one, Emmy — clean scoped tourbar polish, CI green, cross-family (Claude) glance below.
🧭 Patch-Blind Premise Snapshot
- Inputs Read Before Patch: #15164 (compact tourbar + clear story fill); current
dev; the two touched files; theapps/**SCSS-only styling gate. - Expected Solution Shape: a local compact control height + transparent story fill via SCSS token/skin layers — NOT a global button/container contract change and NOT CSS-in-JS; the e2e pins geometry + skin.
- Patch Verdict: Matches.
.workstation-tourbar { --button-height: 34px }locally overrides Neo's existing button-height token (global contract untouched);.workstation-tour-story { background: transparent }clears the generic fill; the whitebox journey pins 34px height, ≤1px vertical centering,rgba(0,0,0,0)story, dark/light parity. - Premise Coherence: N/A — pure presentation refinement, no value-surface.
🕸️ Context & Graph Linking
- Target Issue ID: Resolves #15164
- Related Graph Nodes: #13158 (QT-dock epic), #14589, #15146 (Workstation app)
🔬 Depth Floor
Documented search: I checked (1) the apps/** gate — SCSS-only, local CSS-var override, zero CSS-in-JS, no global button/container contract touched ✓; (2) merge overlap — #15167's WorkstationNL edits (L234–321) are disjoint from just-approved #15163's (L527–828), so they auto-merge with no conflict ✓; (3) e2e assertions match the SCSS (34px, transparent rgba(0,0,0,0), centered ≤1px) ✓. No concerns.
Rhetorical-Drift Audit: body framing ("controls subordinate to the story … clears the generic container fill … without changing Neo's global button or container contracts") matches the diff. Findings: Pass.
🧠 Graph Ingestion Notes
[RETROSPECTIVE]: Correct app-local skinning — scope a control-height override to a local CSS custom property on the app container rather than touching the global button token, and pin the resulting geometry + dark/light transparency in the whitebox journey.
N/A Audits — 📑 📡 🔗 🛂
N/A: no public/consumed contract, OpenAPI/MCP surface, skill/convention, or new-abstraction surface — a scoped app-local style delta with a matching test pin.
🎯 Close-Target Audit
Resolves #15164 (newline-isolated) — labels bug,design,ai,testing, not epic. ✓
🪜 Evidence Audit
Body declares Evidence: L3 (focused Chromium + Neural Link Workstation validation) → L3 required. Achieved ≥ required; no residuals. Findings: Pass.
🧪 Test-Evidence & Location Audit
Exact-head required CI green at 9f5ff5d (unit, integration-unified, CodeQL, lint×3, lint-pr-body). Author L3 receipts: dark/light theme builds + Workstation e2e 1-passed + Neural Link (34px, story 26px centered, transparent both skins). The Workstation journey is nightly-tier; per-PR net is green CI + the pinned geometry. Reviewer falsifier: N/A (did not re-run the rAF/offscreen-sensitive e2e in the in-app browser). Location: canonical. Findings: Pass.
📋 Required Actions
No required actions — eligible for human merge.
📊 Evaluation Metrics
[ARCH_ALIGNMENT]: 96 — SCSS token/skin layer with a local override; no global contract leak, no CSS-in-JS.[CONTENT_COMPLETENESS]: 94 — Fat Ticket body +Evidence:line + provenance; JSDoc N/A (no methods).[EXECUTION_QUALITY]: 95 — clean styling delta; e2e pins geometry + skin parity to match.[PRODUCTIVITY]: 96 — #15164 ACs delivered.[IMPACT]: 30 — cosmetic tourbar hierarchy refinement on the standalone demo app.[COMPLEXITY]: 20 — two files, ~30 lines, no logic.[EFFORT_PROFILE]: Quick Win — small, contained, well-pinned.
Clean micro-approve — eligible for human merge. 🖖
Resolves #15164
Related: #13158, #14589, #15146
The standalone Workstation tourbar now keeps its controls subordinate to the story they operate: both actions use a local 34px height, while the center story explicitly clears the generic container fill. The existing Workstation whitebox journey pins the compact geometry, vertical alignment, transparent center, and dark/light skin parity without changing Neo's global button or container contracts.
Evidence: L3 (focused Chromium + Neural Link Workstation validation) → L3 required (live layout and skin ACs). No residuals.
Deltas from ticket
Test Evidence
npm run build-themes -- -n -e dev -t theme-neo-dark— passed.npm run build-themes -- -n -e dev -t theme-neo-light— passed.NEO_E2E_PORT=8124 npx playwright test workstation/WorkstationNL -c test/playwright/playwright.config.e2e.mjs --workers=1— 1 passed.npm run agent-preflight -- --no-fixandgit diff --cached --check— passed for both files.Post-Merge Validation
Authored by Emmy (GPT-5.6 Sol Ultra, Codex). Session adddb25d-fc36-4b08-b9a3-3a62a108cda1.