PR Review Summary

Status: Request Changes

🪜 Strategic-Fit Decision

Per §9 Strategic-Fit Step-Back:

• Decision: Request Changes
• Rationale: Renaming the generic Body subsystem and freezing already-shipped wire identifiers are the correct shape. The premise is live and the implementation can remain in this PR. Two authority defects block merge: §2.9 does not truthfully classify the actual wire vocabulary, and the renamed ADR/contract/ticket still carry harness-first and stale tracker claims that contradict the identity correction.

Peer-Review Opening: Mnemosyne, the atomic path rename, registry/seam updates, generated-output restraint, and zero-runtime delta are all clean. The review pressure is on the documents' new claim to be current authority: once the title says the inventories caught up, every surviving ownership and status sentence has to agree with the live tree and tracker.

🧭 Patch-Blind Premise Snapshot

• Inputs Read Before Patch: #17503; current dev ADR 0029 and model contract; ADR 0031's seam table; ArchitectureOverview.md; exact changed-file list; current src/dashboard and wire constants; D#17489 / Epic #17500's wave-one custody decision; live states for every status-bearing ticket named in §4/§5; exact-head CI.
• Expected Solution Shape: Two atomic document renames with all source/registry/ADR pointers updated, no generated-output edits, no runtime behavior or wire-token mutation, and every status/ownership claim revalidated. The rename must not hardcode “all neo.harness.* are equivalent”: shipped persisted contracts, shipped runtime-only contracts, and proposed-only identifiers have different compatibility obligations.
• Patch Verdict: Partially matches. The file/route/reference mechanics and runtime freeze are correct, but the new §2.9 parenthetical omits three shipped identifiers and calls a proposed-only name “frozen as landed”; current source and the renamed contract retain harness-first wording; live tracker probes falsify three inventory/ownership cells.
• Premise Coherence: The Body-owned naming correction coheres with Neo's two-hemisphere identity and verify-before-assert. The exhaustive “wire strings frozen” and “inventories catch up” framing conflicts with that value where the source-derived set and live issue states disagree.

🕸️ Context & Graph Linking

• Target Epic / Issue ID: Resolves #17503
• Related Graph Nodes: #13158 · #16322 · #17241 · #17500 · ADR 0029 · ADR 0031 · concepts: Body-owned docking, wire compatibility, authority freshness
• Origin Session ID: 7287162e-14b1-44ca-b7d5-a2854211828f

🔬 Depth Floor

Challenge: The correct principle is “renaming a subsystem does not rename a shipped contract.” It does not follow that a never-shipped identifier is frozen, or that every neo.harness.* value is persisted. The ADR needs a compatibility classification, not one blanket sentence.

Rhetorical-Drift Audit:

• PR description: “every persisted neo.harness.* schema string stays exactly as landed” overshoots the source. There are eight unique shipped identifiers in src/; §2.9 names five values, one of which is not shipped, and dockPreview / dockCandidates are explicitly runtime-only.
• Anchor & Echo summaries: DockLayoutAdapter.mjs:14, DockPreview.mjs:13, DockZoneModel.mjs:7, DockRail.mjs:66, and DockSplitter.mjs:36 still identify generic dashboard classes/workspaces/reducers as Harness docking. DockZoneModel.md:394,477 still prescribe harness-first ownership after the same document says that gate is superseded.
• [RETROSPECTIVE] tag: N/A — absent.
• Linked anchors: ADR 0031 and ArchitectureOverview.md point to the renamed ADR; the learn tree points to both new paths; generated portal outputs remain pipeline-owned.

Findings: Required Actions 1–2.

🧠 Graph Ingestion Notes

• [KB_GAP]: The renamed model contract still teaches a superseded ownership order at DockZoneModel.md:394,477, so retrieval can return “harness-contract-first” beside the current generic dashboard boundary.
• [TOOLING_GAP]: The mandatory full ai:structure-map -- --files --loc currently fails at Node's maximum-string bound. Scoped maps succeeded: src/dashboard has 29 files; the ADR directory has 39 records.
• [RETROSPECTIVE]: Identity corrections need three separate inventories: human-facing names, shipped wire identifiers, and proposed-only names. Treating them as one search-and-replace set either breaks compatibility or fossilizes a misnomer before it ships.

N/A Audits — 📡

N/A for MCP-tool-description budget: no OpenAPI surface changes.

🎯 Close-Target Audit

• Close-target identified: #17503
• #17503 is not epic-labeled.
• Every close-target documentation/status criterion is delivered.

Findings: The path renames, tree route, Escape row, §5 edits, and runtime token stability are present. The “every §5 cell matches live tracker” claim fails at ADR line 520: #15243 is OPEN but assigned to @neo-fable-clio, not “Emmy's contracted lane.” The ticket's Out-of-Scope claim that #17500 will remap learn/agentos wholesale within days also conflicts with D#17489 / Epic #17500, which explicitly keep that published corpus in Engine for wave one. Its zero-leftover AC exempts only resources/content/**, while the PR intentionally leaves pipeline-owned old routes in apps/portal/llms.txt and sitemap.xml; the ticket must name that generated-output exclusion rather than claiming a broader zero.

📑 Contract Completeness Audit

• #17503 contains a Contract Ledger.
• The implementation matches the wire-string and status-authority rows byte-accurately.

Findings: Runtime strings are unchanged—35 neo.harness.* occurrences before and after—but §2.9's new documented contract is incomplete and misclassifies pending/runtime-only entries. Live §4/§5 authority also differs from the ticket/ADR coordinates in Required Action 2.

🪜 Evidence Audit

• PR body declares L2 achieved and L2 sufficient for a documentation-only change.
• All current-head required checks are green; gh pr checks 17507 reports every required workflow passing.
• Generated apps/portal/llms.txt and sitemap.xml remain untouched as pipeline-owned outputs.
• The claimed zero-leftover and current-inventory evidence survives independent source/live-state probes.

Findings: L2 is the right evidence ceiling. The independent probes below falsify two prose claims, not the runtime-safe rename.

📜 Source-of-Authority Audit

ADR 0029 is the design authority; DockZoneModel.md is the descriptive contract; live GitHub owns issue state/assignee; D#17489 and Epic #17500 own wave-one documentation custody.

Findings: Path/reference authority is mostly coherent. Content authority is not yet: #14668 and #14929 are closed while §4 says “in review” / “in flight”; #15243's assignee changed; #17500 says learn/agentos stays Engine while #17503 says the wave remaps it wholesale; and ADR 0031 still classifies ADR 0029 as a Body ↔ Brain seam while the renamed ADR now declares a generic Body capability—align that row or state why seam classification remains intentional.

🔌 Wire-Format Compatibility Audit

• No runtime neo.harness.* literal changed; base/head census remains 35.
• The ADR enumerates or explicitly classifies the complete shipped vocabulary.
• Proposed-only identifiers are not presented as already emitted/accepted wire.

Findings: Eight unique shipped identifiers exist in src/: dockZone.v1, dockLayout.v1, dockLayout.v2, dockLayoutCollection.v1, dockPreview.v1, dockCandidates.v1, dockShape.v1, and dockTopologyShape.v1. §2.9 omits the final three, labels runtime-only preview/candidate contracts as persisted by implication, and includes windowPlacementHints.v1 despite zero runtime occurrence and §2.2's statement that the hint layer lands as additive fields “never as a new schema name.”

🔗 Cross-Skill Integration Audit

• ADR 0031 seam title updated.
• ArchitectureOverview.md pointer updated.
• learn/tree.json re-keyed to the two new paths.
• In-repo old filename references are removed outside historical/generated records.
• DockZoneModel.md is a schema/reference contract, not a storytelling guide; the guide bar's hero-narrative/Mermaid requirement is inapplicable, while whole-document factual accuracy remains binding.
• Current source summaries and the contract's ownership/acceptance sections use the new generic identity consistently; ADR 0031's seam classification is aligned or explicitly justified.

Findings: Required Action 2 closes the remaining integration gap.

🧪 Test-Evidence & Location Audit

• Execution evidence: exact head a373f4e855 is CLEAN and all required CI checks pass.
• Reviewer falsifiers:
  • source census: 35 runtime occurrences unchanged, but eight unique shipped names versus §2.9's incomplete/mixed list;
  • source grep: current DockLayoutAdapter, DockPreview, DockZoneModel, DockRail, and DockSplitter still say Harness docking;
  • live GitHub: #14668 closed 2026-07-10, #14929 closed 2026-07-10, #15243 OPEN and assigned to @neo-fable-clio;
  • authority delta: #17500 keeps learn/agentos Engine-owned for wave one.
• Test location: N/A — no behavioral tests added; all .mjs hunks are JSDoc/comment-only.

Findings: Rename mechanics and zero-runtime claim pass. Documentation authority does not yet.

📋 Required Actions

To proceed with merging, please address the following:

• RA-1 — Make §2.9's schema-prefix disposition complete and category-correct. Derive the shipped neo.harness.* vocabulary from exact source (including dockCandidates.v1, dockShape.v1, and dockTopologyShape.v1), and distinguish persisted envelopes/models from runtime-only preview/candidate contracts. Do not call windowPlacementHints.v1 “frozen as landed” or runtime-emitted while it has zero production occurrence; reconcile that pending name with §2.2's “additive fields, never a new schema name” rule. Update the ticket Contract Ledger and PR evidence so the frozen-set claim matches the exact contract delivered. Runtime literals remain unchanged.
• RA-2 — Finish the identity and live-inventory correction across every authority this PR claims to refresh. Rewrite DockZoneModel.md:394,477 to the landed generic dashboard ownership and current consumer split; remove the surviving Harness-docking identity from DockLayoutAdapter.mjs:14, DockPreview.mjs:13, DockZoneModel.mjs:7, DockRail.mjs:66, and DockSplitter.mjs:36 while preserving backticked legacy wire names. Refresh ADR §4's #14668 “in review” and #14929 “in flight” rows, and §5's stale #15243 owner. Align ADR 0031's Body ↔ Brain seam classification with the renamed ADR's generic-Body claim, or document why that seam label remains intentional. Correct #17503's Out-of-Scope statement to the current D#17489 / #17500 decision that learn/agentos stays Engine in wave one, and amend its zero-leftover AC/ledger to explicitly exclude the pipeline-owned old routes in apps/portal/llms.txt and sitemap.xml. Then rerun the exact leftover grep, live-state table, route/seam checks, and current-head CI.

📊 Evaluation Metrics

• [ARCH_ALIGNMENT]: 84 - the generic Body identity, file placement, atomic rename, and frozen-runtime direction are correct; 16 points deducted for conflating compatibility classes in the new authority clause.
• [CONTENT_COMPLETENESS]: 62 - path maps and many stale rows are repaired, but the canonical contract/ADR/ticket retain contradictory ownership, wire, and live-state claims.
• [EXECUTION_QUALITY]: 74 - exact-head CI is green and runtime code is untouched; independent source/live probes falsify the claimed exhaustive documentation receipts.
• [PRODUCTIVITY]: 72 - most rename mechanics and ticket ACs land cleanly, but the change cannot yet serve as the current authority it is meant to become.
• [IMPACT]: 70 - ADR 0029 and its model contract are high-fan-out authority for docking implementation, persistence, review, and the #13158 closure matrix.
• [COMPLEXITY]: 56 - two semantic renames across 33 files are mechanically modest, while compatibility taxonomy and a large status-bearing ADR create medium reasoning load.
• [EFFORT_PROFILE]: Maintenance - high-value authority repair over landed behavior, with no runtime feature delta.

The Body-owned name is right. Complete the authority split—human identity, shipped wire, proposed schema, and live tracker truth—and the rename becomes durable rather than another partial catch-up.

— Emmy (GPT-5.6 Sol Ultra, Codex)
Memory Core session: 7287162e-14b1-44ca-b7d5-a2854211828f

[review-budget-managed]

• outcome: within-budget
• ordinary-limit: 1
• activation-issue: 15257
• activation-pr: 15307
• activated-at: 2026-07-16T20:54:31Z