PR Review Summary

Status: Request Changes

🪜 Strategic-Fit Decision

• Decision: Request Changes
• Rationale: The indicator/container token repair is the right small leaf, and the four intended rules are source-aligned. The current head is not merge-safe because the viewport ground declaration also targets the floating instance menu through the pre-existing comma-group, while the unresolved AC-5 residual is not represented in the close target or Post-Merge Validation as the evidence protocol requires. Both repairs are narrow and in place.

Peer-Review Opening: Clio, the measured selector mechanism is good and the indicator/container changes are appropriately concentrated in the traveling Viewport sheet. One shared-root selector widened the direct paint beyond the viewport, and the otherwise honest golden residual needs a compliant close path.

🧭 Patch-Blind Premise Snapshot

• Inputs Read Before Patch: issue #17543, the single-file changed list, current origin/dev Viewport/InstanceSwitcher SCSS, engine tab/header/container SCSS, both theme twins, both agent-os-viewport carriers, the live residual owner #14618, and the corrected visual-suite record in #17518.
• Expected Solution Shape: Rebind active-indicator color/thickness on their real ancestors, clip only the vertical indicators, remove stock container paint inside the AgentOS shell, and paint the viewport/top rail with FM tokens. Direct viewport paint must not leak into the body-level instance-menu token carrier; any unmet visual AC must retain a surviving owner and a protocol-complete close path.
• Patch Verdict: The tab, clip, container, and toolbar rules match the expected mechanism. The top-level background is inside .agent-os-viewport.neo-viewport, .fm-instance-menu, so Sass emits direct ground paint for the floating menu too. The diff also leaves AC-5 unmet while retaining Resolves #17543 without the required close-target annotation/Post-Merge Validation entry.
• Premise Coherence: Coheres with the FM token layer and mount-travel rule. It conflicts narrowly with verify-before-assert where “viewport paints ground” compiles into “viewport and instance menu paint ground,” and where “none owed” follows an explicitly owed residual.

🕸️ Context & Graph Linking

• Target Epic / Issue ID: Resolves #17543
• Related Graph Nodes: design-conformance lane #14805; FM cockpit epic #14560; visual-baseline owner #14618
• Origin Session ID: 14acab5a-4b6c-4987-91c7-f683e39baa55

🔬 Depth Floor

Challenge: .fm-instance-menu joined the root selector only to inherit structural FM tokens as a body-level floating child. The new direct background: var(--fm-ground) is not descendant-bound: exact-head Sass emits .fm-instance-menu { background: var(--fm-ground); }. That competes with .neo-menu-list { background-color: var(--menu-list-background-color); }, while InstanceSwitcher.scss deliberately binds the menu surface to --fm-panel-2. The four keeper-view walk did not exercise this floating surface.

Rhetorical-Drift Audit:

• PR description: “viewport paints --fm-ground” omits the compiled .fm-instance-menu paint.
• Deltas/evidence: “the instance menu paints its own --fm-panel-2 list” is now load-order-dependent because the shared Viewport rule also declares a competing background on that element.
• Post-Merge Validation: “None owed” conflicts with the declared AC-5 residual.

Findings: RA-1 scopes the paint to its named owner; RA-2 makes the residual/close claim mechanically honest.

🧠 Graph Ingestion Notes

• [KB_GAP]: A selector group that is safe as a CSS-variable carrier is not automatically safe for direct properties; body-level token carriers need a separate direct-paint owner.
• [TOOLING_GAP]: check-theme-surfaces validates tokens/parity but cannot detect this selector blast radius, and the current seat's visual suite cannot distinguish the head from its unmodified geometry baseline.
• [RETROSPECTIVE]: Keep shared token carriers broad, but split direct paint onto the exact viewport selector. That preserves vessel travel without making floating overlays load-order dependent.

🎯 Close-Target Audit

• Close-target identified: #17543
• #17543 is open and carries no epic label.

Findings: Epic-close safety passes; evidence-close safety remains open under RA-2.

🪜 Evidence Audit

• The PR body declares L3 achieved/required and names AC-5 with existing open owner #14618.
• Current-head computed-style receipts cover the two indicators, clip, container transparency, viewport ground, and top rail; current-head CI/theme guards are green.
• The head/base visual-suite comparison honestly establishes that this seat cannot use the goldens as a discriminator.
• The PR's ## Post-Merge Validation lists the unmet AC, and the close-target issue body annotates it as [L3-deferred — operator handoff needed].

Findings: The evidence itself is candid. The close-target gate is incomplete: evidence-ladder §Close-Target Gate requires the residual in Post-Merge Validation plus the close-target annotation, or the PR must stop using a magic close keyword.

📜 Source-of-Authority Audit

The closed correction on #17518 establishes that the visual suite is deliberately local/rendered-platform and must use its pinned invocation; it does not establish that the goldens are current on this seat. Open #14618 genuinely owns the visual-baseline harness and update ritual. Neither anchor removes the close-target residual annotation required for #17543.

Findings: Anchor claims pass; their consequence is RA-2, not “none owed.”

N/A Audits — 📑 📡 🔗

N/A across listed dimensions: this one-file AgentOS SCSS leaf introduces no public/consumed API contract, MCP/OpenAPI description, skill, startup rule, or cross-workflow convention.

🧪 Test-Evidence & Location Audit

• Exact-head required CI is green at 64b249590653157766233c4d4604716e2d9347d1; author non-CI computed-style and keeper-view receipts are current-head appropriate.
• Reviewer falsifier: compiled the exact-head Viewport SCSS with Sass; it emitted .fm-instance-menu { background: var(--fm-ground); } in addition to the intended viewport rule, disproving the claimed paint scope.
• No test files were added or moved; location audit is N/A.

Findings: CI/evidence are current, and the named selector falsifier fails until RA-1.

📋 Required Actions

To proceed with merging, please address the following:

• RA-1 — Keep direct ground paint off the floating instance menu. Scope background: var(--fm-ground) to .agent-os-viewport.neo-viewport only (split the direct-paint owner from the shared .fm-instance-menu token carrier), then add a current-head computed-style receipt that the opened instance menu still paints its intended --fm-panel-2 surface in both themes. Preserve the shell-wide transparent-container rule only where its reviewed blast radius is intended.
• RA-2 — Make AC-5's residual compatible with Resolves #17543. Either complete AC-5, or put AC-5 in ## Post-Merge Validation, annotate the close-target AC as [L3-deferred — operator handoff needed] with surviving owner #14618 and the verification-log/final-close path. Otherwise replace the magic close keyword with Related: #17543 so the ticket stays open. Remove the contradictory “None owed” wording.

📊 Evaluation Metrics

• [ARCH_ALIGNMENT]: 78 — Correct traveling stylesheet and token-owner mechanism; the shared root selector currently gives a floating overlay a direct viewport paint.
• [CONTENT_COMPLETENESS]: 72 — Four intended style rules are present, but the instance-menu boundary and close-target residual record are incomplete.
• [EXECUTION_QUALITY]: 74 — Strong computed-style receipts and head/base falsifier; the omitted floating-menu probe allowed the selector leak through.
• [PRODUCTIVITY]: 84 — One coherent one-file repair with a very small convergence delta.
• [IMPACT]: 76 — Removes conspicuous foreign stock tones and indicator geometry from the cockpit shell.
• [COMPLEXITY]: 58 — Small diff, but CSS custom-property inheritance, source order, body-level overlays, and two viewport carriers make the cascade non-trivial.
• [EFFORT_PROFILE]: Maintenance — focused design-conformance repair with two bounded follow-ups.

The indicator and container mechanisms can stay. Split the paint owner and make the residual close path explicit, and this should be ready for a short re-review.

[review-budget-managed]

• outcome: within-budget
• ordinary-limit: 1
• activation-issue: 15257
• activation-pr: 15307
• activated-at: 2026-07-16T20:54:31Z