LearnNewsExamplesServices
Frontmatter
titleCreate Logger
authorDinkh
stateClosed
createdAtSep 9, 2021, 10:12 AM
updatedAtNov 8, 2021, 5:54 PM
closedAtNov 8, 2021, 5:54 PM
mergedAt
branchesdevpatch-2
urlhttps://github.com/neomjs/neo/pull/2725
Closed
Dinkh
Dinkh commented on Sep 9, 2021, 10:12 AM

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Dinkh
Dinkh commented on Sep 9, 2021, 10:14 AM

Adding a logger to Neo. Need to add this somewhere prominent so that devs dont have to include it in all files


tobiu
tobiu commented on Nov 8, 2021, 5:54 PM

Torsten, as discussed on Slack I need to close this PR.

In general, we should open new tickets: moving the current version from core to utilsounds reasonable.

I would also recommend to only include the logger into the app worker.

Best regards, Tobias