Frontmatter
| title | fix #4067 |
| author | deniztoprak |
| state | Merged |
| createdAt | Feb 17, 2023, 9:03 PM |
| updatedAt | Feb 19, 2023, 10:10 PM |
| closedAt | Feb 17, 2023, 10:26 PM |
| mergedAt | Feb 17, 2023, 10:26 PM |
| branches | dev ← build-optimization |
| url | https://github.com/neomjs/neo/pull/4068 |
Merged

deniztoprak
commented on Feb 17, 2023, 9:05 PM
Fixes #4067

tobiu
commented on Feb 17, 2023, 10:28 PM
thx deniz!
one thought: in case a child process breaks (not returning 0), should the main process stop right away or should all other CPs still run? not sure on this one :)

deniztoprak
commented on Feb 19, 2023, 10:10 PM
That's what I was thinking. Continuing the build process is useless, once a build step is failing. It just wastes time/energy. Check out the #4072.
Please make sure to read the Contributing Guidelines:
https://github.com/neomjs/neo/blob/dev/CONTRIBUTING.md
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch, not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: