LearnNewsExamplesServices
Frontmatter
titlefix #4067
authordeniztoprak
stateMerged
createdAtFeb 17, 2023, 9:03 PM
updatedAtFeb 19, 2023, 10:10 PM
closedAtFeb 17, 2023, 10:26 PM
mergedAtFeb 17, 2023, 10:26 PM
branchesdevbuild-optimization
urlhttps://github.com/neomjs/neo/pull/4068
Merged
deniztoprak
deniztoprak commented on Feb 17, 2023, 9:03 PM

Please make sure to read the Contributing Guidelines:

https://github.com/neomjs/neo/blob/dev/CONTRIBUTING.md

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

deniztoprak
deniztoprak commented on Feb 17, 2023, 9:05 PM

Fixes #4067


tobiu
tobiu commented on Feb 17, 2023, 10:28 PM

thx deniz!

one thought: in case a child process breaks (not returning 0), should the main process stop right away or should all other CPs still run? not sure on this one :)


deniztoprak
deniztoprak commented on Feb 19, 2023, 10:10 PM

That's what I was thinking. Continuing the build process is useless, once a build step is failing. It just wastes time/energy. Check out the #4072.