Frontmatter
| title | fix #4067 |
| author | deniztoprak |
| state | Merged |
| createdAt | Feb 19, 2023, 10:02 PM |
| updatedAt | Feb 19, 2023, 10:45 PM |
| closedAt | Feb 19, 2023, 10:42 PM |
| mergedAt | Feb 19, 2023, 10:42 PM |
| branches | dev ← build_optimization |
| url | https://github.com/neomjs/neo/pull/4072 |
Merged

deniztoprak
commented on Feb 19, 2023, 10:04 PM
Fixes #4067

tobiu
commented on Feb 19, 2023, 10:45 PM
thx deniz! i like the changes :)
one minor hint: in case you are increasing the framework version number, please use npm run inject-package-version afterwards. this script adjusts the version number inside the neo default config and a flag inside service workers, so that they will clear the cache.
Please make sure to read the Contributing Guidelines:
https://github.com/neomjs/neo/blob/dev/CONTRIBUTING.md
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch, not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: