LearnNewsExamplesServices
Frontmatter
titleupdated-validations
authorsubramaniyamP
stateMerged
createdAtAug 11, 2023, 7:14 AM
updatedAtAug 11, 2023, 8:40 AM
closedAtAug 11, 2023, 8:36 AM
mergedAtAug 11, 2023, 8:36 AM
branchesdev ← dev
urlhttps://github.com/neomjs/neo/pull/4696
Merged
subramaniyamP
subramaniyamP commented on Aug 11, 2023, 7:14 AM

Please make sure to read the Contributing Guidelines:

https://github.com/neomjs/neo/blob/dev/CONTRIBUTING.md

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

tobiu
tobiu commented on Aug 11, 2023, 8:36 AM

hi @subramaniyamP!

why did you indend the method 4 spaces to the left and remove the closing } for the class? plus we can shorten the else if before the validator check.

i will merge it in anyways and fix it, since i like to see you inside the contributors list :)

Screenshot 2023-08-11 at 08 37 56