LearnNewsExamplesServices
Frontmatter
titleremove me.clean from text field validation
authorr-l-d
stateMerged
createdAtAug 22, 2023, 3:28 PM
updatedAtAug 22, 2023, 3:55 PM
closedAtAug 22, 2023, 3:48 PM
mergedAtAug 22, 2023, 3:48 PM
branchesdev ← dev
urlhttps://github.com/neomjs/neo/pull/4766
Merged
r-l-d
r-l-d commented on Aug 22, 2023, 3:28 PM

Please make sure to read the Contributing Guidelines:

https://github.com/neomjs/neo/blob/dev/CONTRIBUTING.md

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information: Caused validation issues for form fields in app (would not validate on a fresh form)

tobiu
tobiu commented on Aug 22, 2023, 3:30 PM

hi ross, it is impossible for me to review any changes, in case you change the entire formatting: https://github.com/neomjs/neo/pull/4766/files

r-l-d
r-l-d commented on Aug 22, 2023, 3:30 PM

@tobiu this reverts our change from last week, it was causing field validation issues in the app:

 afterSetRequired(value, oldValue) {
    let me = this;
me.silentVdomUpdate = true;

me.validate(false);
me.changeInputElKey("required", value ? value : null);
me.labelText = me.labelText; // apply the optional text if needed

me.silentVdomUpdate = false;

me.update();



  }

r-l-d
r-l-d commented on Aug 22, 2023, 3:39 PM

@tobiu formatting updated :)

tobiu
tobiu commented on Aug 22, 2023, 3:47 PM

ok, will merge it in. hoping that it does not break the currency-field inside the project.

however, this will go into neo v6 => see teams => we need a bit more help with testing the new release to merge it into dev there.

r-l-d
r-l-d commented on Aug 22, 2023, 3:55 PM

Thanks, Tobi. I'm also updating the currency field inside the project to account for this change.