LearnNewsExamplesServices
Frontmatter
titleform.field.checkbox: isValid() needs to honor validation rules
authorrashmibramhankar
stateMerged
createdAtAug 24, 2023, 10:15 AM
updatedAtAug 24, 2023, 10:43 AM
closedAtAug 24, 2023, 10:43 AM
mergedAtAug 24, 2023, 10:43 AM
branchesdev ← dev
urlhttps://github.com/neomjs/neo/pull/4775
Merged
rashmibramhankar
rashmibramhankar commented on Aug 24, 2023, 10:15 AM

Please make sure to read the Contributing Guidelines:

https://github.com/neomjs/neo/blob/dev/CONTRIBUTING.md

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

tobiu
tobiu commented on Aug 24, 2023, 10:43 AM

Hi Rashmi,

the PR sounds fair: it is in sync then to TextField. Otherwise isValid() would only work in case validate() was already triggered (which sets the value of the error config).