LearnNewsExamplesServices
Frontmatter
titleAdd firefox compatibilty to onSelectionChange
authorr-l-d
stateMerged
createdAtSep 5, 2023, 9:00 AM
updatedAtSep 5, 2023, 9:25 AM
closedAtSep 5, 2023, 9:25 AM
mergedAtSep 5, 2023, 9:25 AM
branchesdevdev
urlhttps://github.com/neomjs/neo/pull/4840
Merged
r-l-d
r-l-d commented on Sep 5, 2023, 9:00 AM

Please make sure to read the Contributing Guidelines:

https://github.com/neomjs/neo/blob/dev/CONTRIBUTING.md

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

r-l-d
r-l-d commented on Sep 5, 2023, 9:03 AM

Resolves an issue where firefox uses event.target instead of event.target.activeElement (like Chrome) for onSelectionChange events.


tobiu
tobiu commented on Sep 5, 2023, 9:24 AM

hi ross! thx. will merge it in. i will probably add target as a variable, since we are using it 3+ times now (file size).