LearnNewsExamplesServices
Frontmatter
titleFeature/user change event fix #4818
authorunknown
stateClosed
createdAtSep 14, 2023, 5:06 PM
updatedAtSep 18, 2023, 11:39 AM
closedAtSep 14, 2023, 8:30 PM
mergedAt
branchesdevfeature/user-change-event
urlhttps://github.com/neomjs/neo/pull/4905
Closed
unknown
unknown commented on Sep 14, 2023, 5:06 PM

Please make sure to read the Contributing Guidelines:

https://github.com/neomjs/neo/blob/dev/CONTRIBUTING.md

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

unknown
unknown commented on Sep 14, 2023, 5:14 PM

@tobiu there is an issue when firing the userChange event in the Text component that I couldn't solve. When the user changes the field manually, first the userChange is fired, right before the change event. Since the fireChangeEvent method is debounced and the change comes right after userChange, userChange is never emitted. You can test it with/without delayable to see the difference.

fix #4818


tobiu
tobiu commented on Sep 14, 2023, 8:30 PM

hi deniz, looks nice, but i have an idea how to resolve the issues in a different way (separate timers).

closing the PR and will provide an alternative, which we should discuss afterwards.