What is the Neural Link?

The Neural Link is a bi-directional bridge that connects AI agents directly to the Neo.mjs runtime. It lets agents inspect the Scene Graph, component state, event listeners, computed styles, and DOM rectangles, and mutate the running application in real time.

Why is Neo.mjs called an Application Engine instead of a framework?

Neo.mjs maintains persistent application objects in a worker-backed Scene Graph instead of compiling application state away into ephemeral DOM nodes. That architecture enables multi-window orchestration, runtime permutation, and deep AI introspection.

What is Context Engineering?

Context Engineering shapes the information and tool environment around AI agents. Neo.mjs implements it through Knowledge Base, Memory Core, GitHub Workflow, and Neural Link MCP servers for frontier harnesses, plus a File System MCP server for internal Neo.ai.Agent local loops.

What is the Neo.mjs Agent OS?

The Neo.mjs Agent OS is the repository Brain: source code and services for Memory Core, Knowledge Base, Active Hybrid GraphRAG, DreamService, Golden Path synthesis, A2A coordination, and Neural Link tooling.

Neo.mjs - Self-Evolving Software Organism

Frontmatter

title	Fix #4799 - form.field.Select Editable False Behavior
author	stokedowl
state	Closed
createdAt	Oct 4, 2023, 1:57 PM
updatedAt	Oct 12, 2023, 6:59 AM
closedAt	Oct 12, 2023, 6:59 AM
mergedAt
branches	`dev` ← `dev`
url	https://github.com/neomjs/neo/pull/4971

Closed

stokedowl commented on Oct 4, 2023, 1:57 PM

https://github.com/neomjs/neo/assets/24494104/7491568f-ee24-4664-87ae-a98f60cdb361

Summary:

This PR addresses the issue outlined in #4799 regarding the behavior of form.field.Select when editable is set to false. Previously, the picker wouldn't hide onFocusLeave() due to certain CSS rules (pointer-events: none; user-select: none;) applied to the input node, causing manager.Focus to be confused as the field wasn't receiving a click event.

Changes:

Modified the shouldHideTrigger method in Text.mjs to return true to hide the trigger when the field is read-only.
Overridden the shouldHideTrigger method in Picker.mjs to return false to not hide the trigger for the Picker class.
Removed the CSS rules (pointer-events: none; user-select: none;) that were causing the onFocusLeave event issue from .neo-pickerfield .neo-not-editable .neo-textfield-input.

These changes result in a cleaner and expected behavior of the form.field.Select component when editable is set to false, ensuring that the picker hides correctly on onFocusLeave without being affected by the specified CSS rules.

Testing:

Ensure that the form.field.Select component behaves as expected when editable is set to both true and false.
Verify that the onFocusLeave event triggers the picker to hide correctly.
Test the interaction and focus behavior of the input node and picker trigger under different conditions.

What kind of change does this PR introduce? (check at least one)

Bugfix

Does this PR introduce a breaking change? (check one)

The PR fulfills these requirements:

It's submitted to the dev branch, not the master branch
When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

tobiu commented on Oct 5, 2023, 10:01 AM

hi @stokedowl, you did pick a pretty challenging ticket for getting started.

sadly, i can not accept the PR in the current state: we must not set readOnly to true for non-editable fields. while it does work, the problem is accessibility. setting this config will also apply readonly on DOM level: https://github.com/neomjs/neo/blob/dev/src/form/field/Text.mjs#L649

then browsers (or even worse screen readers) think, that users are not supposed to fill out the related field at all.

so, we need to apply the same logic, just in a different way. e.g. we do get the css selector neo-not-editable (inside form.field.Picker): https://github.com/neomjs/neo/blob/dev/resources/scss/src/form/field/Picker.scss

which currently already sets user-select: false. the problem here is that the field does not receive focus then, when clicking on the input node. as a result, focussing a different node will not trigger a focusLeave event and an open picker does not get hidden. solving it in a clean way is definitely non-trivial.

accessibility will become a huge topic for us starting in january => we want to add aria roles to each neo component and add keyboard navigation to more spots (e.g. toolbars & buttons).

in case more people want to contribute, we also need to get better in describing tickets & a roadmap. we can talk about it inside the workshop :)

ExtAnimal commented on Oct 12, 2023, 6:59 AM

Superseded by https://github.com/neomjs/neo/pull/5006