Frontmatter
| title | Add change event to fileupload |
| author | r-l-d |
| state | Merged |
| createdAt | Oct 12, 2023, 5:35 PM |
| updatedAt | Oct 13, 2023, 9:41 AM |
| closedAt | Oct 13, 2023, 9:41 AM |
| mergedAt | Oct 13, 2023, 9:41 AM |
| branches | dev ← dev |
| url | https://github.com/neomjs/neo/pull/5012 |
Merged

tobiu
commented on Oct 12, 2023, 6:27 PM
Hi Ross! I like it.
The only thing I would change is this one:
me.fireChangeEvent(value, oldValue)
=> also passing the previous state.
Up for @ExtAnimal to review it :)

r-l-d
commented on Oct 12, 2023, 6:30 PM
Hi Ross! I like it.
The only thing I would change is this one:
me.fireChangeEvent(value, oldValue)=> also passing the previous state.
Up for @ExtAnimal to review it :)
Thanks Tobi, I've added oldValue

ExtAnimal
APPROVED reviewed on Oct 13, 2023, 8:54 AM
No review body provided.
Please make sure to read the Contributing Guidelines:
https://github.com/neomjs/neo/blob/dev/CONTRIBUTING.md
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch, not themainbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: