LearnNewsExamplesServices
Frontmatter
titleRoute fixes
authorThorstenRaab
stateMerged
createdAtOct 19, 2023, 4:17 PM
updatedAtOct 19, 2023, 4:23 PM
closedAtOct 19, 2023, 4:23 PM
mergedAtOct 19, 2023, 4:23 PM
branchesdevroute_fixes
urlhttps://github.com/neomjs/neo/pull/5043
Merged
ThorstenRaab
ThorstenRaab commented on Oct 19, 2023, 4:17 PM

Please make sure to read the Contributing Guidelines:

https://github.com/neomjs/neo/blob/dev/CONTRIBUTING.md

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • [ x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [x ] It's submitted to the dev branch, not the main branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information: solves bug #5024, #5025

tobiu
tobiu APPROVED reviewed on Oct 19, 2023, 4:23 PM

todo: replace forEach to add break; once a match is found.