LearnNewsExamplesServices
Frontmatter
title#5102 onRowClick add altKey, ctrlKey, metaKey, shiftKey tests and fires
authorgplanansky
stateClosed
createdAtDec 1, 2023, 3:11 PM
updatedAtOct 23, 2024, 1:43 PM
closedAtOct 23, 2024, 1:43 PM
mergedAt
branchesdevgp-mods
urlhttps://github.com/neomjs/neo/pull/5120
Closed
gplanansky
gplanansky commented on Dec 1, 2023, 3:11 PM

What kind of change does this PR introduce? (check at least one)

  • Feature Does this PR introduce a breaking change? (check one)
  • No If adding a new feature, the PR's description includes:
  • per #5102 allows e.g. shift-click to raise a popup dialog to edit row record fields.
gplanansky
gplanansky commented on Dec 3, 2023, 10:25 PM

The code is now modified to handles both type "click" and type "dblclick"

  • handling dblclick is optional, controlled by the config parameter: "dblclickEnable" . The default value of false preserves old behavior.
  • all clicks fire "rowclick"
  • pure click also does row highligting and fires "select" or "deselect", identical to the old behavior
  • distinguishing clicks from a dblclick is via a setTimeout that waits "dblclickDelay" ms to test if dblclick has been detected. The configurable dblclickDelay is 510. A better way would be welcome.

tobiu
tobiu commented on Oct 23, 2024, 1:43 PM

closing this PR, since we can not add custom click logic into a table row selection model.