LearnNewsExamplesServices
Frontmatter
titlereadyState logic for running DomEvents.onDomContentLoaded
authorgplanansky
stateMerged
createdAtJun 11, 2024, 5:26 PM
updatedAtJun 11, 2024, 5:47 PM
closedAtJun 11, 2024, 5:47 PM
mergedAtJun 11, 2024, 5:47 PM
branchesdevgp-main.js-DomContentLoaded-fix
urlhttps://github.com/neomjs/neo/pull/5420
Merged
gplanansky
gplanansky commented on Jun 11, 2024, 5:26 PM

Need to run DomEvents.onContentLoaded()

  1. when the DOM is loaded, be it now or later
  2. only the one time

The existing code might run it twice. For an account of loading events and readyState values see: https://javascript.info/onload-ondomcontentloaded

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the main branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)