Frontmatter
| title | fix #6008:improve the home section of neo frontend |
| author | TusharMohapatra07 |
| state | Merged |
| createdAt | Oct 6, 2024, 3:09 PM |
| updatedAt | Oct 8, 2024, 4:22 PM |
| closedAt | Oct 8, 2024, 3:49 PM |
| mergedAt | Oct 8, 2024, 3:49 PM |
| branches | dev ← dev |
| url | https://github.com/neomjs/neo/pull/6020 |
hi @TusharMohapatra07,
the design-changes look good. One very important requirement, before i can accept & merge this PR: please do not change the default formatting, otherwise it becomes very hard to spot for others what changed.
Meaning: 4 spaces & block formatting (align on colon). You can just add another commit to this PR (no need for a new one) and I will accept it afterwards.
Ideas for a follow-up PR: we could switch the h1 & h2 tags (h2 for the logo-text, h1 for the tag-line) => can be easily done inside the matching JS file.
We do have CSS vars for font-weight:
font-weight: var(--core-fontweight-semibold);
There is also one for bold (I think it equals 700 instead of 800). var(--core-fontweight-bold);
Best regards, Tobi
@tobiu please review. Also, I'll be follow-up PR that You're talking about.
you hopefully know that you can review the changes too: https://github.com/neomjs/neo/pull/6020/files
you got the 4 spaces indentation in there now, which is good. the align on colon part is missing, but i will fix it.
hacktoberfest approved.
@tobiu i think the commit named "fix spacing" with hash 85ad0ff did that but then i thought it was wrong.
By the way, thanks @tobiu for your patience and time. You were such welcoming and supportive.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
devbranch, not themainbranchfix #xxx[,#xxx], where "xxx" is the issue number)Other information: This PR is linked with issue #6008. I have improved the look of the neo homepage by making the tagline significantly big such that it won't go unnoticed. Also, I've added a background pattern which complements the look of homepage.