LearnNewsExamplesServices
Frontmatter
titleFix README.md
authorjosh08h
stateMerged
createdAtMay 23, 2020, 3:40 PM
updatedAtMay 23, 2020, 3:51 PM
closedAtMay 23, 2020, 3:47 PM
mergedAtMay 23, 2020, 3:47 PM
branchesdevdev
urlhttps://github.com/neomjs/neo/pull/606
Merged
josh08h
josh08h commented on May 23, 2020, 3:40 PM

Please make sure to read the Contributing Guidelines:

https://github.com/neomjs/neo/blob/dev/CONTRIBUTING.md

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

tobiu
tobiu commented on May 23, 2020, 3:47 PM

thx! will look into it (should be possible by sticking to md syntax).


tobiu
tobiu commented on May 23, 2020, 3:51 PM

it would be possible with adjusting the href target to match the title, but your way is shorter. let's keep it like this.