LearnNewsExamplesServices
Frontmatter
titleMigrate vdom/VdomRealWorldUpdates test from Siesta to Playwright
authorKURO-1125
stateMerged
createdAtOct 4, 2025, 11:53 AM
updatedAtOct 4, 2025, 5:42 PM
closedAtOct 4, 2025, 4:15 PM
mergedAtOct 4, 2025, 4:15 PM
branchesdevmigrate-vdom-realworld-updates
urlhttps://github.com/neomjs/neo/pull/7349
Merged
KURO-1125
KURO-1125 commented on Oct 4, 2025, 11:53 AM

Migrates the Siesta test for vdom/VdomRealWorldUpdates.mjs to Playwright using the AI native workflow.

  • Create test/playwright/unit/vdom/VdomRealWorldUpdates.spec.mjs
  • Translate all Siesta assertions to Playwright expect syntax
  • Create proper ticket following project strategy
  • All tests pass successfully with npm test
  • Generated using AI native workflow

Closes #7292

Please make sure to read the Contributing Guidelines: https://github.com/neomjs/neo/blob/dev/CONTRIBUTING.md

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the main branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

This migration is part of the ongoing effort to convert Siesta tests to Playwright. The AI native workflow ensured proper adherence to project conventions and complete test coverage for VDOM real-world update scenarios.

tobiu
tobiu commented on Oct 4, 2025, 4:19 PM

thx! merged in.


tobiu
tobiu commented on Oct 4, 2025, 5:07 PM

A bit late now, but since this came up in another PR from a different contributor too, let me give you a hint on how to improve your workflow:

Search the https://github.com/neomjs/neo/tree/dev/.github/ISSUE folder for the github ticket id (#7292 in this case). or tell gemini to find it. Then gemini can read the ticket and related epic: https://github.com/neomjs/neo/blob/dev/.github/ISSUE/epic-enhance-workflow-with-mandatory-unit-testing.md https://github.com/neomjs/neo/blob/dev/.github/ISSUE/ticket-convert-vdom-vdomrealworldupdates-test.md

This prevents gemini from creating a new ticket md file, since there is already one in place. Plus, the epic contains valuable hints, smoothening the execution.


KURO-1125
KURO-1125 commented on Oct 4, 2025, 5:42 PM

Thanks for the tip! I'll definitely keep this in mind for my future contributions.