Frontmatter
| title | Convert functional/Parse5Processor.mjs Test from Siesta to Playwright #7284 |
| author | kart-u |
| state | Merged |
| createdAt | Oct 4, 2025, 1:32 PM |
| updatedAt | Oct 4, 2025, 7:55 PM |
| closedAt | Oct 4, 2025, 7:52 PM |
| mergedAt | Oct 4, 2025, 7:52 PM |
| branches | dev ← convert-parse5processor-siesta-playwright |
| url | https://github.com/neomjs/neo/pull/7353 |
Merged

tobiu
commented on Oct 4, 2025, 6:50 PM
Be careful with the imports as mentioned here: https://github.com/neomjs/neo/blob/dev/.github/ISSUE/epic-enhance-workflow-with-mandatory-unit-testing.md
=> we need the core import. plus calling the setup() method for tests.
we should not need manager/Instance.mjs I think, since Buttons do not get instanciated.
you can easily test this via npm test (or tell gemini to do it).
let me know if you want to adjust the PR, or if i should merge it and fix it afterwards.

kart-u
commented on Oct 4, 2025, 7:00 PM
ok I understood I will correct this now

kart-u
commented on Oct 4, 2025, 7:42 PM
done for all other submitted PRs too

tobiu
commented on Oct 4, 2025, 7:55 PM
thx! works fine.
Closes #7284
Please make sure to read the Contributing Guidelines:
https://github.com/neomjs/neo/blob/dev/CONTRIBUTING.md
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch, not themainbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: Used AI native workflows to migrate