LearnNewsExamplesServices
Frontmatter
titleConvert functional/Parse5Processor.mjs Test from Siesta to Playwright #7284
authorkart-u
stateMerged
createdAtOct 4, 2025, 1:32 PM
updatedAtOct 4, 2025, 7:55 PM
closedAtOct 4, 2025, 7:52 PM
mergedAtOct 4, 2025, 7:52 PM
branchesdevconvert-parse5processor-siesta-playwright
urlhttps://github.com/neomjs/neo/pull/7353
Merged
kart-u
kart-u commented on Oct 4, 2025, 1:32 PM

Closes #7284

Please make sure to read the Contributing Guidelines:

https://github.com/neomjs/neo/blob/dev/CONTRIBUTING.md

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the main branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information: Used AI native workflows to migrate

tobiu
tobiu commented on Oct 4, 2025, 6:50 PM

Be careful with the imports as mentioned here: https://github.com/neomjs/neo/blob/dev/.github/ISSUE/epic-enhance-workflow-with-mandatory-unit-testing.md

=> we need the core import. plus calling the setup() method for tests.

we should not need manager/Instance.mjs I think, since Buttons do not get instanciated.

you can easily test this via npm test (or tell gemini to do it).

let me know if you want to adjust the PR, or if i should merge it and fix it afterwards.


kart-u
kart-u commented on Oct 4, 2025, 7:00 PM

ok I understood I will correct this now


kart-u
kart-u commented on Oct 4, 2025, 7:42 PM

done for all other submitted PRs too


tobiu
tobiu commented on Oct 4, 2025, 7:55 PM

thx! works fine.