LearnNewsExamplesServices
Frontmatter
title>-
featissue creation script to Sync GitHub ID back to Markdown File (fixes:
authorLemonDrop847
stateMerged
createdAtOct 5, 2025, 4:58 PM
updatedAtOct 5, 2025, 7:49 PM
closedAtOct 5, 2025, 7:49 PM
mergedAtOct 5, 2025, 7:49 PM
branchesdev ← feat/issue-creation-script-sync-ghID-to-MD
urlhttps://github.com/neomjs/neo/pull/7380
Merged
LemonDrop847
LemonDrop847 commented on Oct 5, 2025, 4:58 PM

Please make sure to read the Contributing Guidelines:

https://github.com/neomjs/neo/blob/dev/CONTRIBUTING.md

Updated the createGhIssue.mjs to update the md file with the issue and update the issue ID and issue url in the md.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the main branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

LemonDrop847
LemonDrop847 commented on Oct 5, 2025, 4:59 PM

requesting a review @tobiu

tobiu
tobiu commented on Oct 5, 2025, 6:16 PM

thanks for the contribution. i am getting an error though on this page: "This branch cannot be rebased due to conflicts"

gemini input:

✦ I have reviewed the pull request. Here is my analysis:

PR Summary

This pull request modifies the createGhIssue.mjs script that was recently merged. The key change is an improvement to how the new GitHub issue ID is written back to the local markdown file.

  • Before: The script would simply prepend the GitHub issue ID and URL to the top of the file's body.
  • After: The script now actively looks for a placeholder (GH ticket id: #) and replaces it with the new ID and URL. If it doesn't find the placeholder, it falls back to the original prepending behavior.

This is a targeted refinement of the functionality delivered in the original PR, making the sync-back process more robust and predictable.

Analysis

  • Code Quality: The change is well-implemented. Using a regular expression to find and replace a specific placeholder is a clear improvement over the previous method.
  • Robustness: This change improves the script's robustness by ensuring the GitHub issue metadata is placed in a consistent, expected location within the ticket file. It does not, however, address the larger environmental issues (like auth or version checks) that we discussed previously, as that is not its goal.
  • Dependencies: The PR has no new dependencies. It relies on an authenticated gh CLI environment, just as the original script did.

Recommendation

Accept the PR.

This is a valuable, incremental improvement that makes our new issue creation workflow more polished and reliable. It's a safe and positive change.

LemonDrop847
LemonDrop847 commented on Oct 5, 2025, 6:28 PM

Should work now i hope

tobiu
tobiu commented on Oct 5, 2025, 7:49 PM

rebase and merge is still grayed out inside the GH ui, but i can do a merge commit (which i will do now).