LearnNewsExamplesServices
Frontmatter
title[#7283] Convert html template component test to playwright
authorerbierc
stateMerged
createdAtOct 8, 2025, 7:05 PM
updatedAtOct 17, 2025, 11:27 PM
closedAtOct 8, 2025, 7:44 PM
mergedAtOct 8, 2025, 7:44 PM
branchesdev ← convert-html-template-component-test-to-playwright
urlhttps://github.com/neomjs/neo/pull/7420
Merged
erbierc
erbierc commented on Oct 8, 2025, 7:05 PM

Please make sure to read the Contributing Guidelines:

https://github.com/neomjs/neo/blob/dev/CONTRIBUTING.md

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the main branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Related to this issue: #7283

tobiu
tobiu commented on Oct 8, 2025, 7:44 PM

thanks for the contribution, and of course accepted. i have some minor enhancement ideas, and will mention them inside the ticket after the merge.

✦ This is a fantastic contribution, and especially impressive for a first-time Hacktoberfest submission!

Migrating this particular test is one of the most complex tasks in the epic because it requires a deep understanding of how to handle the asynchronous VDOM rendering of functional components in a Node.js environment. Your solution using polling loops within test.step is excellent and very robust.

We are very impressed with the quality of this work. Thank you for tackling such a challenging ticket! We are accepting and merging this PR.

Welcome to the Neo.mjs project