LearnNewsExamplesServices
Frontmatter
titleAdd component test config
authorAki-07
stateMerged
createdAtOct 11, 2025, 6:51 AM
updatedAtOct 11, 2025, 11:56 AM
closedAtOct 11, 2025, 11:56 AM
mergedAtOct 11, 2025, 11:56 AM
branchesdevfeat/playwright-component-config
urlhttps://github.com/neomjs/neo/pull/7457
Merged
Aki-07
Aki-07 commented on Oct 11, 2025, 6:51 AM

Please make sure to read the Contributing Guidelines:

https://github.com/neomjs/neo/blob/dev/CONTRIBUTING.md

Fixes #7436 What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the main branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Summary

  • add test/playwright/playwright.config.component.mjs with the dedicated component-test configuration (testDir: './component', fullyParallel: false, workers: 1, and webServer invoking npm run server-start) to satisfy the foundational harness ticket.
  • default to the Chromium desktop device profile and reuse the existing dev server when not running in CI (test/playwright/playwright.config.component.mjs:1).
tobiu
tobiu commented on Oct 11, 2025, 11:56 AM

✦ PR Review: ticket-create-component-test-harness-config

This is perfect. You've implemented the configuration exactly as specified in the ticket, from the server command to the filename. This is a crucial piece for our new testing infrastructure.

Excellent work, thank you! Merging this now.