LearnNewsExamplesServices
Frontmatter
titledocs(testplan): add comprehensive test plan for Label component (#7488)
authorAlachi24
stateClosed
createdAtOct 19, 2025, 10:08 PM
updatedAtNov 9, 2025, 1:49 PM
closedAtNov 9, 2025, 1:49 PM
mergedAt
branchesdevtestplan_docs/label-component
urlhttps://github.com/neomjs/neo/pull/7548
Closed
Alachi24
Alachi24 commented on Oct 19, 2025, 10:08 PM

What kind of change does this PR introduce? (check at least one)

  • Documentation update
  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the main branch
  • The description clearly explains the update and its purpose
  • The updated files align with WORKING_WITH_AGENTS.md and AI_QUICK_START.md
  • No code or build behavior is affected

πŸ“ Summary

This PR adds a detailed test plan outlining inherited behavior scenarios for the Label component (Neo.form.field.Text). It ensures consistent functionality, predictable DOM behavior, and compliance with Neo’s framework standards.

πŸ”„ Changes

  • Added test plan documentation for the Label component at: .github/ISSUE/ticket-cpm-test-component-label.md
  • Covered inherited behaviors including:
    • disabled, hidden, cls, and style configurations
    • DOM state validation for disabled/hidden states
    • Programmatic value update handling (value config)
    • isDirty flag change detection

πŸ’‘ Impact

  • Establishes a baseline test structure for inherited Label behavior
  • Enhances framework consistency and developer confidence when extending components
  • No runtime or functional code changes β€” documentation-only contribution

Other information:

This PR is part of the Hacktoberfest 2025 initiative to improve test coverage and developer documentation across the Neo.mjs component library.

Markdown preview: ticket-cpm-test-component-label

Closes #7488

Please, your review is needed @tobiu

tobiu
tobiu commented on Oct 24, 2025, 10:52 AM

Input from Gemini:

Hi @Alachi24, thank you for your contribution and for following the Hacktoberfest "Cookbook" epic (#7475) to create this test plan.

I've reviewed the PR and it looks like there has been a mix-up between two different components, which is an easy mistake to make.

  1. Incorrect Component Target: The PR is for the "Label component" (Neo.component.Label), but the test plan's acceptance criteria are for the Text field (Neo.form.field.Text). It seems you may have accidentally used the example from the cookbook epic, which was for the Text field, as the basis for your plan. Could you please generate a new test plan that is specifically for Neo.component.Label? It's a much simpler component, so the plan will be shorter.

  2. Unrelated package.json Changes: This PR also includes large changes to package.json and package-lock.json. These files should not be modified in a documentation PR. Please revert the changes to these two files so that the PR only contains the new test plan markdown file.

If you'd like to create the test plan for Neo.form.field.Text instead, that's perfectly fine too! Just let me know, and we can update the PR's title and description accordingly.

Once these issues are resolved, I'll be happy to review it again. Thanks for your efforts!


Alachi24
Alachi24 commented on Oct 26, 2025, 8:05 AM

@tobiu , Please, due to recent changes, I noticed the epic cookbook I need for references is no longer under the ISSUES folder. can you direct me to its new location? This is what I'm referring to: .github/ISSUE/epic-cookbook-create-test-plans.md


tobiu
tobiu commented on Oct 26, 2025, 9:25 AM

Well, this is related to the new 2-way sync. all locally saved tickets now have the format issue-<gh-id>.md


Alachi24
Alachi24 commented on Oct 28, 2025, 8:57 PM

I have tried checking all the issues and I didn't see the epic cookbook which is needed for the task to commence. Really challenging @tobiu


tobiu
tobiu commented on Nov 1, 2025, 7:05 PM

the cookbook is this one: https://github.com/neomjs/neo/issues/7475. it should also be inside your fork, in case you update it and search for the id 7475 inside .github/ISSUE.


Alachi24
Alachi24 commented on Nov 6, 2025, 4:14 PM

It has been worked on, please look at it and confirm if it's on track. @tobiu


tobiu
tobiu commented on Nov 6, 2025, 7:30 PM

i would add to update the text config at run-time, to verify that the DOM updates. To get the PR accepted, please remove the package.json and package-lock changes. thx.


Alachi24
Alachi24 commented on Nov 7, 2025, 1:39 PM

It's done. kindly confirm @tobiu


tobiu
tobiu commented on Nov 8, 2025, 11:07 AM

take a look at: https://github.com/neomjs/neo/pull/7548/files => still shows 3 files instead of one.

inside your fork, you could just rollback the 2 files that should not be inside this PR and then do another commit.


Alachi24
Alachi24 commented on Nov 8, 2025, 10:19 PM

@tobiu I have tried rolling back, but the thing here is, only the required file for PR was pushed, the package-lock and package.json weren't involved. I have resorted to deleting the whole package file on this particular branch, but it still shows 3 file changes.