LearnNewsExamplesServices
Frontmatter
titlefeat(mcp/github-workflow): add list_issues tool, OpenAPI path/schemas
authorMannXo
stateMerged
createdAtOct 28, 2025, 10:31 AM
updatedAtNov 1, 2025, 7:22 PM
closedAtNov 1, 2025, 7:22 PM
mergedAtNov 1, 2025, 7:22 PM
branchesdev ← feature/github-list-issues-mcp
urlhttps://github.com/neomjs/neo/pull/7678
Merged
MannXo
MannXo commented on Oct 28, 2025, 10:31 AM

Please make sure to read the Contributing Guidelines:

https://github.com/neomjs/neo/blob/dev/CONTRIBUTING.md

Does this PR resolve an issue? (Required)

Closes #7663

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills this requirement: Includes:

  • IssueService.listIssues implementation

  • Registered list_issues in toolService

  • OpenAPI: GET /issues + IssueListResponse schema

  • lightweight file-based verification tests

  • HealthService robustness fix for gh stdout/stderr

  • It's submitted to the dev branch, not the main branch

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

tobiu
tobiu commented on Nov 1, 2025, 7:21 PM

Input from Gemini 2.5 pro:

✦ Thank you for this excellent contribution, @MannXo! The implementation of the list_issues tool is clean, the OpenAPI updates are thorough, and the robustness fixes in HealthService are a welcome improvement.

We appreciate the extra effort you've put into making the MCP server more robust and adding tests. For future contributions, we'd like to ask you to open separate issues for distinct pieces of work. In this case:

  1. The HealthService improvements, especially regarding the server's behavior when the gh cli is not installed, would ideally be a separate ticket. This allows us to thoroughly investigate and enhance the server's startup robustness independently.
  2. The introduction of new testing files, while valuable, should also be a separate ticket. Our current testing suite uses Playwright, and we need to carefully consider how to best integrate new server tests into this existing framework. This would involve a dedicated discussion and planning phase to ensure consistency and maintainability.

Sticking to a "one ticket, one PR" workflow helps us in a few key ways:

  • Keeps reviews focused and fast.
  • Creates a clear, traceable history for every single change.
  • Ensures our AI knowledge base has the right context, which is crucial for our development process.

This is a fantastic PR, and we are happy to merge it. We're looking forward to your future contributions!