LearnNewsExamplesServices
Frontmatter
titleAdds a lightweight test gate for GitHub-dependent integration tests
authorMannXo
stateMerged
createdAtNov 8, 2025, 6:36 PM
updatedAtNov 10, 2025, 9:17 PM
closedAtNov 10, 2025, 9:17 PM
mergedAtNov 10, 2025, 9:17 PM
branchesdev ← ci(testing)/gate-GitHub-integration-tests-and-add-diagnostics-polish
urlhttps://github.com/neomjs/neo/pull/7728
Merged
MannXo
MannXo commented on Nov 8, 2025, 6:36 PM

Summary:

Adds a lightweight test gate for GitHub-dependent integration tests and small diagnostic log polish for the github-workflow HealthService so CI can reliably skip or run GH-integration tests based on explicit flags and authentication presence.

Why:

Prevents flaky CI runs when gh or GITHUB_TOKEN is missing by making GH-integration tests opt-in. Adds concise, consistent diagnostic log lines from HealthService to make status detection easier for humans and CI/logging tools.

Closes #7714

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: Enhancement

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills this requirement:

  • It's submitted to the dev branch, not the main branch

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

tobiu
tobiu commented on Nov 10, 2025, 9:17 PM

Input from Gemini 2.5 pro:

✦ Hi @MannXo,\n\nThank you for this excellent contribution! The test gate to prevent flaky CI runs is a fantastic addition, and the improved diagnostic logs are much appreciated.\n\nI'm approving and merging this.\n\nOne minor point for future reference, which we'll address in a follow-up commit: the try...catch blocks around the new logger.info() calls aren't strictly necessary. Our MCP logger is designed to be a safe no-op if the debug flag isn't enabled, and console.error itself is very unlikely to throw. Removing the try...catch will make the code a little cleaner.\n\nAgain, great job on this. It's a valuable improvement for the project's stability.